verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 69 Releases Wiki Activity

fix: #8349 fixed ItemFixedPrice crashing and it's e2e test not working #1289

Open
provira wants to merge 5 commits from 8349-e2eItemFixedPrice into dev
pull from: 8349-e2eItemFixedPrice
merge into: verdnatura:dev
Conversation 0 Commits 5 Files Changed 2 +42 -39
provira commented 2025-01-27 11:27:49 +00:00
Member
Copy Link
No description provided.
provira added 1 commit 2025-01-27 11:27:50 +00:00
provira added 1 commit 2025-01-27 11:28:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
252aa6a8bc Merge branch 'dev' into 8349-e2eItemFixedPrice
provira requested review from alexm 2025-01-27 11:29:38 +00:00
alexm requested changes 2025-01-29 06:31:44 +00:00
src/pages/Item/ItemFixedPrice.vue Outdated
@ -246,4 +252,2 @@
if (!changes.updates && !changes.creates) return;
const data = await upsertFixedPrice(row);
Object.assign(tableRef.value.CrudModelRef.formData[props.rowIndex], data);
notify(t('globals.dataSaved'), 'positive');
alexm commented 2025-01-29 06:20:43 +00:00
Member
Copy Link

Ya no se quiere ni el mensaje, ni el reload?

Ya no se quiere ni el mensaje, ni el reload?
src/pages/Item/ItemFixedPrice.vue
@ -370,3 +373,3 @@
</RightMenu>
<VnSubToolbar>
<template #st-actions>
<template #st-data>
alexm commented 2025-01-29 06:21:50 +00:00
Member
Copy Link

Los botones van a la derecha

Los botones van a la derecha
src/pages/Item/ItemFixedPrice.vue
@ -373,2 +375,3 @@
<template #st-data>
<QBtn
:disable="!hasSelectedRows"
v-if="rowsSelected.length"
alexm commented 2025-01-29 06:21:41 +00:00
Member
Copy Link

Normalmente es mejor deshabilitar, que quitar. Si no el ususario hasta que no hace x cosa no sabe que acciones puede hacer

Normalmente es mejor deshabilitar, que quitar. Si no el ususario hasta que no hace x cosa no sabe que acciones puede hacer
src/pages/Item/ItemFixedPrice.vue
@ -395,0 +398,4 @@
@on-fetch="
(data) =>
data.forEach((item) => {
item.hasMinPrice = `${item.hasMinPrice !== 0}`;
alexm commented 2025-01-29 06:31:42 +00:00
Member
Copy Link

Usar booleanos:

✅ Mejora la claridad del código

✅ Reduce posibles bugs

✅ Sigue estándares de la industria

✅ Optimiza rendimiento

Usar booleanos: ✅ Mejora la claridad del código ✅ Reduce posibles bugs ✅ Sigue estándares de la industria ✅ Optimiza rendimiento
provira added 2 commits 2025-01-29 07:34:39 +00:00
provira added 1 commit 2025-01-31 10:39:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
97704a37ba Merge branch 'dev' into 8349-e2eItemFixedPrice
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1289
No description provided.
Delete Branch "8349-e2eItemFixedPrice"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?