fix: #8349 fixed ItemFixedPrice crashing and it's e2e test not working #1289

Open
provira wants to merge 18 commits from 8349-e2eItemFixedPrice into dev
Member
No description provided.
provira added 1 commit 2025-01-27 11:27:50 +00:00
provira added 1 commit 2025-01-27 11:28:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
252aa6a8bc
Merge branch 'dev' into 8349-e2eItemFixedPrice
provira requested review from alexm 2025-01-27 11:29:38 +00:00
alexm requested changes 2025-01-29 06:31:44 +00:00
@ -246,4 +252,2 @@
if (!changes.updates && !changes.creates) return;
const data = await upsertFixedPrice(row);
Object.assign(tableRef.value.CrudModelRef.formData[props.rowIndex], data);
notify(t('globals.dataSaved'), 'positive');
Member

Ya no se quiere ni el mensaje, ni el reload?

Ya no se quiere ni el mensaje, ni el reload?
Author
Member

Error mio, ya esta puesto de vuelta

Error mio, ya esta puesto de vuelta
@ -370,3 +373,3 @@
</RightMenu>
<VnSubToolbar>
<template #st-actions>
<template #st-data>
Member

Los botones van a la derecha

Los botones van a la derecha
provira marked this conversation as resolved
@ -373,2 +375,3 @@
<template #st-data>
<QBtn
:disable="!hasSelectedRows"
v-if="rowsSelected.length"
Member

Normalmente es mejor deshabilitar, que quitar. Si no el ususario hasta que no hace x cosa no sabe que acciones puede hacer

Normalmente es mejor deshabilitar, que quitar. Si no el ususario hasta que no hace x cosa no sabe que acciones puede hacer
provira marked this conversation as resolved
@ -395,0 +398,4 @@
@on-fetch="
(data) =>
data.forEach((item) => {
item.hasMinPrice = `${item.hasMinPrice !== 0}`;
Member

Usar booleanos:

Mejora la claridad del código

Reduce posibles bugs

Sigue estándares de la industria

Optimiza rendimiento

Usar booleanos: ✅ Mejora la claridad del código ✅ Reduce posibles bugs ✅ Sigue estándares de la industria ✅ Optimiza rendimiento
Author
Member

Esto no hace falta al final

Esto no hace falta al final
provira added 2 commits 2025-01-29 07:34:39 +00:00
provira added 1 commit 2025-01-31 10:39:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
97704a37ba
Merge branch 'dev' into 8349-e2eItemFixedPrice
provira added 2 commits 2025-02-03 07:38:15 +00:00
provira added 1 commit 2025-02-03 07:38:56 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1d3e3f8f9a
Merge branch 'dev' into 8349-e2eItemFixedPrice
provira requested review from alexm 2025-02-03 07:44:45 +00:00
provira added 1 commit 2025-02-03 09:24:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0eed4288bc
Merge branch 'dev' into 8349-e2eItemFixedPrice
alexm requested changes 2025-02-03 12:46:50 +00:00
@ -44,3 +37,4 @@
cy.dataCy('VnConfirm_confirm').click();
});
it.skip('Massive edit', function () {
Member

Se deja en skip??

Se deja en skip??
provira marked this conversation as resolved
provira added 1 commit 2025-02-03 12:50:01 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
edb083a6ab
Merge branch 'dev' into 8349-e2eItemFixedPrice
provira added 1 commit 2025-02-04 08:07:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b5900dc6ef
fix: refs #8349 fixed duplicate request when multiple editing
provira added 1 commit 2025-02-04 08:10:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e289bd456d
Merge branch 'dev' into 8349-e2eItemFixedPrice
provira requested review from alexm 2025-02-04 08:11:02 +00:00
alexm requested changes 2025-02-07 07:53:20 +00:00
@ -38,6 +39,9 @@ const warehousesOptions = ref([]);
const hasSelectedRows = computed(() => rowsSelected.value.length > 0);
const rowsSelected = ref([]);
const itemFixedPriceFilterRef = ref();
const reloadTable = debounce(() => {
Member

No creo que un timeout (es parecido) sea la mejor opcion. Si el problema es que hace reload demasiado rapido. Habra algo que se pueda mirar para saber que ya debe recargar

No creo que un timeout (es parecido) sea la mejor opcion. Si el problema es que hace reload demasiado rapido. Habra algo que se pueda mirar para saber que ya debe recargar
provira added 1 commit 2025-02-07 10:53:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5a030035cd
Merge branch 'dev' into 8349-e2eItemFixedPrice
provira added 2 commits 2025-02-07 11:19:54 +00:00
provira added 1 commit 2025-02-21 09:16:00 +00:00
alexm reviewed 2025-02-21 09:24:33 +00:00
alexm requested changes 2025-02-21 09:24:59 +00:00
alexm left a comment
Member
https://meet.google.com/buo-jrew-mbt
@ -43,1 +32,4 @@
cy.get(`${secondRow} > :nth-child(4) > .q-td`).type("1{enter}");
cy.get(`${secondRow} > :nth-child(9)`).type('Warehouse One');
cy.get('.q-menu .q-item').contains('Warehouse One').click();
cy.get('.q-notification__message').should('have.text', 'Data saved');
Member

Usar checkNotification

Usar checkNotification
provira added 1 commit 2025-02-21 10:54:53 +00:00
provira requested review from alexm 2025-02-21 10:57:41 +00:00
alexm requested changes 2025-02-28 11:24:41 +00:00
@ -423,0 +423,4 @@
:crud-model="{
disableInfiniteScroll: true,
}"
:use-model="true"
Member

Habeis probado los filtros?

Habeis probado los filtros?
Author
Member

Si, funcionan correctamente

Si, funcionan correctamente
provira added 1 commit 2025-03-04 07:17:54 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
eb7f83f496
feat: refs #8349 added test cases for filters
jon was assigned by jsegarra 2025-03-07 08:58:44 +00:00
Some checks failed
gitea/salix-front/pipeline/pr-dev There was a failure building this commit
Required
Details
This pull request has changes conflicting with the target branch.
  • test/cypress/integration/item/ItemFixedPrice.spec.js
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1289
No description provided.