verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

fix: #8349 fixed ItemFixedPrice crashing and it's e2e test not working #1289

Open
provira wants to merge 18 commits from 8349-e2eItemFixedPrice into dev
pull from: 8349-e2eItemFixedPrice
merge into: verdnatura:dev
Conversation 0 Commits 18 Files Changed 2 +47 -39
2 changed files with 47 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e862110aca - Show all commits

39
src/pages/Item/ItemFixedPrice.vue
View File

@ -35,7 +35,6 @@ const editTableCellDialogRef = ref(null);
const user = state.getUser();
const fixedPrices = ref([]);
const warehousesOptions = ref([]);
const hasSelectedRows = computed(() => rowsSelected.value.length > 0);
const rowsSelected = ref([]);
const itemFixedPriceFilterRef = ref();
@ -54,6 +53,7 @@ const columns = computed(() => [
name: 'itemFk',
...defaultColumnAttrs,
isId: true,
cardVisible: true,
columnField: {
component: 'input',
type: 'number',
@ -65,12 +65,14 @@ const columns = computed(() => [
name: 'name',
...defaultColumnAttrs,
create: true,
cardVisible: true,
},
{
label: t('item.fixedPrice.groupingPrice'),
field: 'rate2',
name: 'rate2',
...defaultColumnAttrs,
cardVisible: true,
component: 'input',
type: 'number',
},
@ -79,6 +81,7 @@ const columns = computed(() => [
field: 'rate3',
name: 'rate3',
...defaultColumnAttrs,
cardVisible: true,
component: 'input',
type: 'number',
},
@ -88,6 +91,7 @@ const columns = computed(() => [
field: 'minPrice',
name: 'minPrice',
...defaultColumnAttrs,
cardVisible: true,
component: 'input',
type: 'number',
},
@ -96,6 +100,7 @@ const columns = computed(() => [
field: 'started',
name: 'started',
format: ({ started }) => toDate(started),
cardVisible: true,
...defaultColumnAttrs,
columnField: {
component: 'date',
@ -111,6 +116,7 @@ const columns = computed(() => [
field: 'ended',
name: 'ended',
...defaultColumnAttrs,
cardVisible: true,
columnField: {
component: 'date',
class: 'shrink',
@ -245,14 +251,11 @@ const upsertPrice = async (props, resetMinPrice = false) => {
}
if (!changes.updates && !changes.creates) return;
const data = await upsertFixedPrice(row);
Object.assign(tableRef.value.CrudModelRef.formData[props.rowIndex], data);
notify(t('globals.dataSaved'), 'positive');
alexm commented 2025-01-29 06:20:43 +00:00
Outdated
Review
Copy Link

Ya no se quiere ni el mensaje, ni el reload?

Ya no se quiere ni el mensaje, ni el reload?
provira commented 2025-02-03 07:37:29 +00:00
Outdated
Review
Copy Link

Error mio, ya esta puesto de vuelta

Error mio, ya esta puesto de vuelta
tableRef.value.reload();
tableRef.value.CrudModelRef.formData[props.rowIndex] = data;
};
async function upsertFixedPrice(row) {
const { data } = await axios.patch('FixedPrices/upsertFixedPrice', row);
data.hasMinPrice = data.hasMinPrice ? 1 : 0;
return data;
}
@ -369,9 +372,9 @@ function handleOnDataSave({ CrudModelRef }) {
</template>
</RightMenu>
<VnSubToolbar>
<template #st-actions>
<template #st-data>
provira marked this conversation as resolved Outdated
alexm commented 2025-01-29 06:21:50 +00:00
Outdated
Review
Copy Link

Los botones van a la derecha

Los botones van a la derecha
<QBtn
:disable="!hasSelectedRows"
v-if="rowsSelected.length"
provira marked this conversation as resolved Outdated
alexm commented 2025-01-29 06:21:41 +00:00
Outdated
Review
Copy Link

Normalmente es mejor deshabilitar, que quitar. Si no el ususario hasta que no hace x cosa no sabe que acciones puede hacer

Normalmente es mejor deshabilitar, que quitar. Si no el ususario hasta que no hace x cosa no sabe que acciones puede hacer
@click="openEditTableCellDialog()"
color="primary"
icon="edit"
@ -381,17 +384,23 @@ function handleOnDataSave({ CrudModelRef }) {
</QTooltip>
</QBtn>
<QBtn
:disable="!hasSelectedRows"
:label="tMobile('globals.remove')"
color="primary"
icon="delete"
flat
@click="(row) => confirmRemove(row, true)"
:title="t('globals.remove')"
v-if="rowsSelected.length"
/>
</template>
</VnSubToolbar>
<VnTable
@on-fetch="
(data) =>
data.forEach((item) => {
item.hasMinPrice = `${item.hasMinPrice !== 0}`;
alexm commented 2025-01-29 06:31:42 +00:00
Outdated
Review
Copy Link

Usar booleanos:

✅ Mejora la claridad del código

✅ Reduce posibles bugs

✅ Sigue estándares de la industria

✅ Optimiza rendimiento

Usar booleanos: ✅ Mejora la claridad del código ✅ Reduce posibles bugs ✅ Sigue estándares de la industria ✅ Optimiza rendimiento
provira commented 2025-02-03 07:37:46 +00:00
Outdated
Review
Copy Link

Esto no hace falta al final

Esto no hace falta al final
})
"
:default-remove="false"
:default-reset="false"
:default-save="false"
@ -422,6 +431,11 @@ function handleOnDataSave({ CrudModelRef }) {
onDataSaved: handleOnDataSave,
}"
:disable-option="{ card: true }"
:bottom="true"
:crud-model="{
disableInfiniteScroll: true,
}"
:disabled-attr="true"
>
<template #header-selection="scope">
<QCheckbox v-model="scope.selected" />
@ -457,7 +471,7 @@ function handleOnDataSave({ CrudModelRef }) {
</span>
<span class="subName">{{ row.subName }}</span>
<ItemDescriptorProxy :id="row.itemFk" />
<FetchedTags :item="row" :columns="3" />
<FetchedTags :item="row" />
</template>
<template #column-rate2="props">
<QTd class="col">
@ -489,15 +503,14 @@ function handleOnDataSave({ CrudModelRef }) {
<QCheckbox
:model-value="props.row.hasMinPrice"
@update:model-value="updateMinPrice($event, props)"
:false-value="0"
:true-value="1"
:toggle-indeterminate="false"
:false-value="'false'"
:true-value="'true'"
/>
<VnInput
class="col"
type="currency"
mask="###.##"
:disable="props.row.hasMinPrice === 0"
:disable="props.row.hasMinPrice === 1"
v-model.number="props.row.minPrice"
v-on="getRowUpdateInputEvents(props)"
>

47
test/cypress/integration/item/ItemFixedPrice.spec.js
View File

@ -3,7 +3,9 @@ function goTo(n = 1) {
return `.q-virtual-scroll__content > :nth-child(${n})`;
}
const firstRow = goTo();
`.q-virtual-scroll__content > :nth-child(2)`;
const secondRow = goTo(2);
`.q-virtual-scroll__content > :nth-child(1)`;
describe('Handle Items FixedPrice', () => {
beforeEach(() => {
cy.viewport(1280, 720);
@ -14,33 +16,25 @@ describe('Handle Items FixedPrice', () => {
'.q-header > .q-toolbar > :nth-child(1) > .q-btn__content > .q-icon'
).click();
});
it.skip('filter', function () {
cy.get('.category-filter > :nth-child(1) > .q-btn__content > .q-icon').click();
cy.selectOption('.list > :nth-child(2)', 'Alstroemeria');
it('filter', function () {
cy.get('.category-filter > :nth-child(2) > .q-btn__content > .q-icon').click();
cy.selectOption('.list > :nth-child(2)', 'Crisantemo');
cy.get('.q-gutter-x-sm > .q-btn > .q-btn__content > .q-icon').click();
cy.addBtnClick();
cy.selectOption(`${firstRow} > :nth-child(2)`, '#13');
cy.get(`${firstRow} > :nth-child(4)`).find('input').type(1);
cy.get(`${firstRow} > :nth-child(5)`).find('input').type('2');
cy.selectOption(`${firstRow} > :nth-child(9)`, 'Warehouse One');
cy.get('.q-notification__message').should('have.text', 'Data saved');
/* ==== End Cypress Studio ==== */
});
it.skip('Create and delete ', function () {
cy.get('.q-gutter-x-sm > .q-btn > .q-btn__content > .q-icon').click();
cy.addBtnClick();
cy.selectOption(`${firstRow} > :nth-child(2)`, '#11');
cy.get(`${firstRow} > :nth-child(4)`).type('1');
cy.get(`${firstRow} > :nth-child(5)`).type('2');
cy.selectOption(`${firstRow} > :nth-child(9)`, 'Warehouse One');
cy.get('.q-notification__message').should('have.text', 'Data saved');
cy.get('.q-gutter-x-sm > .q-btn > .q-btn__content > .q-icon').click();
cy.get(`${firstRow} > .text-right > .q-btn > .q-btn__content > .q-icon`).click();
cy.get(
'.q-card__actions > .q-btn--unelevated > .q-btn__content > .block'
).click();
it('Create and delete ', function () {
cy.get('.q-gutter-x-sm > .q-btn > .q-btn__content').click();
cy.get('.bottomButton > .q-btn > .q-btn__content > .q-icon').click();
cy.get(`${secondRow} > :nth-child(2)`).type('11');
cy.get('.q-menu .q-item').contains('#11').click();
cy.get(`${secondRow} > :nth-child(4)`).find('input').type(1);
cy.get(`${secondRow} > :nth-child(5)`).find('input').type(2);
cy.get(`${secondRow} > :nth-child(9)`).type('Warehouse One');
cy.get('.q-menu .q-item').contains('Warehouse One').click();
cy.get('.q-notification__message').should('have.text', 'Data saved');
alexm commented 2025-02-21 09:24:56 +00:00
Outdated
Review
Copy Link

Usar checkNotification

Usar checkNotification
cy.get(':nth-child(3) > .text-right > .q-btn').click();
cy.dataCy('VnConfirm_confirm').click();
});
it.skip('Massive edit', function () {
provira marked this conversation as resolved Outdated
alexm commented 2025-02-03 12:46:29 +00:00
Outdated
Review
Copy Link

Se deja en skip??

Se deja en skip??
@ -48,11 +42,12 @@ describe('Handle Items FixedPrice', () => {
cy.get('#subToolbar > .q-btn--standard').click();
cy.selectOption("[data-cy='field-to-edit']", 'Min price');
cy.dataCy('value-to-edit').find('input').type('1');
cy.get('.countLines').should('have.text', ' 1 ');
cy.get('.countLines').invoke('text').then(parseFloat).should('be.gte', 1);
cy.get('.q-mt-lg > .q-btn--standard').click();
//Falla debido a que hay una petición doble
cy.get('.q-notification__message').should('have.text', 'Data saved');
});
it.skip('Massive remove', function () {
it('Massive remove', function () {
cy.get(' .bg-header > :nth-child(1) > .q-checkbox > .q-checkbox__inner ').click();
cy.get('#subToolbar > .q-btn--flat').click();
cy.get(