verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

fix: #8349 fixed ItemFixedPrice crashing and it's e2e test not working #1289

Open
provira wants to merge 18 commits from 8349-e2eItemFixedPrice into dev
pull from: 8349-e2eItemFixedPrice
merge into: verdnatura:dev
Conversation 0 Commits 18 Files Changed 2 +17 -22
2 changed files with 17 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fa5eead5ad - Show all commits

10
src/pages/Item/ItemFixedPrice.vue
View File

@ -23,7 +23,6 @@ import { isLower, isBigger } from 'src/filters/date.js';
import RightMenu from 'src/components/common/RightMenu.vue';
import VnTable from 'src/components/VnTable/VnTable.vue';
import { QCheckbox } from 'quasar';
import { debounce } from 'lodash';
const quasar = useQuasar();
const stateStore = useStateStore();
@ -39,9 +38,6 @@ const warehousesOptions = ref([]);
const hasSelectedRows = computed(() => rowsSelected.value.length > 0);
const rowsSelected = ref([]);
const itemFixedPriceFilterRef = ref();
const reloadTable = debounce(() => {
tableRef.value.reload();
}, 500);
onMounted(async () => {
alexm commented 2025-02-07 07:53:15 +00:00
Outdated
Review
Copy Link

No creo que un timeout (es parecido) sea la mejor opcion. Si el problema es que hace reload demasiado rapido. Habra algo que se pueda mirar para saber que ya debe recargar

No creo que un timeout (es parecido) sea la mejor opcion. Si el problema es que hace reload demasiado rapido. Habra algo que se pueda mirar para saber que ya debe recargar
stateStore.rightDrawer = true;
@ -238,7 +234,7 @@ const validations = ({ row }) => {
'warehouseFk',
];
const isValid = requiredFields.every(
(field) => row[field] !== null && row[field] !== undefined,
(field) => row[field] !== null && row[field] !== undefined
);
return isValid;
};
@ -313,7 +309,7 @@ const openEditTableCellDialog = () => {
const onEditCellDataSaved = async () => {
rowsSelected.value = [];
reloadTable();
tableRef.value.reload();
};
const removeFuturePrice = async () => {
@ -560,7 +556,7 @@ function handleOnDataSave({ CrudModelRef }) {
openConfirmationModal(
t('globals.rowWillBeRemoved'),
t('Do you want to clone this item?'),
() => removePrice(row.id, rowIndex),
() => removePrice(row.id, rowIndex)
)
"
>

29
test/cypress/integration/item/ItemFixedPrice.spec.js
View File

@ -1,13 +1,14 @@
/// <reference types="cypress" />
function goTo(n = 1) {
return `.q-virtual-scroll__content > :nth-child(${n})`;
}
const firstRow = goTo();
const secondRow = goTo(2);
`.q-virtual-scroll__content > :nth-child(1)`;
describe('Handle Items FixedPrice', () => {
beforeEach(() => {
beforeEach(() => {
Cypress.on('uncaught:exception', (err, runnable) => {
if (err.message.includes('canceled')) {
return false;
}
return true;
});
cy.viewport(1280, 720);
cy.login('developer');
cy.visit('/#/item/fixed-price', { timeout: 5000 });
@ -20,17 +21,15 @@ describe('Handle Items FixedPrice', () => {
cy.get('.category-filter > :nth-child(2) > .q-btn__content > .q-icon').click();
cy.selectOption('.list > :nth-child(2)', 'Crisantemo');
cy.get('.q-gutter-x-sm > .q-btn > .q-btn__content > .q-icon').click();
/* ==== End Cypress Studio ==== */
});
it('Create and delete ', function () {
cy.get('.q-gutter-x-sm > .q-btn > .q-btn__content').click();
cy.dataCy('vnTableCreateBtn').click();
cy.get(`${secondRow} > :nth-child(5) > .q-td`).type("2{enter}");
cy.get(`${secondRow} > :nth-child(2)`).type('11');
cy.get('.q-menu .q-item').contains('#11').click();
cy.get(`${secondRow} > :nth-child(4) > .q-td`).type("1{enter}");
cy.get(`${secondRow} > :nth-child(9)`).type('Warehouse One');
cy.get(':nth-child(2) > [data-col-field="rate2"] > .no-padding > .q-td').type("1{enter}");
cy.get('.highlight > [data-col-field="rate3"] > .no-padding > .q-td').type("2{enter}");
cy.selectOption('.highlight > [data-col-field="itemFk"]', '#11');
cy.get('.highlight > [data-col-field="warehouseFk"]').type('Warehouse One');
cy.get('.q-menu .q-item').contains('Warehouse One').click();
cy.get('.q-notification__message').should('have.text', 'Data saved');
cy.get(':nth-child(3) > .text-right > .q-btn').click();
alexm commented 2025-02-21 09:24:56 +00:00
Outdated
Review
Copy Link

Usar checkNotification

Usar checkNotification
@ -44,7 +43,7 @@ describe('Handle Items FixedPrice', () => {
cy.dataCy('value-to-edit').find('input').type('1');
cy.get('.countLines').invoke('text').then(parseFloat).should('be.gte', 1);
cy.get('.q-mt-lg > .q-btn--standard').click();
cy.get('.q-notification__message').should('have.text', 'Data saved');
cy.checkNotification('Data saved');
});
it('Massive remove', function () {
cy.get(' .bg-header > :nth-child(1) > .q-checkbox > .q-checkbox__inner ').click();
@ -52,6 +51,6 @@ describe('Handle Items FixedPrice', () => {
cy.get(
'.q-card__actions > .q-btn--unelevated > .q-btn__content > .block'
).click();
cy.get('.q-notification__message').should('have.text', 'Data saved');
cy.checkNotification('Data saved');
});
});