verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 71 Releases Wiki Activity

WIP: feat: refs #8463 cardDescriptorBeta #1291

Draft
alexm wants to merge 1 commits from 8463-CardDescriptor_useCard into dev
pull from: 8463-CardDescriptor_useCard
merge into: verdnatura:dev
Conversation 1 Commits 1 Files Changed 6 +358 -64
alexm commented 2025-01-27 13:21:25 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2025-01-27 13:21:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a6a2723734 feat: refs #8463 cardDescriptorBeta
alexm reviewed 2025-01-27 13:22:13 +00:00
src/components/common/VnCardBeta.vue
@ -56,1 +71,3 @@
});
watch(
() => arrayData?.value?.isLoading,
(loading) => !loading && emit('onFetch', arrayData.value.store.data),
alexm commented 2025-01-27 13:22:13 +00:00
Author
Member
Copy Link

Con este watcher hacemos que cuando el card cambie de estado, emita los datos.

Con este watcher hacemos que cuando el card cambie de estado, emita los datos.
alexm reviewed 2025-01-27 13:24:04 +00:00
src/components/ui/CardDescriptorBeta.vue
@ -0,0 +73,4 @@
<template>
{{ id }}
<component
alexm commented 2025-01-27 13:24:04 +00:00
Author
Member
Copy Link

Usamos el card, pero pasandole visual a false

Usamos el card, pero pasandole visual a `false`
alexm reviewed 2025-01-27 13:24:38 +00:00
src/pages/Order/Card/OrderCard.vue
@ -4,4 +31,4 @@
</script>
<template>
<VnCardBeta
alexm commented 2025-01-27 13:24:38 +00:00
Author
Member
Copy Link

Ahora el card hace la peticion mas reusable para los modulos

Ahora el card hace la peticion mas reusable para los modulos
alexm reviewed 2025-01-27 13:25:42 +00:00
src/pages/Order/Card/OrderDescriptorProxy.vue
@ -16,0 +16,4 @@
v-if="$props.id"
:id="$props.id"
:summary="OrderSummary"
data-key="orderDescriptor"
alexm commented 2025-01-27 13:25:42 +00:00
Author
Member
Copy Link

hay que cambiar el dataKey cuando es popup. sino si estas en ticket y abres un ticketDescriptor, te usara el mismo arrayData para los dos

hay que cambiar el dataKey cuando es popup. sino si estas en ticket y abres un ticketDescriptor, te usara el mismo arrayData para los dos
alexm reviewed 2025-01-27 13:26:03 +00:00
src/pages/Order/Card/OrderSummary.vue
@ -107,3 +108,3 @@
<span class="link">
{{ dashIfEmpty(entity?.address?.nickname) }}
<CustomerDescriptorProxy :id="entity?.clientFk" />
<OrderDescriptorProxy :id="1" />
alexm commented 2025-01-27 13:26:03 +00:00
Author
Member
Copy Link

Lo he puesto para probar el funcionamiento en modo popup
Habria que quitarlo

Lo he puesto para probar el funcionamiento en modo popup Habria que quitarlo
alexm commented 2025-01-27 13:27:19 +00:00
Author
Member
Copy Link

❗Habria que dejar en el card tambien la parte del orderTotal.
Ahora mismo se usa en 2-3 sitios.

❗Habria que dejar en el card tambien la parte del orderTotal. Ahora mismo se usa en 2-3 sitios.
alexm reviewed 2025-01-27 13:30:08 +00:00
src/components/common/VnCardBeta.vue
@ -66,3 +81,1 @@
<div :class="[useCardSize(), $attrs.class]">
<RouterView :key="route.path" />
</div>
<span v-if="visual">
alexm commented 2025-01-27 13:30:08 +00:00
Author
Member
Copy Link

No me acaba este enfoque, pero he visto y probado que con Vue no se puede acceder a funciones de un componente sin montarlo.
Seria esta opcion o dividir la logica del template...

No me acaba este enfoque, pero he visto y probado que con Vue no se puede acceder a funciones de un componente sin montarlo. Seria esta opcion o dividir la logica del template...
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request has changes conflicting with the target branch.
  • src/components/common/VnCardBeta.vue
  • src/pages/Order/Card/OrderCard.vue
  • src/pages/Order/Card/OrderDescriptor.vue
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1291
No description provided.
Delete Branch "8463-CardDescriptor_useCard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?