verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 102 Releases Wiki Activity

#7411 - addInfoOnVnCheckboxAndVnInput #1295

Merged
jtubau merged 10 commits from 7411-addInfoOnVnCheckboxAndVnInput into dev 2025-02-11 08:50:10 +00:00
Conversation 0 Commits 10 Files Changed 8 +92 -91
jtubau commented 2025-01-28 07:40:06 +00:00
Member
Copy Link
No description provided.
jtubau added 2 commits 2025-01-28 07:40:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f7c93c8416 refactor: refs #7411 remove unnecessary $props prefix
jtubau added 1 commit 2025-01-28 13:17:08 +00:00
jtubau added 1 commit 2025-01-28 13:23:32 +00:00
jtubau added 1 commit 2025-01-28 13:35:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c083eba66c Merge branch 'dev' into 7411-addInfoOnVnCheckboxAndVnInput
jtubau requested review from alexm 2025-01-28 13:35:48 +00:00
alexm changed title from 7411-addInfoOnVnCheckboxAndVnInput to #7411 - addInfoOnVnCheckboxAndVnInput 2025-01-30 13:39:33 +00:00
alexm requested changes 2025-01-30 13:42:01 +00:00
Dismissed
src/components/common/VnCheckbox.vue
@ -0,0 +4,4 @@
const modelValue = defineModel({ type: Boolean, default: false });
const $props = defineProps({
label: {
alexm commented 2025-01-30 13:40:22 +00:00
Member
Copy Link

no poner label

no poner label
alexm marked this conversation as resolved
src/components/common/VnCheckbox.vue Outdated
@ -0,0 +17,4 @@
<template>
<div>
<QCheckbox
alexm commented 2025-01-30 13:41:03 +00:00
Member
Copy Link

Quitar label y poner:


v-bind="$attrs"
v-on="$attrs"

Para que tenga los mismo parametros y emita los mismos eventos

Quitar label y poner: ``` v-bind="$attrs" v-on="$attrs" ``` Para que tenga los mismo parametros y emita los mismos eventos
src/pages/Account/Card/AccountDescriptorMenu.vue Outdated
@ -135,1 +127,3 @@
>
:label="t('account.card.actions.sync.checkbox')"
:info="t('account.card.actions.sync.tooltip')"
color="primary"
alexm commented 2025-01-30 13:41:21 +00:00
Member
Copy Link

Falta parametros

Falta parametros
src/pages/Customer/Card/CustomerFiscalData.vue
@ -118,3 +114,1 @@
</QTooltip>
</QIcon>
</div>
<VnCheckbox
alexm commented 2025-01-30 13:41:38 +00:00
Member
Copy Link

Se ve igual sin el div?

Se ve igual sin el div?
jtubau commented 2025-01-31 07:47:43 +00:00
Author
Member
Copy Link

Si, se ve exactamente igual

Si, se ve exactamente igual
jtubau added 2 commits 2025-01-31 07:51:27 +00:00
jtubau requested review from alexm 2025-01-31 07:53:35 +00:00
alexm added 1 commit 2025-02-07 07:26:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6dd3a7b00d Merge branch 'dev' into 7411-addInfoOnVnCheckboxAndVnInput
alexm requested changes 2025-02-07 07:30:15 +00:00
Dismissed
src/components/common/VnCheckbox.vue
@ -0,0 +14,4 @@
<template>
<div>
<QCheckbox
v-bind="$attrs"
alexm commented 2025-02-07 07:28:26 +00:00
Member
Copy Link

Falta el
v-on="$attrs"

Falta el v-on="$attrs"
src/components/common/VnCheckbox.vue Outdated
@ -0,0 +16,4 @@
<QCheckbox
v-bind="$attrs"
v-model="modelValue"
/>
alexm commented 2025-02-07 07:29:40 +00:00
Member
Copy Link

Acabo de ver que falta esta parte para que tenga los mismo slots:

<template v-for="(_, slotName) in $slots" #[slotName]="slotData" :key="slotName">
            <slot :name="slotName" v-bind="slotData" :key="slotName" />
        </template>
Acabo de ver que falta esta parte para que tenga los mismo slots: ``` <template v-for="(_, slotName) in $slots" #[slotName]="slotData" :key="slotName"> <slot :name="slotName" v-bind="slotData" :key="slotName" /> </template> ```
alexm marked this conversation as resolved
jtubau added 1 commit 2025-02-10 08:42:37 +00:00
jtubau requested review from alexm 2025-02-10 08:43:56 +00:00
alexm added 1 commit 2025-02-11 08:38:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c975943eb1 Merge branch 'dev' into 7411-addInfoOnVnCheckboxAndVnInput
alexm approved these changes 2025-02-11 08:40:40 +00:00
jtubau merged commit 54585691c3 into dev 2025-02-11 08:50:10 +00:00
jtubau deleted branch 7411-addInfoOnVnCheckboxAndVnInput 2025-02-11 08:50:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1295
No description provided.
Delete Branch "7411-addInfoOnVnCheckboxAndVnInput"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?