verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 97 Releases Wiki Activity

#7411 - addInfoOnVnCheckboxAndVnInput #1295

Merged
jtubau merged 10 commits from 7411-addInfoOnVnCheckboxAndVnInput into dev 2025-02-11 08:50:10 +00:00
Conversation 0 Commits 10 Files Changed 8 +3 -13
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2e0575052c - Show all commits

16
src/components/common/VnCheckbox.vue
View File

@ -1,13 +1,9 @@
<script setup> <script setup>
import { computed } from 'vue'; import { defineModel } from 'vue';
const emit = defineEmits(['update:modelValue']); const modelValue = defineModel({ type: Boolean, default: false });
const $props = defineProps({ const $props = defineProps({
modelValue: {
type: [Boolean],
default: null,
},
label: { label: {
alexm marked this conversation as resolved
alexm commented 2025-01-30 13:40:22 +00:00
Review
Copy Link

no poner label

no poner label
type: String, type: String,
default: null, default: null,
@ -17,19 +13,13 @@ const $props = defineProps({
default: null, default: null,
}, },
}); });
const isChecked = computed({
get: () => $props.modelValue,
set: (value) => emit('update:modelValue', value),
});
</script> </script>
alexm commented 2025-02-07 07:28:26 +00:00
Review
Copy Link

Falta el
v-on="$attrs"

Falta el v-on="$attrs"
<template> <template>
<div> <div>
alexm marked this conversation as resolved Outdated
alexm commented 2025-02-07 07:29:40 +00:00
Outdated
Review
Copy Link

Acabo de ver que falta esta parte para que tenga los mismo slots:

<template v-for="(_, slotName) in $slots" #[slotName]="slotData" :key="slotName">
            <slot :name="slotName" v-bind="slotData" :key="slotName" />
        </template>
Acabo de ver que falta esta parte para que tenga los mismo slots: ``` <template v-for="(_, slotName) in $slots" #[slotName]="slotData" :key="slotName"> <slot :name="slotName" v-bind="slotData" :key="slotName" /> </template> ```
<QCheckbox <QCheckbox
alexm commented 2025-01-30 13:41:03 +00:00
Outdated
Review
Copy Link

Quitar label y poner:


v-bind="$attrs"
v-on="$attrs"

Para que tenga los mismo parametros y emita los mismos eventos

Quitar label y poner: ``` v-bind="$attrs" v-on="$attrs" ``` Para que tenga los mismo parametros y emita los mismos eventos
:label="label" :label="label"
v-model="isChecked" v-model="modelValue"
/> />
<QIcon v-if="info" class="cursor-info q-ml-sm" name="info" size="sm" v-bind="$attrs"> <QIcon v-if="info" class="cursor-info q-ml-sm" name="info" size="sm" v-bind="$attrs">
<QTooltip> <QTooltip>