verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 71 Releases Wiki Activity

fix: refs #8418 adjusted route for button click #1305

Merged
jtubau merged 9 commits from 8418-fixTestMyEntry into dev 2025-02-04 06:01:45 +00:00
Conversation 0 Commits 9 Files Changed 3 +6 -5
jtubau commented 2025-01-29 07:36:04 +00:00
Member
Copy Link
No description provided.
jtubau added 1 commit 2025-01-29 07:36:05 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
5c280867e2 fix: refs #8418 adjusted route for button click
jtubau added 1 commit 2025-01-29 07:36:15 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
990ed74fef Merge branch 'dev' into 8418-fixTestMyEntry
jtubau added 2 commits 2025-01-29 07:49:46 +00:00
jtubau requested review from jsegarra 2025-01-29 07:51:16 +00:00
jsegarra requested changes 2025-01-29 08:01:33 +00:00
Dismissed
test/cypress/integration/entry/myEntry.spec.js Outdated
@ -14,3 +14,3 @@
'[to="/null/3"] > .q-card > .column > .q-btn > .q-btn__content > .q-icon'
).click();
cy.get('.q-card__actions > .q-btn').click();
cy.get('.q-card__section > .q-infinite-scroll > .q-table__container > .q-table__top > :nth-child(3) > .q-btn > .q-btn__content > .q-icon').click();
jsegarra commented 2025-01-29 08:00:40 +00:00
Member
Copy Link

Este es el botón de imprimir ?

Este es el botón de imprimir ?
jsegarra commented 2025-01-29 08:01:05 +00:00
Member
Copy Link

Evitamos hacer esto si existe la posibilidad de usar dataCy

Evitamos hacer esto si existe la posibilidad de usar dataCy
jtubau commented 2025-01-29 10:39:11 +00:00
Author
Member
Copy Link

Cierto, me lo comentaste, ahora lo cambio

Cierto, me lo comentaste, ahora lo cambio
jsegarra commented 2025-01-29 22:06:03 +00:00
Member
Copy Link

bien
pero escribir cada vez cy.get(data-cy) es redundante, y si cambiamos un dia data-cy por data-loquesea?

bien pero escribir cada vez cy.get(data-cy) es redundante, y si cambiamos un dia data-cy por data-loquesea?
jsegarra marked this conversation as resolved
jtubau added 1 commit 2025-01-29 10:48:46 +00:00
jtubau requested review from jsegarra 2025-01-29 10:49:07 +00:00
jsegarra requested changes 2025-01-29 22:06:36 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

revisar el archivo de comandos a ver si hay alguno que sirva para reemplazar cy.get

revisar el archivo de comandos a ver si hay alguno que sirva para reemplazar cy.get
jtubau added 1 commit 2025-01-31 08:36:43 +00:00
jtubau requested review from jsegarra 2025-01-31 08:40:18 +00:00
jsegarra requested changes 2025-01-31 09:28:22 +00:00
Dismissed
src/pages/Entry/EntryBuysTableDialog.vue Outdated
@ -134,6 +134,7 @@ function downloadCSV(rows) {
@click="
openReport(`Entries/${entityId}/labelSupplier`)
"
data-cy="entryBuysTableDialog_printLabelsBtn"
jsegarra commented 2025-01-31 09:28:19 +00:00
Member
Copy Link

printLabelsBtn o printLabels_button

printLabelsBtn o printLabels_button
jsegarra marked this conversation as resolved
jtubau added 1 commit 2025-02-03 12:14:19 +00:00
jtubau added 1 commit 2025-02-03 12:14:41 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5b4fdcc443 Merge branch 'dev' into 8418-fixTestMyEntry
jtubau added 1 commit 2025-02-03 12:19:28 +00:00
jtubau requested review from jsegarra 2025-02-03 12:20:26 +00:00
jsegarra approved these changes 2025-02-03 22:27:01 +00:00
jtubau merged commit ff28df13f8 into dev 2025-02-04 06:01:45 +00:00
jtubau deleted branch 8418-fixTestMyEntry 2025-02-04 06:01:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1305
No description provided.
Delete Branch "8418-fixTestMyEntry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?