verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 92 Releases Wiki Activity

#8372 prevent double submit #1333

Merged
alexm merged 29 commits from 8372-fixDoubleRequest into dev 2025-02-13 12:40:17 +00:00
Conversation 1 Commits 29 Files Changed 6 +21 -18
jorgep commented 2025-02-05 11:56:13 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2025-02-05 11:56:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
e597552dc3 fix: refs #8372 remove trailing commas in various files
jorgep reviewed 2025-02-05 11:56:35 +00:00
jorgep reviewed 2025-02-05 11:56:43 +00:00
jorgep added 1 commit 2025-02-05 11:59:26 +00:00
jorgep added 2 commits 2025-02-05 15:34:21 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
b1d6f9dd9c fix: refs #8372 rollback
jorgep added 1 commit 2025-02-06 08:46:36 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
d047a9deea fix: refs #8372 allow form submission without prevention
jorgep added 1 commit 2025-02-06 08:47:17 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
60d96c8030 feat: refs #8372 add prevent-submit attribute
jorgep changed title from #8372 remove trailing commas in various files to #8372 prevent double submit 2025-02-06 09:51:32 +00:00
jorgep added 1 commit 2025-02-06 12:44:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
16805afc88 fix: refs #8372 front test
jorgep added 1 commit 2025-02-06 12:45:23 +00:00
jorgep added 1 commit 2025-02-06 14:47:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f51e8b2e4d fix: refs #8372 e2e tests
jorgep added the
CR / Tests passed
 label 2025-02-06 14:54:20 +00:00
jorgep requested review from alexm 2025-02-06 14:54:23 +00:00
alexm requested changes 2025-02-07 06:02:50 +00:00
Dismissed
src/components/FormModel.vue Outdated
@ -208,3 +208,3 @@
}
async function save() {
async function save({ prevent = true }) {
alexm commented 2025-02-07 06:02:48 +00:00
Member
Copy Link

duda, pq no poner save(prevent = true) y ya no hace falta pasar el true, solo los false?

duda, pq no poner `save(prevent = true)` y ya no hace falta pasar el true, solo los false?
jorgep commented 2025-02-07 08:57:44 +00:00
Author
Member
Copy Link

Lo probé, no funciona. Si se hace enter en un input normal, primero se dispara el evt @submit y luego entre en qFormMixin > evt keyup. El evt @submit de quasar siempre pasa como primer argumento la propiedad. Probé a ver si podía ponerle un .prevent para que no se disparé desde formModel pero así no funcionaba.

Lo probé, no funciona. Si se hace enter en un input normal, primero se dispara el evt @submit y luego entre en qFormMixin > evt keyup. El evt @submit de quasar siempre pasa como primer argumento la propiedad. Probé a ver si podía ponerle un **.prevent** para que no se disparé desde formModel pero así no funcionaba.
jorgep commented 2025-02-07 15:49:17 +00:00
Author
Member
Copy Link

Ahora creo va finito

Ahora creo va finito
jorgep marked this conversation as resolved
jorgep requested review from alexm 2025-02-07 08:57:49 +00:00
jorgep added 1 commit 2025-02-07 09:06:51 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
bf160dc1b0 Merge branch 'dev' into 8372-fixDoubleRequest
alexm requested changes 2025-02-07 11:43:33 +00:00
Dismissed
alexm left a comment
Member
Copy Link

No usar objeto y la opcion por defecto false

No usar objeto y la opcion por defecto false
jorgep added 2 commits 2025-02-07 15:20:40 +00:00
jorgep commented 2025-02-07 15:23:49 +00:00
Author
Member
Copy Link

No usar objeto y la opcion por defecto false

Lo he probado, si hago lo que hemos hablado cuando formMixin llama a onSubmit este dispara @submit entonces hace save().

> No usar objeto y la opcion por defecto false Lo he probado, si hago lo que hemos hablado cuando formMixin llama a onSubmit este dispara @submit entonces hace save().
jorgep added 1 commit 2025-02-07 15:32:56 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
2aabef2e11 fix: refs #8372 simplify save method calls by removing prevent option
jorgep added 1 commit 2025-02-07 15:40:23 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
c2facd5f99 fix: refs #8372 remove prevent option from save method calls in form components
jorgep added 1 commit 2025-02-07 15:48:31 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
e1605e0610 fix: refs #8372 update save method to default prevent option to false
jorgep added 1 commit 2025-02-07 16:19:03 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
9a946c0f39 fix: refs #8372 update save method calls in FormModel tests to use prevent option directly
jorgep added 1 commit 2025-02-07 16:21:34 +00:00
jorgep requested review from alexm 2025-02-09 06:46:37 +00:00
jorgep added 1 commit 2025-02-09 07:39:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c3fb92e26d fix: refs #8372 row selection for editing
alexm requested changes 2025-02-10 06:16:18 +00:00
Dismissed
src/components/__tests__/FormModel.spec.js Outdated
@ -88,3 +89,3 @@
const { vm } = mount({ propsData: { url, model } });
await vm.save();
await vm.save(prevent);
alexm commented 2025-02-10 06:16:15 +00:00
Member
Copy Link

Si false es el por defecto, no hace falta pasar false

Si false es el por defecto, no hace falta pasar false
jorgep marked this conversation as resolved
jorgep added 1 commit 2025-02-11 08:30:03 +00:00
jorgep added 1 commit 2025-02-11 08:31:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
115b60751a chore: refs #8372 remove unnecessary param
jorgep requested review from alexm 2025-02-11 08:31:38 +00:00
alexm approved these changes 2025-02-12 06:40:29 +00:00
Dismissed
jorgep added 1 commit 2025-02-12 09:12:11 +00:00
jorgep dismissed alexm’s review 2025-02-12 09:12:11 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep requested review from alexm 2025-02-12 09:12:40 +00:00
jorgep added 1 commit 2025-02-12 09:17:10 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
cc2d1ed09d fix: refs #8372 correct comment syntax in routeList.spec.js
jorgep added 1 commit 2025-02-12 09:34:06 +00:00
jorgep added 1 commit 2025-02-12 09:36:43 +00:00
jorgep added 1 commit 2025-02-12 09:37:46 +00:00
alexm approved these changes 2025-02-13 06:30:48 +00:00
Dismissed
alexm added 1 commit 2025-02-13 06:30:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
9ffafa7514 Merge branch 'dev' into 8372-fixDoubleRequest
jorgep added 2 commits 2025-02-13 11:32:29 +00:00
jorgep dismissed alexm’s review 2025-02-13 11:32:29 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep requested review from alexm 2025-02-13 11:34:14 +00:00
alexm approved these changes 2025-02-13 12:38:36 +00:00
alexm added 1 commit 2025-02-13 12:38:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
88e3bfa2b8 Merge branch 'dev' into 8372-fixDoubleRequest
alexm merged commit 6f2790f6f8 into dev 2025-02-13 12:40:17 +00:00
alexm deleted branch 8372-fixDoubleRequest 2025-02-13 12:40:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1333
No description provided.
Delete Branch "8372-fixDoubleRequest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?