Fix[InvoiceInBasicData]: fixed basic data e2e #1361

Merged
jon merged 6 commits from Fix-InvoiceInBasicDataE2E into dev 2025-02-11 07:14:50 +00:00
Member
No description provided.
jon added 1 commit 2025-02-10 09:22:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8c499e3fc3
fix: fixed basic data e2e
jon requested review from jsegarra 2025-02-10 09:40:22 +00:00
jsegarra requested changes 2025-02-10 10:24:21 +00:00
Dismissed
@ -3,3 +3,2 @@
const formInputs = '.q-form > .q-card input';
const firstFormSelect = '.q-card > .vn-row:nth-child(1) > .q-select';
const documentBtns = '[data-cy="dms-buttons"] button';
const documentBtns = '[data-cy="dms-buttons"]';
Member

le sigue un child, correcto?
Porque no lo haces función?

le sigue un child, correcto? Porque no lo haces función?
jon marked this conversation as resolved
@ -12,3 +11,3 @@
it('should edit the provideer and supplier ref', () => {
cy.selectOption(firstFormSelect, 'Bros');
cy.selectOption('[data-cy="Undeductible VAT_select"]', '4751000000')
Member

podemos hacer el evitar este selectOption? en favor de una "funcion/logica" manual?

podemos hacer el evitar este selectOption? en favor de una "funcion/logica" manual?
jon marked this conversation as resolved
jsegarra reviewed 2025-02-10 10:24:57 +00:00
@ -29,3 +25,4 @@
cy.get(`${documentBtns} > :nth-child(2)`).click();
cy.get(dialogInputs).eq(0).type(`{selectall}${firtsInput}`);
cy.get('textarea').type(`{selectall}${secondInput}`);
cy.get('[data-cy="FormModelPopup_save"]').click();
Member

Lo pongo como comentario, pero ya que estamos, podemos quitar el cy.get(data-cy) y usar cy.dataCy

Lo pongo como comentario, pero ya que estamos, podemos quitar el cy.get(data-cy) y usar cy.dataCy
jon marked this conversation as resolved
jon added 1 commit 2025-02-10 11:44:42 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
aa6c6f0e69
refactor: requested changes
jon requested review from jsegarra 2025-02-10 11:46:16 +00:00
jon added 1 commit 2025-02-10 11:46:23 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a3c3a60e98
Merge branch 'dev' into Fix-InvoiceInBasicDataE2E
jon added 2 commits 2025-02-10 12:19:08 +00:00
jsegarra approved these changes 2025-02-10 15:23:41 +00:00
jon added 1 commit 2025-02-11 06:49:58 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
94f1b2d709
Merge branch 'dev' into Fix-InvoiceInBasicDataE2E
jon merged commit f6c5891e0b into dev 2025-02-11 07:14:50 +00:00
jon deleted branch Fix-InvoiceInBasicDataE2E 2025-02-11 07:14:54 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1361
No description provided.