WIP: feat: refs #8440 add VehicleNotes component and update routing #1364

Draft
jtubau wants to merge 4 commits from 8440-createVehicleNotes into dev
Member
PR BACK: https://gitea.verdnatura.es/verdnatura/salix/pulls/3430
jtubau added 1 commit 2025-02-10 12:42:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
51afa21fa4
feat: refs #8440 add VehicleNotes component and update routing
jtubau added 1 commit 2025-02-10 12:44:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b229fc0ff3
Merge branch 'dev' into 8440-createVehicleNotes
jtubau requested review from jorgep 2025-02-11 10:07:57 +00:00
Member

Asignamela otra vez, después de hablar con Javi y realizar los cambios que acordéis

Asignamela otra vez, después de hablar con Javi y realizar los cambios que acordéis
jorgep refused to review 2025-02-12 10:15:29 +00:00
jtubau added 1 commit 2025-02-12 13:40:29 +00:00
jtubau added 1 commit 2025-02-12 13:52:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3de0ebeccd
refactor: refs #8440 remove unnecessary computed properties
jtubau requested review from jorgep 2025-02-12 13:57:05 +00:00
jtubau changed title from feat: refs #8440 add VehicleNotes component and update routing to WIP: feat: refs #8440 add VehicleNotes component and update routing 2025-02-13 15:03:53 +00:00
jorgep reviewed 2025-02-14 17:17:00 +00:00
@ -144,3 +150,3 @@
option-label="description"
style="flex: 0.15"
:required="isRequired"
:required="Object.keys($attrs).includes('required')"
Member

copilot dice: 'required' in $attrs

copilot dice: ```'required' in $attrs```
jorgep reviewed 2025-02-14 17:17:42 +00:00
@ -155,3 +160,3 @@
autogrow
@keyup.enter.stop="handleClick"
:required="isRequired"
:required="Object.keys($attrs).includes('required')"
Member

Lo mismo de arriba

Lo mismo de arriba
jorgep reviewed 2025-02-14 17:18:05 +00:00
@ -226,1 +231,4 @@
<span v-text="toDateHourMin(note.created)" />
<div>
<QIcon
v-if="Object.keys($attrs).includes('deletable')"
Member

Lo mismo de arriba.

Lo mismo de arriba.
jorgep reviewed 2025-02-14 17:19:25 +00:00
@ -0,0 +7,4 @@
const route = useRoute();
const state = useState();
const user = state.getUser();
const vehicleId = computed(() => route.params.id);
Member

Verificar si realmente hace falta o se puede poner directamente route.params.id en noteFilter,

Verificar si realmente hace falta o se puede poner directamente route.params.id en noteFilter,
jorgep requested changes 2025-02-14 17:20:55 +00:00
jorgep left a comment
Member

Faltan e2e

Faltan e2e
jorgep reviewed 2025-02-14 17:21:23 +00:00
@ -52,6 +48,11 @@ function handleClick(e) {
else insert();
}
async function deleteNote(e) {
Member

test de front

test de front
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1364
No description provided.