#8277 createEntryControl #1370

Merged
jorgep merged 77 commits from 8277-createEntryControl into dev 2025-04-17 16:45:31 +00:00
Member
No description provided.
jorgep added 2 commits 2025-02-11 08:37:10 +00:00
jorgep added 1 commit 2025-02-11 13:19:43 +00:00
jorgep added 2 commits 2025-02-12 09:08:00 +00:00
jorgep added 1 commit 2025-02-12 13:31:42 +00:00
jorgep added 1 commit 2025-02-12 17:25:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
1facb04d7a
feat: refs #8277 update EntryControl component with new column definitions and filters
jorgep added 1 commit 2025-02-13 12:16:30 +00:00
jorgep added 1 commit 2025-03-18 13:26:49 +00:00
jorgep added 1 commit 2025-03-20 07:57:20 +00:00
jorgep added 1 commit 2025-03-20 07:57:52 +00:00
jorgep added 1 commit 2025-03-20 17:05:22 +00:00
jorgep added 1 commit 2025-03-21 07:51:56 +00:00
jorgep added 1 commit 2025-03-21 08:04:43 +00:00
jorgep added 1 commit 2025-03-21 09:15:20 +00:00
jorgep added 1 commit 2025-03-21 11:25:19 +00:00
jorgep added 1 commit 2025-03-24 13:40:19 +00:00
jorgep added 1 commit 2025-03-24 14:24:45 +00:00
jorgep added 1 commit 2025-03-24 14:48:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
41c2c56013
chore: refs #8277 notes
jorgep added 1 commit 2025-03-24 15:27:43 +00:00
jorgep added 1 commit 2025-03-25 08:36:06 +00:00
jorgep added 1 commit 2025-03-25 08:41:01 +00:00
jorgep added 1 commit 2025-03-25 15:19:22 +00:00
jorgep added 1 commit 2025-03-25 15:19:39 +00:00
jorgep added 1 commit 2025-03-25 16:28:18 +00:00
jorgep added 1 commit 2025-03-26 15:14:05 +00:00
jorgep added 1 commit 2025-03-27 13:48:14 +00:00
jorgep added 1 commit 2025-03-27 13:49:58 +00:00
jorgep added 2 commits 2025-03-28 08:49:53 +00:00
jorgep added 1 commit 2025-03-28 11:14:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
61a9676c32
feat: refs #8277 changes
jorgep added 1 commit 2025-03-31 14:46:01 +00:00
jorgep added 1 commit 2025-04-01 07:18:38 +00:00
jorgep added 1 commit 2025-04-01 07:29:05 +00:00
jorgep added 1 commit 2025-04-01 14:31:18 +00:00
jorgep added 1 commit 2025-04-01 15:45:00 +00:00
jorgep added 1 commit 2025-04-01 16:04:21 +00:00
jorgep added 1 commit 2025-04-02 07:35:38 +00:00
jorgep added 1 commit 2025-04-02 14:26:10 +00:00
jorgep added 1 commit 2025-04-03 08:34:15 +00:00
jorgep added 1 commit 2025-04-03 16:09:31 +00:00
jorgep added 1 commit 2025-04-04 10:00:37 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
a1f93a87b2
refactor: refs #8277 rename entry control to pre-account in localization and routing
jorgep added 1 commit 2025-04-04 10:55:07 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
cd7f9e15fc
refactor: refs #8277 rename dmsType to dmsTypeFk in EntryPreAccount.vue
jorgep added 1 commit 2025-04-04 15:14:48 +00:00
jorgep added 1 commit 2025-04-07 10:07:58 +00:00
jorgep added 1 commit 2025-04-07 10:49:29 +00:00
jorgep added 1 commit 2025-04-07 14:18:35 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
e127c4cec9
fix: refs #8277 improve tests
jorgep added 1 commit 2025-04-07 14:55:20 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
e8af2b6a74
test: refs #8277 add unit tests for EntryPreAccount component
jorgep added 1 commit 2025-04-07 15:15:57 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
966f52d3e3
chore: refs #8277 replace end-point name
jorgep added 1 commit 2025-04-08 08:42:58 +00:00
jorgep added 1 commit 2025-04-08 09:01:42 +00:00
jorgep added 1 commit 2025-04-08 16:00:43 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
35b09c829e
fix(EntryPreAccount): refs #8277 remove unused save-url property from table component
jorgep added 1 commit 2025-04-09 09:26:43 +00:00
jorgep added 1 commit 2025-04-10 09:33:24 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
a0e3aab4e0
feat(EntryPreAccount): refs #8277 add company color badge to invoice entry table
jorgep added 1 commit 2025-04-10 09:34:16 +00:00
jorgep added 1 commit 2025-04-11 08:54:57 +00:00
jorgep added 1 commit 2025-04-11 14:30:36 +00:00
jorgep added 1 commit 2025-04-11 15:17:07 +00:00
jorgep added 1 commit 2025-04-14 08:48:15 +00:00
jorgep added 1 commit 2025-04-14 10:04:18 +00:00
jorgep added 1 commit 2025-04-14 13:07:15 +00:00
jorgep added 1 commit 2025-04-14 15:02:44 +00:00
jorgep reviewed 2025-04-14 15:07:01 +00:00
@ -375,3 +375,3 @@
<template #append>
<QIcon
v-show="isClearable && value"
v-show="isClearable && value != null && value !== ''"
Author
Member

Así admite valor 0 también, valor que se comprueba en el tipo de cuenta.

Así admite valor 0 también, valor que se comprueba en el tipo de cuenta.
jorgep marked this conversation as resolved
jorgep changed title from WIP: #8277 createEntryControl to #8277 createEntryControl 2025-04-14 15:07:43 +00:00
jorgep requested review from jgallego 2025-04-14 15:07:51 +00:00
jorgep added 1 commit 2025-04-14 15:08:14 +00:00
jgallego requested changes 2025-04-15 05:29:47 +00:00
Dismissed
@ -0,0 +237,4 @@
if (!dmsFk && entries[i].gestDocFk) dmsFk = entries[i].gestDocFk;
if (!nextEntry) break;
else if (nextEntry.supplierFk !== supplierFk || nextEntry.companyFk !== companyFk)
return notify('Entries must have the same supplier and company', 'negative');
Owner

Esta seria mas correcta tenerla en el back.

Esta seria mas correcta tenerla en el back.
jorgep marked this conversation as resolved
jorgep added 1 commit 2025-04-15 12:43:42 +00:00
jorgep reviewed 2025-04-15 13:57:47 +00:00
@ -0,0 +234,4 @@
const { supplierFk, companyFk } = entries[i];
const nextEntry = entries[+i + 1];
if (!dmsFk && entries[i].gestDocFk) dmsFk = entries[i].gestDocFk;
Author
Member

Cambiar para que de fallo si hay mas de un dms diferente.

Cambiar para que de fallo si hay mas de un dms diferente.
jorgep marked this conversation as resolved
jorgep added 1 commit 2025-04-15 14:30:22 +00:00
jorgep added 1 commit 2025-04-15 16:50:16 +00:00
jorgep added 1 commit 2025-04-16 07:47:36 +00:00
jorgep requested review from jgallego 2025-04-16 08:03:20 +00:00
jgallego requested changes 2025-04-16 10:53:09 +00:00
Dismissed
@ -0,0 +28,4 @@
const updateDialog = ref();
const uploadDialog = ref();
const MAXDAYS = 365;
const DEFAULTDAYS = 60;
Owner

estos dos valores muevelos a entryConfig

estos dos valores muevelos a entryConfig
jorgep marked this conversation as resolved
@ -0,0 +442,4 @@
v-close-popup
/>
<QBtn
data-cy="updateFile_no"
Owner

no solemos usar _ no? porque no pones updateFileNo ?

no solemos usar _ no? porque no pones updateFileNo ?
Author
Member

Depende de quien lo haga. En una de las reuniones creí haber entendido que íbamos a seguir este convenio. Lo cambio a camelCase

Depende de quien lo haga. En una de las reuniones creí haber entendido que íbamos a seguir este convenio. Lo cambio a camelCase
jorgep marked this conversation as resolved
jorgep added 1 commit 2025-04-16 13:45:21 +00:00
jorgep added 1 commit 2025-04-16 15:54:08 +00:00
jorgep added 1 commit 2025-04-16 16:30:09 +00:00
jorgep requested review from jgallego 2025-04-16 16:33:04 +00:00
jgallego approved these changes 2025-04-17 04:43:59 +00:00
Dismissed
jgallego left a comment
Owner

@jorgep mira el comentario

@jorgep mira el comentario
@ -0,0 +247,4 @@
} else if (dmsFk) {
supplierRef = (
await axios.get(`Dms/${dmsFk}`, {
params: { filter: JSON.stringify({ fields: { reference: true } }) },
Owner

reference: true que hace, porque es un campo varchar?
prueba poniendo ZZ202111/0012 (caso real) a ver si funciona

reference: true que hace, porque es un campo varchar? prueba poniendo ZZ202111/0012 (caso real) a ver si funciona
Author
Member

Es otra forma de hacer fields: ['reference'], como veo que es confusa la cambio.

Link de referencia: https://loopback.io/doc/en/lb3/Fields-filter.html

Es otra forma de hacer **fields: ['reference']**, como veo que es confusa la cambio. Link de referencia: https://loopback.io/doc/en/lb3/Fields-filter.html
jorgep added 1 commit 2025-04-17 08:30:53 +00:00
jorgep dismissed jgallego’s review 2025-04-17 08:30:54 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep added 1 commit 2025-04-17 08:34:11 +00:00
jorgep added 1 commit 2025-04-17 08:49:43 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
7e04a794cb
chore: refs #8277 rename received
jorgep added 2 commits 2025-04-17 13:53:30 +00:00
jorgep added 1 commit 2025-04-17 14:27:15 +00:00
Author
Member

@jgallego ya se puede revisar otra vez.

@jgallego ya se puede revisar otra vez.
jgallego approved these changes 2025-04-17 14:51:35 +00:00
Dismissed
jorgep scheduled this pull request to auto merge when all checks succeed 2025-04-17 15:30:22 +00:00
jorgep added 1 commit 2025-04-17 16:10:51 +00:00
jorgep dismissed jgallego’s review 2025-04-17 16:10:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep requested review from jgallego 2025-04-17 16:11:17 +00:00
jorgep reviewed 2025-04-17 16:12:33 +00:00
@ -7,3 +7,3 @@
it('should modify the tax for Spain', () => {
cy.dataCy('Class_select').eq(1).type('General VAT{enter}');
cy.dataCy('Class_select').eq(1).type('IVA General{enter}');
Author
Member

Los campos de la tabla taxClass me pidió Carlos Andrés que los copiara de producción.

Los campos de la tabla taxClass me pidió Carlos Andrés que los copiara de producción.
jgallego approved these changes 2025-04-17 16:13:30 +00:00
jorgep merged commit 508cf2f684 into dev 2025-04-17 16:45:31 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1370
No description provided.