fix: refs #8616 update binding syntax for is-editable prop in AgencyList.vue #1446

Merged
jtubau merged 19 commits from 8616-fixWarningsRouteSection into dev 2025-03-12 08:11:59 +00:00
Member
No description provided.
jtubau added 1 commit 2025-02-19 14:24:20 +00:00
jtubau changed title from fix: refs #8616 update binding syntax for is-editable prop in AgencyList.vue to WIP: fix: refs #8616 update binding syntax for is-editable prop in AgencyList.vue 2025-02-19 14:24:22 +00:00
jtubau added 1 commit 2025-02-20 07:53:46 +00:00
jtubau added 1 commit 2025-02-20 08:08:58 +00:00
jtubau added 1 commit 2025-02-20 09:00:37 +00:00
jtubau added 1 commit 2025-02-27 08:59:40 +00:00
jtubau added 1 commit 2025-02-27 09:03:22 +00:00
jtubau added 1 commit 2025-02-27 09:13:24 +00:00
jtubau added 1 commit 2025-02-27 09:18:57 +00:00
jtubau added 1 commit 2025-02-27 09:47:30 +00:00
jtubau added 1 commit 2025-02-28 10:35:51 +00:00
jtubau changed title from WIP: fix: refs #8616 update binding syntax for is-editable prop in AgencyList.vue to fix: refs #8616 update binding syntax for is-editable prop in AgencyList.vue 2025-02-28 10:36:06 +00:00
jtubau requested review from pablone 2025-02-28 10:36:47 +00:00
pablone added 1 commit 2025-03-03 06:37:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
485ef71f4a
Merge branch 'dev' into 8616-fixWarningsRouteSection
pablone requested changes 2025-03-03 06:53:11 +00:00
Dismissed
pablone left a comment
Member

Revisa los comentarios que te he puesto

Revisa los comentarios que te he puesto
@ -130,3 +130,3 @@
<template>
<div class="descriptor">
<div class="descriptor" v-bind="$attrs">
Member

Esto puede generar Warnings, has revisado si los provoca? https://chat.verdnatura.es/group/salix?msg=qRSHxFixkxpGHCu7P

Esto puede generar Warnings, has revisado si los provoca? https://chat.verdnatura.es/group/salix?msg=qRSHxFixkxpGHCu7P
Author
Member

No los provoca pero he solucionado de donde venia el warning y ya le he quitado el v-bind

No los provoca pero he solucionado de donde venia el warning y ya le he quitado el v-bind
jtubau marked this conversation as resolved
@ -33,6 +33,10 @@ const props = defineProps({
type: String,
default: '',
},
userFilter: {
Member

no se utiliza la prop, es por warnings?

no se utiliza la prop, es por warnings?
Author
Member

Si

Si
jtubau marked this conversation as resolved
@ -30,0 +34,4 @@
:url="`Roadmaps/${entityId}`"
:filter="filter"
data-key="Roadmap"
:summary="$props.summary"
Member

no hace falta utilizar "$props." en la template

no hace falta utilizar "$props." en la template
jtubau marked this conversation as resolved
@ -19,3 +17,1 @@
dms: `#/vehicle/${entityId.value}/dms`,
'invoice-in': `#/vehicle/${entityId.value}/invoice-in`,
events: `#/vehicle/${entityId.value}/events`,
'basic-data': `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/basic-data`,
Member

Crea una constante const baseLink = #/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}; para no repetir código

Crea una constante const baseLink = `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}`; para no repetir código
jtubau marked this conversation as resolved
jtubau added 1 commit 2025-03-03 09:44:13 +00:00
jtubau added 1 commit 2025-03-03 09:47:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
50feb0edcc
Merge branch 'dev' into 8616-fixWarningsRouteSection
jtubau requested review from pablone 2025-03-03 09:48:03 +00:00
pablone requested changes 2025-03-04 10:49:11 +00:00
Dismissed
pablone left a comment
Member

te fallan los test

te fallan los test
jtubau added 1 commit 2025-03-04 18:32:11 +00:00
alexm added 1 commit 2025-03-07 11:20:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
3098d24184
Merge branch 'dev' into 8616-fixWarningsRouteSection
jtubau requested review from pablone 2025-03-10 12:47:06 +00:00
pablone added 1 commit 2025-03-11 08:13:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
c2a29e4a9d
Merge branch 'dev' into 8616-fixWarningsRouteSection
pablone added 1 commit 2025-03-11 12:26:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
230bd17ed5
Merge branch 'dev' into 8616-fixWarningsRouteSection
pablone approved these changes 2025-03-11 13:40:52 +00:00
Dismissed
jtubau added 1 commit 2025-03-11 14:15:12 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d5784630a3
Merge branch 'dev' into 8616-fixWarningsRouteSection
jtubau scheduled this pull request to auto merge when all checks succeed 2025-03-11 14:15:19 +00:00
jtubau added 1 commit 2025-03-12 07:24:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a3dfd2cb4b
Merge branch 'dev' into 8616-fixWarningsRouteSection
jtubau dismissed pablone’s review 2025-03-12 07:24:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pablone approved these changes 2025-03-12 08:11:24 +00:00
jtubau merged commit 29a55987fe into dev 2025-03-12 08:11:59 +00:00
jtubau deleted branch 8616-fixWarningsRouteSection 2025-03-12 08:12:00 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1446
No description provided.