verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 81 Releases Wiki Activity

fix: refs #8616 update binding syntax for is-editable prop in AgencyList.vue #1446

Merged
jtubau merged 19 commits from 8616-fixWarningsRouteSection into dev 2025-03-12 08:11:59 +00:00
Conversation 0 Commits 19 Files Changed 15 +8 -9
5 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9e36ddfd8f - Show all commits

2
src/components/ui/CardDescriptor.vue
View File

@ -129,7 +129,7 @@ const toModule = computed(() =>
</script>
<template>
<div class="descriptor" v-bind="$attrs">
<div class="descriptor">
jtubau marked this conversation as resolved Outdated
pablone commented 2025-03-03 06:38:35 +00:00
Outdated
Review
Copy Link

Esto puede generar Warnings, has revisado si los provoca? https://chat.verdnatura.es/group/salix?msg=qRSHxFixkxpGHCu7P

Esto puede generar Warnings, has revisado si los provoca? https://chat.verdnatura.es/group/salix?msg=qRSHxFixkxpGHCu7P
jtubau commented 2025-03-03 09:45:16 +00:00
Outdated
Review
Copy Link

No los provoca pero he solucionado de donde venia el warning y ya le he quitado el v-bind

No los provoca pero he solucionado de donde venia el warning y ya le he quitado el v-bind
<template v-if="entity && !isLoading">
<div class="header bg-primary q-pa-sm justify-between">
<slot name="header-extra-action"

2
src/pages/Route/Roadmap/RoadmapDescriptor.vue
View File

@ -34,7 +34,7 @@ const entityId = computed(() => {
:url="`Roadmaps/${entityId}`"
:filter="filter"
data-key="Roadmap"
:summary="$props.summary"
:summary="summary"
jtubau marked this conversation as resolved Outdated
pablone commented 2025-03-03 06:48:30 +00:00
Outdated
Review
Copy Link

no hace falta utilizar "$props." en la template

no hace falta utilizar "$props." en la template
>
<template #body="{ entity }">
<VnLv :label="t('Roadmap')" :value="entity?.name" />

1
src/pages/Route/RouteRoadmap.vue
View File

@ -8,7 +8,6 @@ import { useSummaryDialog } from 'composables/useSummaryDialog';
import toCurrency from 'filters/toCurrency';
import axios from 'axios';
import VnSearchbar from 'components/ui/VnSearchbar.vue';
import VnSubToolbar from 'src/components/ui/VnSubToolbar.vue';
import VnTable from 'components/VnTable/VnTable.vue';
import RoadmapSummary from 'pages/Route/Roadmap/RoadmapSummary.vue';

1
src/pages/Route/Vehicle/Card/VehicleDescriptor.vue
View File

@ -11,7 +11,6 @@ const { notify } = useNotify();
:url="`Vehicles/${$route.params.id}`"
data-key="Vehicle"
title="numberPlate"
:to-module="{ name: 'VehicleList' }"
>
<template #menu="{ entity }">
<QItem

11
src/pages/Route/Vehicle/Card/VehicleSummary.vue
View File

@ -13,12 +13,13 @@ const props = defineProps({ id: { type: [Number, String], default: null } });
const route = useRoute();
const entityId = computed(() => props.id || +route.params.id);
const baseLink = `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}`;
const links = {
jtubau marked this conversation as resolved Outdated
pablone commented 2025-03-03 06:50:41 +00:00
Outdated
Review
Copy Link

Crea una constante const baseLink = #/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}; para no repetir código

Crea una constante const baseLink = `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}`; para no repetir código
'basic-data': `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/basic-data`,
notes: `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/notes`,
dms: `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/dms`,
'invoice-in': `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/invoice-in`,
events: `#/${route.meta.moduleName.toLowerCase()}/vehicle/${entityId.value}/events`,
'basic-data': `${baseLink}/basic-data`,
notes: `${baseLink}/notes`,
dms: `${baseLink}/dms`,
'invoice-in': `${baseLink}/invoice-in`,
events: `${baseLink}/events`,
};
</script>
<template>