WIP: #8647 #8028 fix vitest warnings #1467

Draft
jsegarra wants to merge 72 commits from 8647_fix_warnings into dev
Member
No description provided.
jsegarra added 2 commits 2025-02-21 12:50:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
07d86251cb
test: refs #8647 mock keyShortcut
jsegarra added 4 commits 2025-02-23 09:05:19 +00:00
jsegarra added 1 commit 2025-02-23 20:54:38 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
bc3334529b
test: refs #8647 improve_warnings
jsegarra added 1 commit 2025-02-24 12:44:04 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
cf397a38ce
fix: refs #8647 some swarning
jsegarra added 1 commit 2025-02-27 19:16:04 +00:00
gitea/salix-front/pipeline/pr-test Build queued... Details
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
dcc4f390c6
Merge branch 'dev' into 8647_fix_warnings
jsegarra changed target branch from dev to test 2025-02-27 19:20:18 +00:00
jsegarra changed target branch from test to dev 2025-02-27 19:20:27 +00:00
jsegarra added 2 commits 2025-02-27 19:41:54 +00:00
jorgep added 2 commits 2025-02-28 08:28:51 +00:00
jsegarra added 3 commits 2025-02-28 08:42:19 +00:00
jorgep added 2 commits 2025-02-28 08:57:14 +00:00
jorgep added 1 commit 2025-02-28 09:07:37 +00:00
jorgep added 1 commit 2025-02-28 09:08:34 +00:00
jorgep added 1 commit 2025-02-28 09:26:49 +00:00
jsegarra added 4 commits 2025-02-28 09:40:59 +00:00
jsegarra changed title from WIP: #8647 fix vitest warnings to #8647 fix vitest warnings 2025-02-28 11:36:38 +00:00
jsegarra requested review from alexm 2025-02-28 11:36:44 +00:00
jorgep added 2 commits 2025-02-28 11:43:43 +00:00
alexm requested changes 2025-02-28 11:50:16 +00:00
Dismissed
@ -62,3 +62,3 @@
},
saveFn: {
type: Function,
type: [String, Function],
Member

string? saveFn

string? save**Fn**
Author
Member

En algun componente se estará usando string.
Yo solo he hecho modificar la prop para el warning, deberia parar a ver quien lo ha puesto mal?

En algun componente se estará usando string. Yo solo he hecho modificar la prop para el warning, deberia parar a ver quien lo ha puesto mal?
Member

Si

Si
Author
Member

era un test que tenia comillas.
Fixed

era un test que tenia comillas. Fixed
@ -26,7 +26,7 @@ function columnName(col) {
}
</script>
<template>
<VnFilterPanel v-bind="$attrs" :search-button="true" :disable-submit-event="true">
Member

Esto cambia propiedades

Esto cambia propiedades
jsegarra marked this conversation as resolved
@ -19,3 +21,4 @@
mocks: {
validate: vi.fn(),
},
directives: {
Member

Esto hay que repetirlo siempre?

Esto hay que repetirlo siempre?
Author
Member

No, solo cuando defines un createWrapper y le pasas un objeto global

No, solo cuando defines un createWrapper y le pasas un objeto global
Author
Member

Voy a darle una vuelta para hacer algo asi Object.assign(defaultOptions, options)

Voy a darle una vuelta para hacer algo asi `Object.assign(defaultOptions, options)`
@ -1,5 +1,5 @@
<script setup>
const model = defineModel({ type: [String, Number], required: true });
const model = defineModel({ type: [String, Number], default: '' });
Member

Siempre tiene que haber un v-model

Siempre tiene que haber un v-model
Author
Member

Voy a revisar, pero no me suena haber cambiado esto

Voy a revisar, pero no me suena haber cambiado esto
Author
Member
@jorgep
Member

Y siempre lo hay, pero con ese valor. Al usar un VnInputDate el valor por defecto era undefined y saltaba un warning

Y siempre lo hay, pero con ese valor. Al usar un VnInputDate el valor por defecto era undefined y saltaba un warning
jorgep marked this conversation as resolved
@ -256,3 +251,2 @@
if (!$props.defaultFilter) return update();
if (
if ($props.filterFn) update($props.filterFn(val));
Member

Aqui estas cambiando logica

Aqui estas cambiando logica
Author
Member
@jorgep
Member

Mira a ver ahora

Mira a ver ahora
@ -0,0 +1,30 @@
import { useI18n } from 'vue-i18n';
Member

?

?
Author
Member

este commit se ha colado

este commit se ha colado
@ -26,3 +29,1 @@
);
const result = await Promise.allSettled(rowsToUpdate);
notifyResults(result, 'saleFk');
// const rowsToUpdate = $props.selectedRows.map(({ saleFk, quantity }) =>
Member

?

?
jsegarra marked this conversation as resolved
@ -0,0 +1,281 @@
<script setup>
Member

Esto no tiene nada que ver con una PR para arreglar warnings

Esto no tiene nada que ver con una PR para arreglar warnings
jsegarra marked this conversation as resolved
@ -20,1 +21,4 @@
reset();
// setActivePinia(createPinia());
Member

?

?
jsegarra marked this conversation as resolved
jorgep added 1 commit 2025-02-28 12:02:51 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
2dab2866e7
fix: refs #8647 remove unused filterTowns fn
jorgep added 1 commit 2025-02-28 12:07:34 +00:00
jsegarra added 2 commits 2025-02-28 12:58:23 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
f0b3ae3ada
feat: refs #8647 remove
jsegarra added 1 commit 2025-02-28 12:59:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
2acbe53788
feat: refs #8647 remove
jsegarra reviewed 2025-02-28 17:55:49 +00:00
@ -191,3 +191,3 @@
<QList padding class="column-max-width">
<template v-if="$props.source === 'main'">
<template v-if="$route?.matched[1]?.name === 'Dashboard'">
<template v-if="route?.matched[1]?.name === 'Dashboard'">
Author
Member

elimino el $route porque salian warnings

elimino el $route porque salian warnings
jsegarra reviewed 2025-02-28 17:56:11 +00:00
@ -272,3 +272,3 @@
<template v-for="item in items" :key="item.name">
<template v-if="item.name === $route?.matched[1]?.name">
<template v-if="item.name === route?.matched[1]?.name">
Author
Member

preferiria usar v-else, que dices?

preferiria usar v-else, que dices?
jsegarra added 2 commits 2025-02-28 18:27:14 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
0ee939d568
feat: refs #8647 updates
jsegarra requested review from alexm 2025-03-05 09:03:02 +00:00
jorgep added 2 commits 2025-03-06 10:18:32 +00:00
jorgep added 1 commit 2025-03-06 10:37:10 +00:00
jorgep added 2 commits 2025-03-06 11:12:31 +00:00
alexm requested changes 2025-03-07 07:30:37 +00:00
Dismissed
alexm left a comment
Member

En general, hay que arreglar warnings o "ocultarlos"

En general, hay que arreglar warnings o "ocultarlos"
@ -268,0 +252,4 @@
if ($props.filterFn) update($props.filterFn(val));
else if (!val && lastVal.value === val) update();
else {
const makeRequest =
Member

@jorgep esto cambia?

@jorgep esto cambia?
Member

Lo he probado y funciona como antes, pruebalo si quieres por si acaso.

Lo he probado y funciona como antes, pruebalo si quieres por si acaso.
@ -13,3 +13,3 @@
},
filter: {
type: Object,
type: [String, Object],
Member

Mirar quien esta pasando un string y arreglar ese caso

Mirar quien esta pasando un string y arreglar ese caso
Author
Member

fixed. también era un test

fixed. también era un test
@ -6,3 +6,3 @@
id: {
type: Number,
required: true,
default: null,
Member

Deberia ser requirod un descriptor sin id no debe funcionar

Deberia ser requirod un descriptor sin id no debe funcionar
Member

El tema está en que si la carga es dinámica al principio se pasa undefined, hasta que carga y muestra un warning tipo: "Expected number but got undefined

El tema está en que si la carga es dinámica al principio se pasa undefined, hasta que carga y muestra un warning tipo: "Expected number but got undefined
Member

Un v-if diria que es mas correcto @jorgep

Un v-if diria que es mas correcto @jorgep
Member

Tiene v-if

Tiene v-if
@ -6,3 +6,3 @@
id: {
type: Number,
required: true,
default: null,
Member

=

=
Member

El tema está en que si la carga es dinámica al principio se pasa undefined, hasta que carga y muestra un warning tipo: "Expected number but got undefined

El tema está en que si la carga es dinámica al principio se pasa undefined, hasta que carga y muestra un warning tipo: "Expected number but got undefined
Member

Un v-if diria que es mas correcto @jorgep

Un v-if diria que es mas correcto @jorgep
Member

tiene v-if

tiene v-if
jorgep added 1 commit 2025-03-07 08:27:08 +00:00
Member

@alexm este if ya estaba, no lo he puesto yo, habiendo esto, tampoco hace falta un required. Pero aparte, sin el default tira un warning, como te he explicado arriba
image**

image .

@alexm este *if* ya estaba, no lo he puesto yo, habiendo esto, tampoco hace falta un required. Pero aparte, sin el default tira un warning, como te he explicado arriba ![image](/attachments/486e4d50-7ffc-41c6-ba19-4303a08fd29b)** ![image](/attachments/4b922d45-ecaf-4c26-bf63-ba65665c14f1) .
jorgep requested review from alexm 2025-03-07 10:32:26 +00:00
jsegarra added 2 commits 2025-03-10 11:30:30 +00:00
jsegarra added 1 commit 2025-03-10 11:33:34 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
92a7f2c33c
test: refs #8647 revert filter string
jsegarra added 1 commit 2025-03-10 11:34:38 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
04a3c48cd6
Merge branch 'dev' into 8647_fix_warnings
jsegarra added 3 commits 2025-03-11 09:52:10 +00:00
jsegarra changed title from #8647 fix vitest warnings to #8647 #8028 fix vitest warnings 2025-03-11 09:53:12 +00:00
Author
Member

He añadido la solución para la tarea 8028

He añadido la solución para la tarea 8028
jsegarra added 1 commit 2025-03-12 22:56:03 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
b4d21d5a52
Merge branch 'dev' into 8647_fix_warnings
alexm requested changes 2025-03-13 06:19:44 +00:00
Dismissed
@ -66,3 +66,3 @@
},
beforeSaveFn: {
type: Function,
type: [String, Function],
Member

Hay que mirar quien le esta pasando un String, no aceptarlo

Hay que mirar quien le esta pasando un String, no aceptarlo
jsegarra marked this conversation as resolved
@ -30,0 +30,4 @@
v-bind="$attrs"
:search-button="true"
:disable-submit-event="true"
:data-key="$attrs['data-key']"
Member

Ja pasa con el v-bind no?

Ja pasa con el v-bind no?
Author
Member

comor?

comor?
@ -8,25 +8,36 @@ import { isDialogOpened } from 'src/filters';
const arrayDataStore = useArrayDataStore();
export function useArrayData(key, userOptions) {
key ??= useRoute().meta.moduleName;
Member

Esto da warnings? No serà que hay q mockearlo?

Esto da warnings? No serà que hay q mockearlo?
Author
Member

Resuelve la #8028

Resuelve la #8028
Author
Member

Warning en DevTools no en vitest

Warning en DevTools no en vitest
jsegarra added 3 commits 2025-03-16 13:39:54 +00:00
jsegarra added 1 commit 2025-03-24 02:32:32 +00:00
jsegarra added 2 commits 2025-03-25 22:54:38 +00:00
jsegarra added 1 commit 2025-04-02 20:30:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
7706d77f55
Merge branch 'dev' into 8647_fix_warnings
Author
Member

@alexm @jorgep hay que ver que está pasando con esta PR porque fallan 68 test.
antes del 24/03/2025 fallaban 18, pero desde que se mergeo dev en la rama fallan 68
Estoy tirando los de VnLocation, y tiene 7 fallos
image
image
image
image
image
image

@alexm @jorgep hay que ver que está pasando con esta PR porque fallan 68 test. antes del 24/03/2025 fallaban 18, pero desde que se mergeo dev en la rama fallan 68 Estoy tirando los de VnLocation, y tiene 7 fallos ![image](/attachments/fb1f5e37-63f0-4ab5-9d5a-1d7f2fd1e323) ![image](/attachments/8dd8da30-549e-4065-8c98-61a03566c9f4) ![image](/attachments/eaf265f2-1352-4f26-a845-ca5dd6d047cb) ![image](/attachments/22e5aa02-b225-48f8-9088-483758c8eae7) ![image](/attachments/47450c0f-c140-4062-ba75-f19839268bfc) ![image](/attachments/94647403-6e8c-4701-ba80-c4102888cdc3)
jsegarra requested review from alexm 2025-04-02 21:09:34 +00:00
jsegarra added 1 commit 2025-04-07 05:52:11 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
7c4c708342
Merge branch 'dev' into 8647_fix_warnings
Member

Me espero a que resuelvas los conflictos para revisar?

Me espero a que resuelvas los conflictos para revisar?
Author
Member

Me espero a que resuelvas los conflictos para revisar?

Yes, please

> Me espero a que resuelvas los conflictos para revisar? Yes, please
jsegarra changed title from #8647 #8028 fix vitest warnings to WIP: #8647 #8028 fix vitest warnings 2025-04-08 12:15:20 +00:00
alexm added 2 commits 2025-04-09 11:04:45 +00:00
alexm added 1 commit 2025-04-09 12:01:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
d31c2d55eb
test: refs #8647 fix warnings arraydata and vnselect
Member

Revisando https://gitea.verdnatura.es/verdnatura/salix-front/pulls/1465/files
Hemos conseguido bajar de 36 warnings a 11 (Creemos que son internos de VnTable)

Revisando https://gitea.verdnatura.es/verdnatura/salix-front/pulls/1465/files Hemos conseguido bajar de 36 warnings a 11 (Creemos que son internos de VnTable)
jon added 1 commit 2025-04-09 13:33:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
a74e1102ed
test: refs #8647 deleted all warnings
Member

Se ha conseguido eliminar todos los warnings. Falta solo acabar de perfilar el archivo setup-file para que al detectar un warning lance el error

Se ha conseguido eliminar todos los warnings. Falta solo acabar de perfilar el archivo setup-file para que al detectar un warning lance el error
Author
Member

Pero ambas PRs tiene fallos por un tubo. Tanto de e2e como de front

Pero ambas PRs tiene fallos por un tubo. Tanto de e2e como de front
Member

En los últimos commits no ha fallado ningún test de front al lanzarse en jenkins. Solo los e2e

En los últimos commits no ha fallado ningún test de front al lanzarse en jenkins. Solo los e2e
jon added 1 commit 2025-04-10 07:34:27 +00:00
gitea/salix-front/pipeline/pr-dev Something is wrong with the build of this commit Details
aefb7b7dcb
feat: refs #8647 vitest fail on warning
alexm added 1 commit 2025-04-10 07:40:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
c0ce2af459
Merge branch 'dev' into 8647_fix_warnings
alexm approved these changes 2025-04-10 07:41:40 +00:00
Dismissed
Member

Yo creo que algo de arrayData esta roto, es raro que fallen tantos e2e

Yo creo que algo de arrayData esta roto, es raro que fallen tantos e2e
Member

Le deberiamos dar prioridad a fusionarla, para que no aparezcan mas warnings, ahora que ya los tenemos todos arreglados 🚀

Le deberiamos dar prioridad a fusionarla, para que no aparezcan mas warnings, ahora que ya los tenemos todos arreglados 🚀
jon was assigned by jsegarra 2025-04-10 09:56:23 +00:00
jorgep added 2 commits 2025-04-10 16:10:50 +00:00
jorgep dismissed alexm’s review 2025-04-10 16:10:51 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Member

Revirtiendo los cambios en arrayData solo fallan dos e2e: entryBasicData y entryDms

Revirtiendo los cambios en arrayData solo fallan dos e2e: entryBasicData y entryDms
Member

El problema de los test es:
-EntryBasicData: el comando deleteEntry no pilla bien el descriptor-menu-options
-EntryDms: se modificó el archivo VnDms isnertando un foreach que da error

El problema de los test es: -EntryBasicData: el comando deleteEntry no pilla bien el descriptor-menu-options -EntryDms: se modificó el archivo VnDms isnertando un foreach que da error
jon added 1 commit 2025-04-11 06:01:53 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
2678ac5def
feat: refs #8647 unskipp e2e to test which of them are really failling and fixed VnDms
jon added 1 commit 2025-04-11 06:53:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
e4da145a5e
refactor: refs #8647 skip front failing test
jon added 1 commit 2025-04-11 08:17:18 +00:00
jon added 1 commit 2025-04-11 09:50:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
be3c48b9f1
refactor: refs #8647 solved inject warning
jon added 1 commit 2025-04-11 09:57:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
27691943d3
perf: refs #8647 warnings
jon added 1 commit 2025-04-11 11:33:27 +00:00
gitea/salix-front/pipeline/pr-dev Something is wrong with the build of this commit Details
88099a9f34
Merge branch 'dev' into 8647_fix_warnings
jon added 2 commits 2025-04-11 11:44:50 +00:00
alexm reviewed 2025-04-11 11:50:25 +00:00
alexm requested changes 2025-04-11 11:56:59 +00:00
@ -30,3 +24,3 @@
model: 'crudModel',
url: 'crudModelUrl',
saveFn: '',
saveFn: vi.fn(),
Member

undefined?

undefined?
@ -145,3 +147,3 @@
async function fetch(params) {
useArrayData(props.dataKey, params);
if (params) applyParams(params);
Member

Cuidado con este cambio

Cuidado con este cambio
@ -1,5 +1,5 @@
import '../commands.js';
describe('EntryDms', () => {
describe.skip('EntryDms', () => {
Member

Estos ahora se skipean?

Estos ahora se skipean?
Some checks reported warnings
gitea/salix-front/pipeline/pr-dev This commit is unstable
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1467
No description provided.