fix: refs #8618 update route descriptor to handle empty ticket records and adjust test cases #1478

Merged
jtubau merged 11 commits from 8619-fixRouteExtendedListTest into dev 2025-03-07 10:06:46 +00:00
Member
No description provided.
jtubau added 1 commit 2025-02-24 11:08:00 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
6c29a5ed67
fix: refs #8619 update route descriptor to handle empty ticket records and adjust test cases
jtubau requested review from jsegarra 2025-02-24 11:12:08 +00:00
jsegarra requested changes 2025-02-25 22:37:04 +00:00
Dismissed
@ -28,3 +28,3 @@
where: { routeFk: $props.id ? $props.id : route.params.id },
};
const { data } = await axios.get('Tickets/findOne', {
const { data: [firstRecord] = [] } = await axios.get('Tickets/filter', {
Member

Yo lo simplificaria en data
Ya si después de comprobar si existe data o no, ya desestructuras

Yo lo simplificaria en data Ya si después de comprobar si existe data o no, ya desestructuras
Author
Member

Ok, lo ajusto

Ok, lo ajusto
jtubau marked this conversation as resolved
@ -146,3 +137,1 @@
cy.task('deleteFile', `${downloadsFolder}/${fileName}`).then((deleted) => {
expect(deleted).to.be.true;
});
// cy.task('deleteFile', `${downloadsFolder}/${fileName}`).then((deleted) => {
Member

esto lo comentó Juan o tu?

esto lo comentó Juan o tu?
Author
Member

Esto lo comento Juan

Esto lo comento Juan
Member

Okey, elimínalo de todas maneras porque el código ya se queda guardado en git

Okey, elimínalo de todas maneras porque el código ya se queda guardado en git
Author
Member

Perdón, esto lo comenté yo porque Juan comentó la task del cypress.config.js

Perdón, esto lo comenté yo porque Juan comentó la task del cypress.config.js
jtubau marked this conversation as resolved
jtubau changed title from fix: refs #8619 update route descriptor to handle empty ticket records and adjust test cases to fix: refs #8618 update route descriptor to handle empty ticket records and adjust test cases 2025-02-26 05:06:26 +00:00
jtubau added 1 commit 2025-02-26 09:27:31 +00:00
jtubau requested review from jsegarra 2025-02-26 10:32:36 +00:00
jsegarra requested changes 2025-02-26 11:40:39 +00:00
Dismissed
@ -34,2 +34,3 @@
});
zoneId.value = data.zoneFk;
if ( data.length == 0 ) return;
Member

if (!data.length) return;

if (!data.length) return;
jtubau marked this conversation as resolved
jtubau added 1 commit 2025-02-27 10:53:58 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
b614cb2046
refactor: refs #8619 simplify empty data check in RouteDescriptor component
jtubau requested review from jsegarra 2025-02-27 10:54:24 +00:00
jsegarra approved these changes 2025-02-27 11:07:18 +00:00
jtubau added 1 commit 2025-02-28 06:33:40 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
da7d8ed114
Merge branch 'dev' into 8619-fixRouteExtendedListTest
jtubau added 1 commit 2025-02-28 12:35:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
250f814b4b
Merge branch 'dev' into 8619-fixRouteExtendedListTest
jtubau added 1 commit 2025-03-03 08:35:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
01985512b6
Merge branch 'dev' into 8619-fixRouteExtendedListTest
jtubau added 1 commit 2025-03-03 10:35:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
2456ee08ae
Merge branch 'dev' into 8619-fixRouteExtendedListTest
jtubau scheduled this pull request to auto merge when all checks succeed 2025-03-03 12:25:07 +00:00
jtubau added 1 commit 2025-03-04 18:22:58 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
0518a780d1
Merge branch 'dev' into 8619-fixRouteExtendedListTest
jtubau added 1 commit 2025-03-05 09:59:57 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
d096c34943
Merge branch 'dev' into 8619-fixRouteExtendedListTest
jtubau added 1 commit 2025-03-07 07:11:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
178109d451
Merge branch 'dev' into 8619-fixRouteExtendedListTest
jtubau added 1 commit 2025-03-07 09:58:37 +00:00
jtubau merged commit 833e7c01d3 into dev 2025-03-07 10:06:46 +00:00
jtubau deleted branch 8619-fixRouteExtendedListTest 2025-03-07 10:16:01 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1478
No description provided.