feat: refs #8118 add VnDropdown component and integrate it into Claim and Ticket summaries #1517

Merged
benjaminedc merged 53 commits from 8118-createComponentVnDropdown into dev 2025-03-26 10:32:30 +00:00
Member
No description provided.
benjaminedc added 1 commit 2025-02-28 10:38:15 +00:00
benjaminedc added 1 commit 2025-02-28 10:38:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d148b7b813
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc requested review from jorgep 2025-02-28 10:39:21 +00:00
benjaminedc added 1 commit 2025-02-28 11:51:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
6e9fa6eae0
Merge branch 'dev' into 8118-createComponentVnDropdown
jorgep reviewed 2025-02-28 12:20:47 +00:00
jorgep reviewed 2025-02-28 12:21:34 +00:00
jorgep requested changes 2025-02-28 12:26:50 +00:00
Dismissed
@ -0,0 +11,4 @@
type: Boolean,
default: null,
},
moduleName: {
Member

No usar moduleName , optionLabel

No usar moduleName , optionLabel
benjaminedc marked this conversation as resolved
@ -0,0 +39,4 @@
:options="$props.options"
hide-selected
option-value="code"
hide-dropdown-icon
Member

añadir: :option-label="optionLabel", se puede hacer directamente :option-label si se llama igual la variable que quieres pasar, pero al ser camelCase no sé si funciona.

añadir: `:option-label="optionLabel"`, se puede hacer directamente :option-label si se llama igual la variable que quieres pasar, pero al ser camelCase no sé si funciona.
benjaminedc marked this conversation as resolved
jorgep requested changes 2025-02-28 12:32:45 +00:00
Dismissed
@ -0,0 +18,4 @@
options: {
type: Array,
default: null,
},
Member

añadir también optionValue, tiene que ser flexible, puede que no se quiera usar siempre code, si quieres ponerlo como opción por defecto vale.

añadir también optionValue, tiene que ser flexible, puede que no se quiera usar siempre code, si quieres ponerlo como opción por defecto vale.
benjaminedc marked this conversation as resolved
jorgep reviewed 2025-02-28 12:36:44 +00:00
jorgep requested changes 2025-02-28 12:39:50 +00:00
Dismissed
@ -173,3 +174,3 @@
async function changeState(value) {
await axios.patch(`Claims/updateClaim/${entityId.value}`, { claimStateFk: value });
const newState = claimStates.value.find((state) => state.code == value);
Member

Si en VnDropdown, creas la prop optionValue y le dices que use id , ya no te hace falta hacer un find para encontrar el id.

Si en VnDropdown, creas la prop optionValue y le dices que use id , ya no te hace falta hacer un find para encontrar el id.
benjaminedc marked this conversation as resolved
benjaminedc added 1 commit 2025-03-07 11:12:41 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
015efb31d3
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-07 12:23:39 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
51998963eb
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 2 commits 2025-03-07 12:31:37 +00:00
benjaminedc added 2 commits 2025-03-12 12:22:21 +00:00
benjaminedc added 1 commit 2025-03-13 06:31:00 +00:00
benjaminedc added 2 commits 2025-03-13 07:07:09 +00:00
benjaminedc added 1 commit 2025-03-13 07:43:42 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
5116ce89a1
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-13 12:11:06 +00:00
benjaminedc requested review from jorgep 2025-03-13 12:11:36 +00:00
benjaminedc added 1 commit 2025-03-13 12:17:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
13d9967bb5
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 2 commits 2025-03-14 06:38:17 +00:00
benjaminedc added 1 commit 2025-03-14 07:19:24 +00:00
jorgep reviewed 2025-03-14 09:34:18 +00:00
jorgep requested changes 2025-03-14 09:40:25 +00:00
Dismissed
@ -0,0 +48,4 @@
focus-on-mount
@update:model-value="changeState"
>
<template #option="scope">
Member

Este template es el que tiene por defecto VnSelect, no hace falta que lo añadas aquí.

Este template es el que tiene por defecto VnSelect, no hace falta que lo añadas aquí.
benjaminedc marked this conversation as resolved
@ -181,2 +184,4 @@
return '#/claim/' + entityId.value + '/' + section;
}
onMounted(async () => {
Member

Pasar a fetchData y obtener solo los campos que necesitas(id y name)

Pasar a fetchData y obtener solo los campos que necesitas(id y name)
benjaminedc marked this conversation as resolved
@ -135,0 +117,4 @@
:moduleId="entityId"
:options="editableStates"
:disable="!isEditable()"
@change-state="changeState($event)"
Member

Aquí tenías puesto antes el code, ahora usas el id,, pero el back espera un code.

Aquí tenías puesto antes el code, ahora usas el id,, pero el back espera un code.
benjaminedc marked this conversation as resolved
benjaminedc added 1 commit 2025-03-14 11:10:38 +00:00
benjaminedc added 1 commit 2025-03-17 08:07:49 +00:00
benjaminedc added 1 commit 2025-03-17 09:14:38 +00:00
benjaminedc added 1 commit 2025-03-17 09:37:13 +00:00
benjaminedc added 1 commit 2025-03-20 07:10:41 +00:00
benjaminedc added 1 commit 2025-03-20 08:34:56 +00:00
benjaminedc added 2 commits 2025-03-20 09:04:38 +00:00
benjaminedc requested review from jorgep 2025-03-20 09:32:36 +00:00
benjaminedc added 1 commit 2025-03-20 11:55:55 +00:00
gitea/salix-front/pipeline/pr-dev Something is wrong with the build of this commit Details
efb6c2357b
fix: refs #8118 update Cypress parallel test execution to run with a single instance
benjaminedc added 1 commit 2025-03-20 12:01:23 +00:00
benjaminedc added 1 commit 2025-03-21 07:09:09 +00:00
benjaminedc added 1 commit 2025-03-21 08:26:19 +00:00
benjaminedc added 1 commit 2025-03-21 08:53:12 +00:00
benjaminedc added 1 commit 2025-03-21 09:55:19 +00:00
benjaminedc added 1 commit 2025-03-24 07:44:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
16279518f7
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-24 07:58:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d427d4f215
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-24 08:32:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a98a2012a2
Merge branch 'dev' into 8118-createComponentVnDropdown
jorgep added 2 commits 2025-03-24 09:02:41 +00:00
jorgep requested changes 2025-03-24 09:32:21 +00:00
Dismissed
@ -1,6 +1,6 @@
<script setup>
import axios from 'axios';
import { ref, computed } from 'vue';
import { ref, computed, onMounted } from 'vue';
Member

onMounted no se usa, quitar

onMounted no se usa, quitar
benjaminedc marked this conversation as resolved
@ -232,0 +212,4 @@
<VnDropdown
:options="claimStates"
option-label="description"
option-value="id"
Member

Si usas id no no hace falta pasar la propiedad, utiliza ese por defecto

Si usas id no no hace falta pasar la propiedad, utiliza ese por defecto
benjaminedc marked this conversation as resolved
@ -135,0 +116,4 @@
<VnDropdown
:disable="!isEditable()"
:options="editableStates"
:option-label="'name'"
Member

no hace falta usar ":" cuando es texto.

no hace falta usar ":" cuando es texto.
benjaminedc marked this conversation as resolved
@ -135,0 +118,4 @@
:options="editableStates"
:option-label="'name'"
:option-value="'code'"
@change-state="changeState($event)"
Member

No hace falta poner $event, con poner changeState es suficiente.

No hace falta poner $event, con poner **changeState** es suficiente.
benjaminedc marked this conversation as resolved
benjaminedc added 1 commit 2025-03-24 11:08:32 +00:00
benjaminedc added 1 commit 2025-03-24 11:08:48 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
03e5e6387a
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 2 commits 2025-03-24 11:09:15 +00:00
benjaminedc added 1 commit 2025-03-24 11:25:15 +00:00
benjaminedc added 1 commit 2025-03-25 07:46:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
82a2ad8473
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-25 08:44:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2705bccb58
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc requested review from jorgep 2025-03-25 08:45:43 +00:00
benjaminedc added 1 commit 2025-03-25 10:12:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
44ec056cfa
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-25 10:41:25 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
969963fd5a
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-25 11:00:55 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
95b31dac4f
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-25 12:31:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
20b006e07b
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-25 12:45:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6e1a0266fd
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-26 07:38:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c35b8fa293
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-26 08:10:57 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c85c84e50a
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-26 08:30:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
bd1a38fd0e
Merge branch 'dev' into 8118-createComponentVnDropdown
benjaminedc added 1 commit 2025-03-26 09:45:12 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c20dd788d9
Merge branch 'dev' into 8118-createComponentVnDropdown
jorgep approved these changes 2025-03-26 10:20:38 +00:00
Member

@benjaminedc Crea una noticia en redmine con la creación de este componente. y avisa por rocket.

@benjaminedc Crea una noticia en redmine con la creación de este componente. y avisa por rocket.
benjaminedc merged commit ceb18df7ff into dev 2025-03-26 10:32:30 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1517
No description provided.