verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

feat: refs #8118 add VnDropdown component and integrate it into Claim and Ticket summaries #1517

Merged
benjaminedc merged 53 commits from 8118-createComponentVnDropdown into dev 2025-03-26 10:32:30 +00:00
Conversation 1 Commits 53 Files Changed 3 +4 -6
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 43701bd586 - Show all commits

5
src/pages/Claim/Card/ClaimSummary.vue
View File

@ -1,6 +1,6 @@
<script setup>
import axios from 'axios';
import { ref, computed, onMounted } from 'vue';
import { ref, computed } from 'vue';
benjaminedc marked this conversation as resolved Outdated
jorgep commented 2025-03-24 08:44:29 +00:00
Outdated
Review
Copy Link

onMounted no se usa, quitar

onMounted no se usa, quitar
import { useRoute, useRouter } from 'vue-router';
import { useI18n } from 'vue-i18n';
import { toDate, toCurrency } from 'src/filters';
@ -212,8 +212,7 @@ function claimUrl(section) {
<VnDropdown
:options="claimStates"
option-label="description"
option-value="id"
@change-state="changeState($event)"
@change-state="changeState"
benjaminedc marked this conversation as resolved Outdated
jorgep commented 2025-03-24 08:44:13 +00:00
Outdated
Review
Copy Link

Si usas id no no hace falta pasar la propiedad, utiliza ese por defecto

Si usas id no no hace falta pasar la propiedad, utiliza ese por defecto
/>
</template>
<template #menu="{ entity }">

5
src/pages/Ticket/Card/TicketSummary.vue
View File

@ -116,9 +116,8 @@ onMounted(async () => {
<VnDropdown
:disable="!isEditable()"
:options="editableStates"
:option-label="'name'"
:option-value="'code'"
@change-state="changeState($event)"
option-value="code"
benjaminedc marked this conversation as resolved Outdated
jorgep commented 2025-03-24 09:24:15 +00:00
Outdated
Review
Copy Link

no hace falta usar ":" cuando es texto.

no hace falta usar ":" cuando es texto.
@change-state="changeState"
benjaminedc marked this conversation as resolved Outdated
jorgep commented 2025-03-14 09:39:05 +00:00
Outdated
Review
Copy Link

Aquí tenías puesto antes el code, ahora usas el id,, pero el back espera un code.

Aquí tenías puesto antes el code, ahora usas el id,, pero el back espera un code.
/>
benjaminedc marked this conversation as resolved
jorgep commented 2025-03-24 09:32:14 +00:00
Review
Copy Link

No hace falta poner $event, con poner changeState es suficiente.

No hace falta poner $event, con poner **changeState** es suficiente.
</template>
<template #menu="{ entity }">