verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 82 Releases Wiki Activity

feat: #8655 added button for scrolling up #1523

Open
provira wants to merge 31 commits from 8655-scrollUpButton into dev
pull from: 8655-scrollUpButton
merge into: verdnatura:dev
Conversation 2 Commits 31 Files Changed 8 +139 -18
provira commented 2025-02-28 13:26:12 +00:00
Member
Copy Link
No description provided.
provira added 1 commit 2025-02-28 13:26:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
69452e2627 feat: refs #8655 added button for scrolling up
provira added 1 commit 2025-03-03 08:50:20 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
27866e7090 fix: refs #8655 fixed button problems & added translations
provira added 1 commit 2025-03-03 12:13:48 +00:00
provira requested review from pablone 2025-03-03 13:26:56 +00:00
provira added 1 commit 2025-03-03 14:05:34 +00:00
gitea/salix-front/pipeline/pr-dev Something is wrong with the build of this commit Details
a5f287d782 Merge branch 'dev' into 8655-scrollUpButton
provira changed title from WIP: feat: #8655 added button for scrolling up to feat: #8655 added button for scrolling up 2025-03-04 08:07:54 +00:00
provira added 1 commit 2025-03-04 09:28:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
640d989090 Merge branch 'dev' into 8655-scrollUpButton
pablone requested changes 2025-03-04 10:20:41 +00:00
Dismissed
pablone left a comment
Member
Copy Link

Te fallan los e2e

Te fallan los e2e
provira added 1 commit 2025-03-05 06:02:55 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
1101db707e Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-05 10:46:34 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
83b9b602a0 Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-05 12:21:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
6e9e5c7564 Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-06 06:01:00 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
f33f09ca6f Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-06 06:41:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
cee6e0d0b1 Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-07 05:46:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
a0860522f5 Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-07 08:31:06 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ff4e0103e7 Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-07 09:46:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
adb78c7433 fix: refs #8655 fixed e2e tests
provira added 1 commit 2025-03-07 10:09:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
48ebca9568 Merge branch 'dev' into 8655-scrollUpButton
provira requested review from pablone 2025-03-07 10:17:48 +00:00
pablone requested changes 2025-03-07 13:25:50 +00:00
Dismissed
pablone left a comment
Member
Copy Link

veo que el icono de ir arriba es distinto de el de salix, confirma con @jgallego ya que en la tarea tampoco veo mockup

veo que el icono de ir arriba es distinto de el de salix, confirma con @jgallego ya que en la tarea tampoco veo mockup
jgallego commented 2025-03-07 15:07:28 +00:00
Owner
Copy Link

veo que el icono de ir arriba es distinto de el de salix, confirma con @jgallego ya que en la tarea tampoco veo mockup

Tiene que quedar como salix

> veo que el icono de ir arriba es distinto de el de salix, confirma con @jgallego ya que en la tarea tampoco veo mockup Tiene que quedar como salix
jgallego requested review from alexm 2025-03-07 15:07:35 +00:00
provira added 1 commit 2025-03-11 11:34:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
429772ce88 Merge branch 'dev' into 8655-scrollUpButton
alexm commented 2025-03-13 06:43:08 +00:00
Member
Copy Link

Tiene que ser asi:
image

No asi:
image

Tiene que ser asi: ![image](/attachments/efdbd9cc-f941-4971-8ca6-3d621968ff76) No asi: ![image](/attachments/d6bead98-8f9d-403e-b2f7-ea225ebc85cc)
image.png
12 KiB
image.png
6.6 KiB
alexm requested changes 2025-03-13 06:45:52 +00:00
Dismissed
src/components/VnTable/VnTable.vue Outdated
@ -219,6 +234,16 @@ onUnmounted(async () => {
if ($props.isEditable) document.removeEventListener('click', clickHandler);
});
watch(
alexm commented 2025-03-13 06:45:51 +00:00
Member
Copy Link

Ver si se puede capturar el evento al hacer scroll de QTable (para no poner watchers ni ifs)

Ver si se puede capturar el evento al hacer scroll de QTable (para no poner watchers ni ifs)
provira marked this conversation as resolved
src/components/VnTable/VnTable.vue Outdated
@ -628,6 +653,16 @@ const rowCtrlClickFunction = computed(() => {
});
</script>
<template>
<QBtn
alexm commented 2025-03-13 06:44:51 +00:00
Member
Copy Link

Usar el componente

Usar el componente
provira marked this conversation as resolved
test/cypress/integration/order/orderList.spec.js
@ -20,3 +21,1 @@
cy.dataCy('landedDate').find('input').type('06/01/2001');
cy.selectOption(agencyCreateSelect, 1);
cy.get('.q-menu > div> .q-item:nth-child(1)').click();
alexm commented 2025-03-13 06:29:44 +00:00
Member
Copy Link

Esto no suele ir bien, tampoco deberia estar en esta tarea

Esto no suele ir bien, tampoco deberia estar en esta tarea
provira marked this conversation as resolved
provira added 1 commit 2025-03-13 07:42:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
20c531bc04 Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-14 12:07:00 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
4db882cc03 feat: refs #8655 made VnTable to use VnScroll button
provira added 1 commit 2025-03-14 12:07:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
08b0eb3c74 Merge branch 'dev' into 8655-scrollUpButton
provira requested review from pablone 2025-03-14 12:07:35 +00:00
provira requested review from alexm 2025-03-14 12:07:35 +00:00
provira added 2 commits 2025-03-14 12:38:16 +00:00
provira added 1 commit 2025-03-17 06:58:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
da8366d05b Merge branch 'dev' into 8655-scrollUpButton
pablone requested changes 2025-03-17 09:09:05 +00:00
Dismissed
src/components/common/VnScroll.vue Outdated
@ -0,0 +80,4 @@
</script>
<template>
<QIcon
pablone commented 2025-03-17 09:08:50 +00:00
Member
Copy Link

Te falta el efecto de hover al poner el ratón sobre el icono (poner el cursor como pointer y un pequeño degrado en el color). valora poner un QBtn y lo pondria un poco más grande size="md"

Te falta el efecto de hover al poner el ratón sobre el icono (poner el cursor como pointer y un pequeño degrado en el color). valora poner un `QBtn` y lo pondria un poco más grande `size="md"`
provira commented 2025-03-20 06:37:48 +00:00
Author
Member
Copy Link

Con un QBtn se ve muy pequeño el icono con respecto al tamaño del botón

Con un QBtn se ve muy pequeño el icono con respecto al tamaño del botón
pablone marked this conversation as resolved
provira added 2 commits 2025-03-20 06:35:07 +00:00
provira added 1 commit 2025-03-20 06:35:16 +00:00
gitea/salix-front/pipeline/pr-dev Something is wrong with the build of this commit Details
70a15bff30 Merge branch 'dev' into 8655-scrollUpButton
provira requested review from pablone 2025-03-20 06:38:18 +00:00
provira added 1 commit 2025-03-20 12:37:09 +00:00
gitea/salix-front/pipeline/pr-dev Something is wrong with the build of this commit Details
2ac3b280af Merge branch 'dev' into 8655-scrollUpButton
provira added 1 commit 2025-03-21 10:06:12 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7d5f51349a Merge branch 'dev' into 8655-scrollUpButton
pablone requested changes 2025-03-24 09:50:43 +00:00
Dismissed
src/components/common/VnScroll.vue
@ -0,0 +79,4 @@
});
</script>
<template>
pablone commented 2025-03-24 09:35:53 +00:00
Member
Copy Link

Si lo visualizas desde el movil no se queda en el centro
image

Si lo visualizas desde el movil no se queda en el centro ![image](/attachments/4194e3b9-925f-4dd5-93fe-d2c20f4e402d)
provira marked this conversation as resolved
provira added 2 commits 2025-03-24 10:48:25 +00:00
provira added 1 commit 2025-03-24 10:49:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ca2e507401 Merge branch 'dev' into 8655-scrollUpButton
provira requested review from pablone 2025-03-24 10:49:19 +00:00
pablone approved these changes 2025-03-24 11:43:06 +00:00
Dismissed
alexm added 1 commit 2025-03-27 13:00:40 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c9bea020fa Merge branch 'dev' into 8655-scrollUpButton
alexm dismissed pablone’s review 2025-03-27 13:00:40 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm requested changes 2025-03-27 13:08:23 +00:00
Dismissed
src/components/VnTable/VnTable.vue Outdated
@ -325,15 +337,6 @@ function handleOnDataSaved(_) {
else $props.create.onDataSaved(_);
}
function handleScroll() {
alexm commented 2025-03-27 13:02:06 +00:00
Member
Copy Link

Esta funcionalidad no se debe quitar

Esta funcionalidad no se debe quitar
provira marked this conversation as resolved
src/components/common/VnScroll.vue
@ -0,0 +43,4 @@
updateScrollContainer
});
const initScrollContainer = async () => {
alexm commented 2025-03-27 13:08:00 +00:00
Member
Copy Link

Yo esto lo simplificaria a:

const initScrollContainer = async () => {
await nextTick();
let scrollContainer  = window;
    if (props.target) {
        if (typeof props.scrollTarget === 'object') {
            scrollContainer = props.scrollTarget;
        } else {
            scrollContainer = document.querySelector(props.scrollTarget);
        }
    }

    if (!scrollContainer) return
        scrollContainer.addEventListener('scroll', onScroll);    
};
Yo esto lo simplificaria a: ``` const initScrollContainer = async () => { await nextTick(); let scrollContainer = window; if (props.target) { if (typeof props.scrollTarget === 'object') { scrollContainer = props.scrollTarget; } else { scrollContainer = document.querySelector(props.scrollTarget); } } if (!scrollContainer) return scrollContainer.addEventListener('scroll', onScroll); }; ```
provira commented 2025-03-27 13:25:03 +00:00
Author
Member
Copy Link

Se carga el window scroll. Esta solución funciona y reduce el codigo innecesario, además se puede prescindir de la prop mode (ya no es necesaria):

const initScrollContainer = async () => {
    await nextTick();

    if (typeof props.scrollTarget === 'object') {
        scrollContainer = props.scrollTarget;
    } else {
        scrollContainer = window;
    }

    if (!scrollContainer) return
        scrollContainer.addEventListener('scroll', onScroll);    
};
Se carga el window scroll. Esta solución funciona y reduce el codigo innecesario, además se puede prescindir de la prop mode (ya no es necesaria): ``` const initScrollContainer = async () => { await nextTick(); if (typeof props.scrollTarget === 'object') { scrollContainer = props.scrollTarget; } else { scrollContainer = window; } if (!scrollContainer) return scrollContainer.addEventListener('scroll', onScroll); }; ```
provira added 1 commit 2025-03-28 08:37:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6434a37598 feat: refs #8655 simplified code
provira requested review from alexm 2025-03-31 07:01:54 +00:00
alexm reviewed 2025-04-04 12:55:34 +00:00
src/components/VnTable/VnTable.vue
@ -189,1 +191,4 @@
const onVirtualScroll = ({ to }) => {
handleScroll();
const virtualScrollContainer = tableRef.value?.$el?.querySelector('.q-table__middle');
alexm commented 2025-04-04 12:55:34 +00:00
Member
Copy Link

Esta parte es necesaria? Con el codigo que hay dentro de VnScroll no funciona?

Esta parte es necesaria? Con el codigo que hay dentro de VnScroll no funciona?
alexm approved these changes 2025-04-04 13:00:04 +00:00
pablone approved these changes 2025-04-07 06:44:12 +00:00
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request has changes conflicting with the target branch.
  • src/components/VnTable/VnTable.vue
Sign in to join this conversation.
Reviewers
No reviewers
alexm
pablone
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1523
No description provided.
Delete Branch "8655-scrollUpButton"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?