verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 82 Releases Wiki Activity

#8725 - submit_form_onClick #1564

Merged
jsegarra merged 25 commits from 8725_submit_form_onClick into dev 2025-04-08 12:58:52 +00:00
Conversation 2 Commits 25 Files Changed 6 +46 -19
jsegarra commented 2025-03-06 09:12:28 +00:00
Member
Copy Link
No description provided.
jsegarra added 5 commits 2025-03-06 09:12:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
32dac089f8 feat: refs #8725 saveAndContinue
jsegarra requested review from alexm 2025-03-06 09:13:50 +00:00
alexm requested changes 2025-03-07 07:24:32 +00:00
Dismissed
src/components/FormModel.vue Outdated
@ -135,0 +146,4 @@
const submitForm = async () => {
const isFormValid = await myForm.value.validate();
if (isFormValid) {
try {
alexm commented 2025-03-07 07:23:56 +00:00
Member
Copy Link

sin try catch deberia fallar igual

sin try catch deberia fallar igual
jsegarra commented 2025-03-07 13:01:14 +00:00
Author
Member
Copy Link

cierto, la costumbre

cierto, la costumbre
jsegarra added 2 commits 2025-03-07 13:00:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
215e3a6da4 feat: refs #8725 ok
jsegarra requested review from alexm 2025-03-07 13:01:16 +00:00
alexm requested changes 2025-03-07 13:06:28 +00:00
Dismissed
src/components/FormModel.vue Outdated
@ -326,4 +343,2 @@
ref="myForm"
v-if="formData"
@submit.prevent
@keyup.prevent="onKeyup"
alexm commented 2025-03-07 13:06:10 +00:00
Member
Copy Link

Este prevent se quita?

Este prevent se quita?
jsegarra commented 2025-03-10 11:09:41 +00:00
Author
Member
Copy Link

Lo he corregido

Lo he corregido
jsegarra commented 2025-03-10 11:10:50 +00:00
Author
Member
Copy Link

Rebajamos la expectativa de eta PR porque hay un dialogo que puede contener 2 botones a la vez y la lógica del submit no funciona como se espera.
Es el caso de añadir articulo a una entrada, el dialogo siempre se mantiene abierto

Rebajamos la expectativa de eta PR porque hay un dialogo que puede contener 2 botones a la vez y la lógica del submit no funciona como se espera. Es el caso de añadir articulo a una entrada, el dialogo siempre se mantiene abierto
jsegarra requested review from alexm 2025-03-12 11:41:47 +00:00
jsegarra commented 2025-03-12 11:42:03 +00:00
Author
Member
Copy Link

Resuelto

Rebajamos la expectativa de eta PR porque hay un dialogo que puede contener 2 botones a la vez y la lógica del submit no funciona como se espera.
Es el caso de añadir articulo a una entrada, el dialogo siempre se mantiene abierto

Resuelto > Rebajamos la expectativa de eta PR porque hay un dialogo que puede contener 2 botones a la vez y la lógica del submit no funciona como se espera. > Es el caso de añadir articulo a una entrada, el dialogo siempre se mantiene abierto
jsegarra added 1 commit 2025-03-12 22:53:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
e100078f4b Merge branch 'dev' into 8725_submit_form_onClick
jsegarra added 5 commits 2025-03-12 22:53:47 +00:00
alexm requested changes 2025-03-13 06:23:46 +00:00
Dismissed
src/components/FormModel.vue
@ -339,6 +346,7 @@ defineExpose({
name="form"
:data="formData"
:validate="validate"
:validations="validations()"
alexm commented 2025-03-13 06:22:05 +00:00
Member
Copy Link

Aqui se esta llamando

Aqui se esta llamando
jsegarra commented 2025-03-13 08:03:10 +00:00
Author
Member
Copy Link

validations devuelve una función

validations devuelve una función
src/components/FormModelPopup.vue
@ -88,3 +98,3 @@
:label="t('globals.save')"
:title="t('globals.save')"
@click="onClick(false)"
:type="!showSaveAndContinueBtn ? 'submit' : 'button'"
alexm commented 2025-03-13 06:23:44 +00:00
Member
Copy Link

Si funciona igual, veo mas simple usar 2 @click q 4 ternarios

Si funciona igual, veo mas simple usar 2 @click q 4 ternarios
jsegarra commented 2025-03-13 08:06:23 +00:00
Author
Member
Copy Link

No entiendo.
No funcionan igual. Uno al pulsar, esconde el modal y el continue, limpia el formulario y se mantiene a la vista
Son 2 botones diferentes y tienen condiciones diferentes

No entiendo. No funcionan igual. Uno al pulsar, esconde el modal y el continue, limpia el formulario y se mantiene a la vista Son 2 botones diferentes y tienen condiciones diferentes
jsegarra requested review from alexm 2025-03-13 08:06:28 +00:00
alexm approved these changes 2025-03-13 08:21:39 +00:00
Dismissed
alexm added 1 commit 2025-03-13 08:21:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
ae62e40c60 Merge branch 'dev' into 8725_submit_form_onClick
alexm dismissed alexm’s review 2025-03-13 08:21:47 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2025-03-13 08:21:58 +00:00
Dismissed
jsegarra added 1 commit 2025-03-24 02:31:09 +00:00
jsegarra dismissed alexm’s review 2025-03-24 02:31:09 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2025-03-24 12:32:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
1e049847a7 Merge branch 'dev' into 8725_submit_form_onClick
alexm approved these changes 2025-03-24 12:33:36 +00:00
Dismissed
jsegarra added 1 commit 2025-03-25 08:18:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
30eecdee2f Merge branch 'dev' into 8725_submit_form_onClick
jsegarra dismissed alexm’s review 2025-03-25 08:18:09 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2025-03-25 20:28:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
f9f4b16d71 Merge branch 'dev' into 8725_submit_form_onClick
jsegarra added 1 commit 2025-03-27 19:44:09 +00:00
jsegarra requested review from alexm 2025-03-27 19:44:16 +00:00
jsegarra scheduled this pull request to auto merge when all checks succeed 2025-03-27 19:44:22 +00:00
jsegarra added 1 commit 2025-03-31 21:39:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
a1ca92a135 Merge branch 'dev' into 8725_submit_form_onClick
alexm added 1 commit 2025-04-04 06:04:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
dc6487475f Merge branch 'dev' into 8725_submit_form_onClick
alexm approved these changes 2025-04-04 06:04:26 +00:00
Dismissed
jsegarra added 1 commit 2025-04-07 05:52:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
6553a1a7fc Merge branch 'dev' into 8725_submit_form_onClick
jsegarra added 2 commits 2025-04-08 09:57:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
af0c30f798 test: refs #8725 add save action to form model popup
jsegarra dismissed alexm’s review 2025-04-08 09:57:33 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from alexm 2025-04-08 10:42:45 +00:00
alexm approved these changes 2025-04-08 10:48:21 +00:00
Dismissed
jsegarra added 1 commit 2025-04-08 11:31:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d6362d042d Merge branch 'dev' into 8725_submit_form_onClick
jsegarra dismissed alexm’s review 2025-04-08 11:31:04 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra merged commit 7e56cb96ef into dev 2025-04-08 12:58:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1564
No description provided.
Delete Branch "8725_submit_form_onClick"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?