feat: refs #8441 add VehicleInvoiceIn component with invoice management functionality #1567

Open
jtubau wants to merge 62 commits from 8441-createVehicleInvoiceInSection into dev
Member

PR BACK: verdnatura/salix#3541 Fusionar primero back

✅PR BACK: https://gitea.verdnatura.es/verdnatura/salix/pulls/3541 **Fusionar primero back**
jtubau added 1 commit 2025-03-06 12:04:39 +00:00
jtubau added 1 commit 2025-03-06 12:06:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
08e68e47b8
test: refs #8441 add e2e tests for vehicleInvoiceIn
jtubau added 1 commit 2025-03-06 14:25:48 +00:00
jtubau added 1 commit 2025-03-07 14:28:29 +00:00
jtubau added 1 commit 2025-03-10 07:56:55 +00:00
jtubau added 1 commit 2025-03-10 08:26:09 +00:00
jtubau added 1 commit 2025-03-10 08:32:01 +00:00
gitea/salix-front/pipeline/pr-dev Something is wrong with the build of this commit Details
3961c4e276
refactor: refs #8441 add translation for assigned invoices in Vehicle locale
jtubau added 1 commit 2025-03-10 08:58:50 +00:00
jtubau requested review from jgallego 2025-03-10 10:31:00 +00:00
jgallego requested review from jorgep 2025-03-10 13:40:19 +00:00
jtubau added 1 commit 2025-03-11 07:56:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
5332e3ab60
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 1 commit 2025-03-11 08:49:19 +00:00
jtubau added 1 commit 2025-03-11 10:36:03 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ef797a3675
test: refs #8441 add Cypress tests for vehicle summary functionality
jorgep requested changes 2025-03-11 11:43:03 +00:00
Dismissed
jorgep left a comment
Member

En los links, testea que se abren los popups correctamente, nada más.

En los links, testea que se abren los popups correctamente, nada más.
@ -0,0 +80,4 @@
async function unassignInvoice(id) {
await axios.delete(`VehicleInvoiceIns/${id}`);
notify(t('globals.dataSaved'), 'positive');
Member

Si falla el delete mostrará la notificación de dataSaved Haz algo así:
async () => { try { await axios.delete(Vehicles/${entity.id}); notify('vehicle.remove', 'positive'); $router.push({ name: 'VehicleList' }); } catch (e) { throw e; } }

Si falla el delete mostrará la notificación de _dataSaved_ Haz algo así: ` async () => { try { await axios.delete(`Vehicles/${entity.id}`); notify('vehicle.remove', 'positive'); $router.push({ name: 'VehicleList' }); } catch (e) { throw e; } }`
jtubau marked this conversation as resolved
@ -20,6 +20,7 @@ route:
shipped: Fecha preparación
Member

Poner todas las fechas con el mismo formato. F. x

Poner todas las fechas con el mismo formato. F. x
jtubau marked this conversation as resolved
@ -0,0 +45,4 @@
cy.checkNotification('Data saved');
});
describe('Supplier pop-ups', () => {
Member

Creo que con validar que se abra el popup es suficiente.

Creo que con validar que se abra el popup es suficiente.
jtubau marked this conversation as resolved
@ -0,0 +65,4 @@
});
});
describe('Invoice pop-ups', () => {
Member

Creo que con validar que se abra el popup es suficiente.

Creo que con validar que se abra el popup es suficiente.
jtubau marked this conversation as resolved
@ -0,0 +69,4 @@
it('Should redirect to the invoiceIn summary from the invoice descriptor pop-up', () => {
cy.get(selectors.firstRowInvoice).click();
cy.get(selectors.descriptorTitle).should('have.text', invoice);
cy.get(
Member

guardar en variable con nombre descriptivo o usasr data-cy

guardar en variable con nombre descriptivo o usasr data-cy
jtubau marked this conversation as resolved
@ -0,0 +1,112 @@
describe('Vehicle summary', () => {
Member

Pasar a data-cy.

Pasar a data-cy.
jtubau marked this conversation as resolved
@ -0,0 +50,4 @@
cy.url().should('include', '/vehicle/1/invoice-in');
})
describe('Supplier basic data pop-ups', () => {
Member

Con que lo abra es suficiente.

Con que lo abra es suficiente.
jtubau marked this conversation as resolved
@ -0,0 +70,4 @@
});
});
describe('Supplier assigned invoices pop-ups', () => {
Member

Con que lo abra es suficiente

Con que lo abra es suficiente
jtubau marked this conversation as resolved
jtubau added 1 commit 2025-03-14 07:12:53 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
b8be248af9
fix: refs #8441 update unassign invoice functionality and notifications
jtubau added 1 commit 2025-03-14 11:45:05 +00:00
jtubau added 1 commit 2025-03-14 13:27:28 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
f1f9a6ac16
refactor: refs #8441 update vehicle summary links to include module name in routes
jtubau added 1 commit 2025-03-14 13:39:51 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
be36d0c864
fix: refs #8441 update selectors for summary buttons in vehicle invoice tests
jtubau added 1 commit 2025-03-14 13:46:12 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
430cddb554
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 1 commit 2025-03-14 13:52:35 +00:00
jtubau added 1 commit 2025-03-17 08:17:28 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
2eea5b453a
fix: refs #8441 move component to parent instead of children
jtubau added 1 commit 2025-03-17 09:29:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
128a271eba
fix: refs #8441 intermittent test fail
jtubau added 2 commits 2025-03-17 10:12:42 +00:00
jtubau added 1 commit 2025-03-17 10:33:12 +00:00
jtubau added 1 commit 2025-03-17 11:16:18 +00:00
jtubau added 1 commit 2025-03-17 11:45:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
d33eae43f9
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 2 commits 2025-03-17 12:08:13 +00:00
jtubau added 1 commit 2025-03-17 12:56:45 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
138b3322b7
test: refs #8441 try add q.table check visbility
jtubau added 1 commit 2025-03-17 13:05:43 +00:00
jtubau added 1 commit 2025-03-18 12:25:28 +00:00
jtubau requested review from jorgep 2025-03-25 07:14:45 +00:00
jorgep reviewed 2025-03-26 10:06:01 +00:00
jorgep requested changes 2025-03-26 10:18:27 +00:00
Dismissed
@ -21,0 +21,4 @@
ticket:
assignedInvoices: Assigned Invoices
assignInvoice: Assign invoice
invoiceUnlinked: Invoice unlinked
Member

el adjetivo va delante en inglés

el adjetivo va delante en inglés
Author
Member

cambiado

cambiado
jtubau marked this conversation as resolved
@ -51,6 +51,7 @@ route:
agencyModeName: Agency route
isOwn: Own
isAnyVolumeallowed: Any volume allowed
issued: Issued
Member

Creo que esta traduccion es global, o por lo menos es exactamente la misma que en invoiceIn, hazla global o mira a ver si ya está.

Creo que esta traduccion es global, o por lo menos es exactamente la misma que en invoiceIn, hazla global o mira a ver si ya está.
jtubau marked this conversation as resolved
@ -52,3 +52,4 @@
agencyAgreement: Agencia Acuerdo
isOwn: Propio
isAnyVolumeAllowed: Cualquier volumen
issued: F. emisión
Member

Lo mismo que en inglés

Lo mismo que en inglés
Author
Member

esta ahí por el filtro automático de vnTable, ya que busca la traducción en moduleName.params y en este caso es route.params

esta ahí por el filtro automático de vnTable, ya que busca la traducción en moduleName.params y en este caso es route.params
jtubau marked this conversation as resolved
jtubau added 1 commit 2025-03-27 13:29:09 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
99322a39e4
refactor: refs #8441 update notification messages for unlinking invoices
jtubau added 2 commits 2025-04-01 05:09:43 +00:00
jtubau requested review from jorgep 2025-04-01 05:14:38 +00:00
jtubau added 1 commit 2025-04-01 05:24:33 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
c57600b0f0
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jorgep reviewed 2025-04-01 07:34:57 +00:00
@ -0,0 +1,89 @@
describe('Vehicle Invoice In', () => {
const getSelector = (colField) =>
Member

getLinkSelector

getLinkSelector
jtubau marked this conversation as resolved
jorgep requested changes 2025-04-01 07:39:13 +00:00
Dismissed
@ -0,0 +84,4 @@
notify(t('vehicle.ticket.unlinkedInvoice'), 'positive');
tableRef.value.reload();
} catch (e) {
throw new Error(e.message);
Member

throw e

throw e
jtubau marked this conversation as resolved
jtubau added 1 commit 2025-04-02 04:51:48 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4e49a73173
chore: refs #8441 simplify error handling by rethrowing original errors
jtubau added 1 commit 2025-04-02 04:52:49 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
22293eb2f8
refactor: refs #8441 rename getSelector to getLinkSelector for clarity
jtubau added 1 commit 2025-04-02 10:12:04 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
666d524553
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 1 commit 2025-04-02 10:20:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
737eb74117
chore: refs #8441 remove exclamation marks
jtubau added 1 commit 2025-04-02 10:25:20 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
622307697f
chore: refs #8441 update unassign invoice confirmation messages in English and Spanish locales
jtubau requested review from jorgep 2025-04-02 10:33:38 +00:00
jtubau added 1 commit 2025-04-03 07:09:50 +00:00
jtubau added 1 commit 2025-04-03 09:59:28 +00:00
jtubau added 1 commit 2025-04-03 10:25:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
800530f943
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 2 commits 2025-04-03 13:20:11 +00:00
jtubau added 1 commit 2025-04-03 13:28:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
fcba8c7fcd
test: refs #8441 update invoice number in vehicle invoice test
jtubau added 1 commit 2025-04-04 06:49:52 +00:00
jtubau added 1 commit 2025-04-04 07:42:34 +00:00
jtubau added 1 commit 2025-04-04 08:11:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
b650d2b438
test: refs #8441 skip invoice pop-ups test due to Redmine #8863
jorgep approved these changes 2025-04-04 08:31:02 +00:00
Dismissed
jtubau added 1 commit 2025-04-04 09:37:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
903345203b
test: refs #8441 ensure menu visibility in vehicle summary tests
jtubau dismissed jorgep’s review 2025-04-04 09:37:44 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jtubau added 1 commit 2025-04-04 10:02:31 +00:00
jgallego approved these changes 2025-04-06 12:00:18 +00:00
Dismissed
jtubau added 1 commit 2025-04-07 05:24:02 +00:00
jtubau dismissed jgallego’s review 2025-04-07 05:24:03 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jtubau added 1 commit 2025-04-07 07:20:54 +00:00
jtubau added 1 commit 2025-04-07 07:35:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
20627c04f7
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau requested review from jorgep 2025-04-07 07:35:27 +00:00
jorgep approved these changes 2025-04-07 10:02:45 +00:00
Dismissed
jtubau added 1 commit 2025-04-07 11:42:41 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b93e5d0e40
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 1 commit 2025-04-07 12:07:56 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e8068c146d
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau scheduled this pull request to auto merge when all checks succeed 2025-04-07 12:08:07 +00:00
jtubau added 1 commit 2025-04-07 13:00:06 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
e10dac995d
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 1 commit 2025-04-08 08:24:42 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
89d7fccacd
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau added 2 commits 2025-04-08 11:51:34 +00:00
jtubau added 1 commit 2025-04-08 12:16:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
4b9e533ccd
refactor: refs #8441 intercept api call instead .q-notification
jtubau dismissed jorgep’s review 2025-04-08 12:16:38 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jtubau added 1 commit 2025-04-11 07:03:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
84385730cd
Merge branch 'dev' into 8441-createVehicleInvoiceInSection
jtubau requested review from jorgep 2025-04-11 07:11:26 +00:00
jtubau added 2 commits 2025-04-11 08:40:11 +00:00
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1567
No description provided.