#8388 fix invoice-in #1587

Merged
jorgep merged 19 commits from 8388-fixInvoiceIn into dev 2025-03-26 09:41:45 +00:00
Member
No description provided.
jorgep added 1 commit 2025-03-11 12:41:58 +00:00
jorgep added 1 commit 2025-03-14 16:24:58 +00:00
jorgep added 1 commit 2025-03-17 11:15:57 +00:00
jorgep added 1 commit 2025-03-17 12:25:48 +00:00
jorgep added 1 commit 2025-03-17 13:12:22 +00:00
jorgep added 1 commit 2025-03-17 16:13:47 +00:00
jorgep added 1 commit 2025-03-18 08:01:26 +00:00
jorgep added 1 commit 2025-03-18 09:02:29 +00:00
jorgep added 1 commit 2025-03-18 09:03:28 +00:00
gitea/salix-front/pipeline/pr-master Build queued... Details
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
26e232256e
fix: refs #8388 rollback
jorgep changed target branch from dev to master 2025-03-18 09:04:17 +00:00
jorgep changed target branch from master to dev 2025-03-18 09:04:25 +00:00
jorgep added 2 commits 2025-03-18 09:05:35 +00:00
jorgep added 1 commit 2025-03-18 10:53:59 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
0be772f237
Revert "Merge branch 'master' of https: refs #8388//gitea.verdnatura.es/verdnatura/salix-front into 8388-fixInvoiceIn"
This reverts commit f583617945, reversing
changes made to a01be2d0c1.
jorgep added 1 commit 2025-03-18 10:56:57 +00:00
jorgep force-pushed 8388-fixInvoiceIn from 002543e6bf to 01d1ca83ea 2025-03-18 10:59:48 +00:00 Compare
jorgep added 1 commit 2025-03-18 11:02:48 +00:00
jorgep added 1 commit 2025-03-18 11:04:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6546d06f60
refactor: refs #8388 update UI feedback
jorgep changed title from WIP: #8388 fix invoice-in to #8388 fix invoice-in 2025-03-18 12:20:34 +00:00
jorgep requested review from jgallego 2025-03-18 12:20:38 +00:00
jgallego requested changes 2025-03-20 07:11:28 +00:00
Dismissed
@ -50,2 +49,4 @@
if (!$props.formInitialData) {
dms.value.description =
$props.description ?? t($props.model + 'Description', dms.value);
dms.value.hasFile = false;
Owner

lo estas cambiando a nivel aplicacion, pero esto es un parámetro que debemos de pasar desde invoiceIn, junto con los otros que ya pasaras tipo dmsType

lo estas cambiando a nivel aplicacion, pero esto es un parámetro que debemos de pasar desde invoiceIn, junto con los otros que ya pasaras tipo dmsType
Author
Member

En todos los VnDms el checkbox hasFile está en valor intermedio, es correcto?

En todos los VnDms el checkbox hasFile está en valor intermedio, es correcto?
Owner

no, ese check no deberia tener el valor intermedio

no, ese check no deberia tener el valor intermedio
jorgep marked this conversation as resolved
@ -238,3 +254,3 @@
else
invoiceInFormRef.insert({
amount: (totals.totalTaxableBase - totalAmount).toFixed(2),
amount: (totalTaxableBase - totalAmount).toFixed(2),
Owner

asegurate que preferimos toFixed que toCurrency

asegurate que preferimos toFixed que toCurrency
Author
Member

100% toFixed, toCurrency se usa en la suma total. En el campo editable no.

100% toFixed, **toCurrency** se usa en la suma total. En el campo editable no.
jgallego marked this conversation as resolved
@ -60,9 +60,11 @@ invoiceIn:
net: Neto
stems: Tallos
country: País
noMatch: No cuadra
Owner

dos traducciones para la misma clave?

dos traducciones para la misma clave?
jorgep marked this conversation as resolved
jorgep added 1 commit 2025-03-21 14:33:39 +00:00
jorgep added 1 commit 2025-03-21 14:41:45 +00:00
Author
Member

@jgallego Es correcto que el checkbox tenga valor "-" ? Es un comportamiento global.
image

@jgallego Es correcto que el checkbox tenga valor "-" ? Es un comportamiento global. ![image](/attachments/f0de3c27-e7ab-4825-8ede-1a58f3c9dbf1)
102 KiB
jorgep requested review from jgallego 2025-03-21 14:45:26 +00:00
Owner

@jorgep ese checkbox no debe tener ese estado a nivel html

@jorgep ese checkbox no debe tener ese estado a nivel html
jgallego requested changes 2025-03-21 19:43:38 +00:00
Dismissed
jgallego left a comment
Owner

no, ese check no deberia tener el valor intermedio

no, ese check no deberia tener el valor intermedio
jorgep added 1 commit 2025-03-24 09:54:36 +00:00
jorgep added 1 commit 2025-03-24 10:12:21 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
028477ecbe
feat: refs #8388 add hasFile prop to VnDms component
jorgep added 1 commit 2025-03-24 10:16:03 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
2fabff05be
feat: refs #8388 add hasFile property handling in VnDms component
jorgep requested review from jgallego 2025-03-24 10:16:49 +00:00
jgallego approved these changes 2025-03-24 10:32:50 +00:00
Dismissed
jorgep added 1 commit 2025-03-24 11:24:08 +00:00
jorgep added 1 commit 2025-03-24 14:28:40 +00:00
jorgep added 1 commit 2025-03-24 15:15:23 +00:00
jorgep dismissed jgallego’s review 2025-03-24 15:15:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep requested review from jgallego 2025-03-24 15:15:35 +00:00
jgallego requested changes 2025-03-24 18:32:30 +00:00
Dismissed
@ -37,3 +37,3 @@
});
it('should create a new Invoice', () => {
it.only('should create a new Invoice', () => {
Owner

?

?
Author
Member

se me ha colado

se me ha colado
jorgep marked this conversation as resolved
jorgep added 1 commit 2025-03-25 08:36:20 +00:00
jorgep added 1 commit 2025-03-25 08:37:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0361958b47
test: refs #8388 remove exclusive focus from Invoice creation test
jorgep requested review from jgallego 2025-03-25 08:38:01 +00:00
jgallego approved these changes 2025-03-25 15:49:16 +00:00
Dismissed
jorgep added 1 commit 2025-03-25 16:32:41 +00:00
jorgep dismissed jgallego’s review 2025-03-25 16:32:41 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep added 1 commit 2025-03-25 16:34:16 +00:00
jorgep requested review from jgallego 2025-03-25 16:34:31 +00:00
jgallego approved these changes 2025-03-25 18:30:13 +00:00
jorgep added 1 commit 2025-03-26 09:11:10 +00:00
jorgep merged commit 40418c421b into dev 2025-03-26 09:41:45 +00:00
jorgep deleted branch 8388-fixInvoiceIn 2025-03-26 09:41:45 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1587
No description provided.