feat: refs #8534 implement navigation and state query guards for improved routing control #1621

Merged
alexm merged 14 commits from 8534-wait_queries into dev 2025-03-28 08:32:18 +00:00
Member
No description provided.
alexm added 1 commit 2025-03-23 10:58:46 +00:00
alexm added 1 commit 2025-03-23 10:59:56 +00:00
alexm reviewed 2025-03-23 11:00:32 +00:00
@ -0,0 +1,93 @@
import { useRole } from 'src/composables/useRole';
Author
Member

He separado las funciones del router asi se puede testear las funciones sin pasar por el router real de vue

He separado las funciones del router asi se puede testear las funciones sin pasar por el router real de vue
alexm reviewed 2025-03-23 11:00:38 +00:00
@ -0,0 +38,4 @@
next();
}
export async function stateQueryGuard(next) {
Author
Member

Esta es la nueva

Esta es la nueva
alexm added 1 commit 2025-03-23 11:47:08 +00:00
alexm added 2 commits 2025-03-24 07:41:51 +00:00
alexm added 1 commit 2025-03-25 06:54:06 +00:00
alexm added 1 commit 2025-03-26 12:33:06 +00:00
alexm added 1 commit 2025-03-26 14:01:28 +00:00
alexm added 1 commit 2025-03-26 14:02:17 +00:00
alexm added 2 commits 2025-03-27 06:53:27 +00:00
alexm added 1 commit 2025-03-27 06:54:04 +00:00
alexm reviewed 2025-03-27 08:31:19 +00:00
@ -29,4 +29,2 @@
.eq(2)
.should('have.text', 'Entry prices recalculated');
cy.get('[data-cy="descriptor-more-opts"]').click();
Author
Member

deleteEntry ya tiene
cy.get('[data-cy="descriptor-more-opts"]').click(); dentro

deleteEntry ya tiene `cy.get('[data-cy="descriptor-more-opts"]').click();` dentro
alexm requested review from jsegarra 2025-03-27 08:36:13 +00:00
alexm reviewed 2025-03-27 08:36:35 +00:00
@ -0,0 +38,4 @@
next();
}
export async function stateQueryGuard(to, from, next) {
Author
Member

Esta es la nueva, todo lo demás está movido

Esta es la nueva, todo lo demás está movido
jsegarra reviewed 2025-03-28 01:29:01 +00:00
@ -0,0 +1,39 @@
import { describe, it, expect, vi } from 'vitest';
import { ref, nextTick } from 'vue';
import { stateQueryGuard } from 'src/router/hooks';
import { __test as testStateQuery } from 'src/stores/useStateQueryStore';
Member

esto es nuevo?

esto es nuevo?
jsegarra requested changes 2025-03-28 01:32:42 +00:00
Dismissed
@ -101,3 +25,1 @@
}
document.title = title;
});
Router.beforeEach((to, from, next) => navigationGuard(to, from, next, Router, state));
Member

esta es una lastima que aqui no

esta es una lastima que aqui no
@ -102,2 +25,2 @@
document.title = title;
});
Router.beforeEach((to, from, next) => navigationGuard(to, from, next, Router, state));
Router.beforeEach((to, from, next) => stateQueryGuard(to, from, next));
Member

Router.beforeEach( stateQueryGuard);

Router.beforeEach( stateQueryGuard);
@ -103,1 +25,3 @@
});
Router.beforeEach((to, from, next) => navigationGuard(to, from, next, Router, state));
Router.beforeEach((to, from, next) => stateQueryGuard(to, from, next));
Router.afterEach((to) => setPageTitle(to));
Member

Router.afterEach(setPageTitle);

Router.afterEach(setPageTitle);
Author
Member

Cuando funcione gitea subo el commit

Cuando funcione gitea subo el commit
alexm added 2 commits 2025-03-28 07:32:54 +00:00
alexm requested review from jsegarra 2025-03-28 07:36:03 +00:00
jsegarra approved these changes 2025-03-28 08:25:05 +00:00
alexm merged commit ea694a606a into dev 2025-03-28 08:32:18 +00:00
alexm deleted branch 8534-wait_queries 2025-03-28 08:32:18 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1621
No description provided.