refactor: refs #8718 simplify VnAccountNumber component and remove obsolete tests #1645

Merged
jorgep merged 3 commits from 8718-hotfix-vnAccount into master 2025-03-28 13:04:31 +00:00
Member
No description provided.
jorgep added 1 commit 2025-03-26 15:01:30 +00:00
jorgep added 1 commit 2025-03-26 15:02:16 +00:00
jorgep requested review from jsegarra 2025-03-26 15:02:39 +00:00
jorgep reviewed 2025-03-26 15:03:19 +00:00
@ -32,2 +11,2 @@
:insertable
@update:model-value="handleUpdateModel"
@keydown.tab="model = useAccountShortToStandard($event.target.value) ?? model"
@input="model = $event.target.value.replace(/[^\d.]/g, '')"
Author
Member

Para que solo admita números y punto.

Para que solo admita números y punto.
jorgep reviewed 2025-03-26 15:05:09 +00:00
@ -1,37 +0,0 @@
describe('VnAccountNumber', () => {
Author
Member

useAccountShortToStandard ya tiene sus propios tests. Lo único que se podría testear es @input pero cypress se ralla con este evento y hasta que no pierde el foco no hace el replace, cosa que si lo hago yo funciona como toca.

**useAccountShortToStandard** ya tiene sus propios tests. Lo único que se podría testear es **@input** pero cypress se ralla con este evento y hasta que no pierde el foco no hace el replace, cosa que si lo hago yo funciona como toca.
jsegarra reviewed 2025-03-27 08:08:35 +00:00
@ -31,3 +10,2 @@
ref="inputRef"
:insertable
@update:model-value="handleUpdateModel"
@keydown.tab="model = useAccountShortToStandard($event.target.value) ?? model"
Member

Si useAccount falla hace model = model?

Si useAccount falla hace model = model?
jsegarra approved these changes 2025-03-28 12:28:05 +00:00
jsegarra added 1 commit 2025-03-28 12:28:18 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
fe2024c26a
Merge branch 'master' into 8718-hotfix-vnAccount
jorgep merged commit 74a7b39108 into master 2025-03-28 13:04:31 +00:00
jorgep deleted branch 8718-hotfix-vnAccount 2025-03-28 13:04:31 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1645
No description provided.