verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

refactor: refs #8718 simplify VnAccountNumber component and remove obsolete tests #1645

Merged
jorgep merged 3 commits from 8718-hotfix-vnAccount into master 2025-03-28 13:04:31 +00:00
Conversation 0 Commits 3 Files Changed 2 +2 -60
2 changed files with 2 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/components/common/VnAccountNumber.vue
View File

@ -1,35 +1,14 @@
<script setup> <script setup>
import { nextTick, ref } from 'vue';
import VnInput from './VnInput.vue'; import VnInput from './VnInput.vue';
import { useAccountShortToStandard } from 'src/composables/useAccountShortToStandard'; import { useAccountShortToStandard } from 'src/composables/useAccountShortToStandard';
const $props = defineProps({
insertable: {
type: Boolean,
default: false,
},
});
const emit = defineEmits(['update:modelValue', 'accountShortToStandard']);
const model = defineModel({ prop: 'modelValue' }); const model = defineModel({ prop: 'modelValue' });
const inputRef = ref(false);
function setCursorPosition(pos) {
const input = inputRef.value.vnInputRef.$el.querySelector('input');
input.focus();
input.setSelectionRange(pos, pos);
}
async function handleUpdateModel(val) {
model.value = val?.at(-1) === '.' ? useAccountShortToStandard(val) : val;
await nextTick(() => setCursorPosition(0));
}
</script> </script>
<template> <template>
<VnInput <VnInput
v-model="model" v-model="model"
ref="inputRef" ref="inputRef"
:insertable @keydown.tab="model = useAccountShortToStandard($event.target.value) ?? model"
jsegarra commented 2025-03-27 08:08:35 +00:00
Review
Copy Link

Si useAccount falla hace model = model?

Si useAccount falla hace model = model?
@update:model-value="handleUpdateModel" @input="model = $event.target.value.replace(/[^\d.]/g, '')"
jorgep commented 2025-03-26 15:03:19 +00:00
Review
Copy Link

Para que solo admita números y punto.

Para que solo admita números y punto.
❤️ 1
/> />
</template> </template>

37
test/cypress/integration/vnComponent/VnAccountNumber.spec.js
View File

@ -1,37 +0,0 @@
describe('VnAccountNumber', () => {
jorgep commented 2025-03-26 15:05:09 +00:00
Outdated
Review
Copy Link

useAccountShortToStandard ya tiene sus propios tests. Lo único que se podría testear es @input pero cypress se ralla con este evento y hasta que no pierde el foco no hace el replace, cosa que si lo hago yo funciona como toca.

**useAccountShortToStandard** ya tiene sus propios tests. Lo único que se podría testear es **@input** pero cypress se ralla con este evento y hasta que no pierde el foco no hace el replace, cosa que si lo hago yo funciona como toca.
const accountInput = 'input[data-cy="supplierFiscalDataAccount_input"]';
beforeEach(() => {
cy.login('developer');
cy.viewport(1920, 1080);
cy.visit('/#/supplier/1/fiscal-data');
});
describe('VnInput handleInsertMode()', () => {
it('should replace character at cursor position in insert mode', () => {
cy.get(accountInput).type('{selectall}4100000001');
cy.get(accountInput).type('{movetostart}');
cy.get(accountInput).type('999');
cy.get(accountInput).should('have.value', '9990000001');
});
it('should replace character at cursor position in insert mode', () => {
cy.get(accountInput).clear();
cy.get(accountInput).type('4100000001');
cy.get(accountInput).type('{movetostart}');
cy.get(accountInput).type('999');
cy.get(accountInput).should('have.value', '9990000001');
});
it('should respect maxlength prop', () => {
cy.get(accountInput).clear();
cy.get(accountInput).type('123456789012345');
cy.get(accountInput).should('have.value', '1234567890');
});
});
it('should convert short account number to standard format', () => {
cy.get(accountInput).clear();
cy.get(accountInput).type('123.');
cy.get(accountInput).should('have.value', '1230000000');
});
});