#6654 sticky class #165

Merged
jorgep merged 6 commits from 6654-stickySubToolbar into dev 2024-01-31 07:50:58 +00:00
Member
No description provided.
jorgep added 1 commit 2024-01-26 15:13:19 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
d86ac6f31b
feat: refs #6654 sticky class
jorgep added 1 commit 2024-01-29 09:29:59 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
0edfe24a85
fix: refs #6654 fix css
jorgep requested review from alexm 2024-01-29 09:36:24 +00:00
jorgep added the
CR / Tests passed
label 2024-01-29 09:36:29 +00:00
jorgep reviewed 2024-01-29 09:37:12 +00:00
@ -22,0 +27,4 @@
<style lang="scss" scoped>
.sticky {
position: sticky;
top: 62px;
Author
Member

He puesto 62 porque con 60 hace un ligero scroll.

He puesto 62 porque con 60 hace un ligero scroll.
Member

y porque pone 61?

y porque pone 61?
Author
Member

porque había un ligero hueco con 62px. Por eso lo he cambiado a 61

porque había un ligero hueco con 62px. Por eso lo he cambiado a 61
jorgep requested review from jsegarra 2024-01-29 09:37:25 +00:00
alexm approved these changes 2024-01-29 10:18:40 +00:00
Dismissed
jorgep changed title from WIP: #6654 sticky class to #6654 sticky class 2024-01-29 12:26:45 +00:00
jorgep added 1 commit 2024-01-29 13:15:09 +00:00
jorgep dismissed alexm’s review 2024-01-29 13:15:10 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2024-01-30 08:25:31 +00:00
jorgep added 2 commits 2024-01-30 09:34:12 +00:00
jorgep reviewed 2024-01-30 10:24:30 +00:00
@ -49,7 +49,6 @@ onMounted(async () => {
() => $props.url,
async (newUrl, lastUrl) => {
if (newUrl == lastUrl) return;
entity.value = null;
Author
Member

No se puede modificar el valor de una propiedad computed, esto no está haciendo nada. (Lo he comprobado de todas maneras)

No se puede modificar el valor de una propiedad computed, esto no está haciendo nada. (Lo he comprobado de todas maneras)
jorgep reviewed 2024-01-30 10:24:49 +00:00
@ -62,7 +61,6 @@ async function getData() {
skip: 0,
});
const { data } = await arrayData.fetch({ append: false, updateRouter: false });
entity.value = data;
Author
Member

No se puede modificar el valor de una propiedad computed, esto no está haciendo nada (Lo he comprobado de todas maneras)

No se puede modificar el valor de una propiedad computed, esto no está haciendo nada (Lo he comprobado de todas maneras)
alexm approved these changes 2024-01-30 10:48:37 +00:00
jsegarra approved these changes 2024-01-31 07:50:27 +00:00
jorgep merged commit bcfe5098d8 into dev 2024-01-31 07:50:58 +00:00
jorgep deleted branch 6654-stickySubToolbar 2024-01-31 07:50:58 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#165
No description provided.