verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

#7995: Added hasAcl to check only one acl #1654

Merged
jon merged 10 commits from 7995-CreateHasAcl into dev 2025-04-01 11:24:36 +00:00
Conversation 0 Commits 10 Files Changed 9 +20 -33
jon commented 2025-03-28 08:29:11 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2025-03-28 08:29:12 +00:00
jorgep reviewed 2025-03-28 13:08:11 +00:00
src/composables/useAcl.js Outdated
@ -32,1 +32,4 @@
function hasAcl(model, props, accessType) {
const modelAcl = state.getAcls().value[model];
const access = modelAcl[props];
jorgep commented 2025-03-28 13:08:11 +00:00
Member
Copy Link

const propAcl

**const propAcl**
jorgep marked this conversation as resolved
jorgep reviewed 2025-03-28 13:08:54 +00:00
src/composables/useAcl.js Outdated
@ -33,0 +35,4 @@
const access = modelAcl[props];
if (!modelAcl || !access) return false;
if (access[accessType] || access['*']) {
return true;
jorgep commented 2025-03-28 13:08:54 +00:00
Member
Copy Link

Tienes que verificar que sea la prop que tu indicas o * y lo mismo con accessType. Port tanto tendrás que comprobar:

  • ¿Existe prop y accessType?
  • ¿Existe * y accessType?
  • ¿Existe prop y *?
  • ¿Existe * y *?

Tiene que cumplirse 1 de las condiciones, si no, devolver false

Tienes que verificar que sea la prop que tu indicas o * y lo mismo con accessType. Port tanto tendrás que comprobar: - ¿Existe prop y accessType? - ¿Existe * y accessType? - ¿Existe prop y *? - ¿Existe * y *? Tiene que cumplirse 1 de las condiciones, si no, devolver false
jorgep marked this conversation as resolved
jon added 1 commit 2025-03-31 07:51:48 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
f8cc7b95ab refactor: refs #7995 modified hasAcl function
jon added 1 commit 2025-03-31 09:32:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
801e9687f7 Merge branch 'dev' into 7995-CreateHasAcl
jon changed title from WIP: #7995: Added hasAcl to check only one acl to #7995: Added hasAcl to check only one acl 2025-03-31 09:33:18 +00:00
jon requested review from jorgep 2025-03-31 09:33:27 +00:00
jorgep approved these changes 2025-04-01 07:24:16 +00:00
Dismissed
jorgep added 2 commits 2025-04-01 07:27:57 +00:00
jon added 2 commits 2025-04-01 07:34:46 +00:00
jon dismissed jorgep’s review 2025-04-01 07:34:46 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jon requested review from jorgep 2025-04-01 09:31:30 +00:00
jon added 1 commit 2025-04-01 09:31:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
27ec560fc5 Merge branch 'dev' into 7995-CreateHasAcl
jon added 1 commit 2025-04-01 10:13:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
3ddc6dc310 Merge branch 'dev' into 7995-CreateHasAcl
jorgep approved these changes 2025-04-01 10:41:46 +00:00
jon added 1 commit 2025-04-01 11:01:14 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
26861e92b6 Merge branch 'dev' into 7995-CreateHasAcl
jon scheduled this pull request to auto merge when all checks succeed 2025-04-01 11:01:55 +00:00
jon merged commit da21c0aad6 into dev 2025-04-01 11:24:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jorgep
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1654
No description provided.
Delete Branch "7995-CreateHasAcl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?