#4466 invoiceInCorrection #176

Merged
jorgep merged 22 commits from 4666-invoiceInCorrection into dev 2024-02-09 07:46:15 +00:00
Member
No description provided.
jorgep added 7 commits 2024-02-02 15:42:46 +00:00
jorgep changed title from #4666 invoiceInCorrection to :WIP #4666 invoiceInCorrection 2024-02-02 15:43:12 +00:00
jorgep changed title from :WIP #4666 invoiceInCorrection to WIP: #4666 invoiceInCorrection 2024-02-02 15:43:22 +00:00
jorgep added 1 commit 2024-02-05 07:37:51 +00:00
jorgep reviewed 2024-02-05 07:40:04 +00:00
@ -1,412 +1,387 @@
@font-face {
Author
Member

En la carpeta css, he añadido nuevos iconos.

En la carpeta css, he añadido nuevos iconos.
jorgep added 1 commit 2024-02-06 12:24:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1883cb79ab
feat: refs # create vnCurrency
jorgep added 1 commit 2024-02-06 14:16:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b76c2a35a8
fix: refs refs #4466 tests
jorgep requested review from alexm 2024-02-06 14:16:20 +00:00
jorgep requested review from jsegarra 2024-02-06 14:16:25 +00:00
jorgep added the
CR / Tests passed
label 2024-02-06 14:16:28 +00:00
jorgep added 1 commit 2024-02-06 14:16:50 +00:00
jorgep changed title from WIP: #4666 invoiceInCorrection to #4666 invoiceInCorrection 2024-02-06 14:16:59 +00:00
jorgep added 1 commit 2024-02-06 14:18:05 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a4deaf4be9
fix: refs refs #4466 console log
jorgep changed title from #4666 invoiceInCorrection to #4466 invoiceInCorrection 2024-02-06 14:18:39 +00:00
jsegarra requested changes 2024-02-07 06:11:21 +00:00
@ -63,2 +63,4 @@
allRows: 'All { numberRows } row(s)',
markAll: 'Mark all',
requiredField: 'Required field',
class: 'clase',
Member

class: 'clase'??

class: 'clase'??
Author
Member

Es una traducción.

Es una traducción.
jorgep marked this conversation as resolved
@ -53,3 +47,1 @@
arrayData.store.url = `InvoiceIns/${newId}`;
await arrayData.fetch({ append: false });
}
onMounted(async () => await arrayData.fetch({ append: false }));
Member

Aquí sólo ha cambiado el formateo, no?

Aquí sólo ha cambiado el formateo, no?
Author
Member

Sí, la funcionalidad es la misma.

Sí, la funcionalidad es la misma.
jsegarra marked this conversation as resolved
@ -0,0 +74,4 @@
const requiredFieldRule = (val) => val || t('globals.requiredField');
const onSave = (data) => data.deletes && router.push(`/invoice-in/${invoiceId}/summary`);
Member

Duda, porque se usa data.deletes?

Duda, porque se usa data.deletes?
Author
Member

está así en el crudModel

está así en el crudModel
@ -16,2 +16,4 @@
import SendEmailDialog from 'components/common/SendEmailDialog.vue';
import VnConfirm from 'src/components/ui/VnConfirm.vue';
import VnSelectFilter from 'src/components/common/VnSelectFilter.vue';
import { useFirstUpper } from 'src/composables/useFirstUpper';
Member

Duda, como se que lo hiciste tu hace 4 meses,...crees que podríamos proponer renombrarlo a useCapitalize.

Es que el nombre....FirstUpper...first de que ?
Inlcuso te digo que hay una propiedad css que lo hace:
.class::first-letter { text-transform: uppercase }

Duda, como se que lo hiciste tu hace 4 meses,...crees que podríamos proponer renombrarlo a useCapitalize. Es que el nombre....FirstUpper...first de que ? Inlcuso te digo que hay una propiedad css que lo hace: `.class::first-letter { text-transform: uppercase }`
Author
Member

es el mismo nombre que en salix, pero el nuevo nombre me parece bien que te digan @alexm , @jgallego y @juan . Lo de usar css... Habría que valorar si siempre queremos añadir una clase. lo digo porque tienes que envolver sí o sí en html el texto.

es el mismo nombre que en salix, pero el nuevo nombre me parece bien que te digan @alexm , @jgallego y @juan . Lo de usar css... Habría que valorar si siempre queremos añadir una clase. lo digo porque tienes que envolver sí o sí en html el texto.
Author
Member

Se ha quedado en cambiarlo a useCapitalize

Se ha quedado en cambiarlo a useCapitalize
jorgep marked this conversation as resolved
alexm reviewed 2024-02-07 06:14:33 +00:00
@ -0,0 +43,4 @@
align: 'left',
},
{
name: 'class',
Member

Veo mas llamarle type

Veo mas llamarle type
Author
Member

Ya hay un campo type y en salix este campo se llama clase

Ya hay un campo type y en salix este campo se llama clase
jorgep marked this conversation as resolved
alexm approved these changes 2024-02-07 06:16:49 +00:00
Dismissed
jsegarra added 1 commit 2024-02-07 07:52:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
532c88c7c3
Merge branch 'dev' into 4666-invoiceInCorrection
jsegarra dismissed alexm’s review 2024-02-07 07:52:18 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2024-02-07 09:17:28 +00:00
Dismissed
jorgep added 2 commits 2024-02-07 09:26:43 +00:00
jorgep requested review from jsegarra 2024-02-07 09:54:19 +00:00
jorgep added 1 commit 2024-02-07 14:58:16 +00:00
jorgep added 1 commit 2024-02-07 15:03:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
75b527207f
refacto: refs #4466 replace composable name
jorgep dismissed alexm’s review 2024-02-07 15:03:37 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm added 1 commit 2024-02-08 11:03:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
04ec81e852
Merge branch 'dev' into 4666-invoiceInCorrection
jsegarra approved these changes 2024-02-08 11:57:07 +00:00
Dismissed
jsegarra added 1 commit 2024-02-08 12:02:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
242a8e25a8
refs #4466 fix: change VnSearchBar placeholder
jsegarra dismissed jsegarra’s review 2024-02-08 12:02:45 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep added 2 commits 2024-02-08 12:34:34 +00:00
jsegarra approved these changes 2024-02-08 12:35:35 +00:00
Dismissed
alexm added 1 commit 2024-02-08 17:30:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2fb1688af4
Merge branch 'dev' into 4666-invoiceInCorrection
alexm dismissed jsegarra’s review 2024-02-08 17:30:50 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2024-02-08 17:30:54 +00:00
jsegarra approved these changes 2024-02-09 07:27:08 +00:00
jorgep merged commit 18a84f2d61 into dev 2024-02-09 07:46:15 +00:00
jorgep deleted branch 4666-invoiceInCorrection 2024-02-09 07:46:16 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#176
No description provided.