verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

6892-summaryCardRefact #221

Merged
carlossa merged 12 commits from 6892-summaryCardRefact into dev 2024-03-06 08:43:10 +00:00
Conversation 0 Commits 12 Files Changed 8 +110 -88
carlossa commented 2024-03-04 10:20:17 +00:00
Member
Copy Link
No description provided.
carlossa added the
CR / Tests passed
 label 2024-03-04 10:20:17 +00:00
carlossa added 6 commits 2024-03-04 10:20:17 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2ba9cc990d refs #6892 fix scss
carlossa requested review from alexm 2024-03-04 10:20:21 +00:00
carlossa added 1 commit 2024-03-04 10:20:58 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
bb17be2a8a refs #6892 remove label
alexm requested changes 2024-03-04 10:22:35 +00:00
src/components/ui/CardSummary.vue Outdated
@ -141,0 +149,4 @@
position: absolute;
left: 0;
margin-left: 5px;
color: gray;
alexm commented 2024-03-04 10:22:33 +00:00
Member
Copy Link

Gasta algun gris que ja estiga var(...)

Gasta algun gris que ja estiga var(...)
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-03-04 10:28:12 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f8872b81c5 refs #6892 rename color
carlossa requested review from alexm 2024-03-04 10:28:52 +00:00
alexm approved these changes 2024-03-04 10:32:51 +00:00
Dismissed
alexm requested changes 2024-03-04 10:33:06 +00:00
alexm left a comment
Member
Copy Link

Espera

Espera
alexm requested changes 2024-03-04 10:55:18 +00:00
src/components/ui/CardSummary.vue Outdated
@ -138,6 +138,20 @@ watch(props, async () => {
.header.link:hover {
color: lighten($primary, 20%);
}
.QCheckbox {
alexm commented 2024-03-04 10:52:21 +00:00
Member
Copy Link

Dueria ficar estos estils per defecte.
Ficant .q-checkbox encomter de .QCheckbox ja ho deuria ficar per defecte i no cal posar class="QCheckbox"

I mira si se pot possar que tinga la clase 'disbled'
LESS te aço https://stackoverflow.com/questions/12886972/how-do-i-add-a-new-class-to-an-element-dynamically

Igual sas te algo paregut
Aixina evitariem sempre tindre q ficar disabled=true

Dueria ficar estos estils per defecte. Ficant `.q-checkbox` encomter de `.QCheckbox` ja ho deuria ficar per defecte i no cal posar class="QCheckbox" I mira si se pot possar que tinga la clase 'disbled' LESS te aço https://stackoverflow.com/questions/12886972/how-do-i-add-a-new-class-to-an-element-dynamically Igual sas te algo paregut Aixina evitariem sempre tindre q ficar disabled=true
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-03-04 12:50:47 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8f9048a786 refs #6892 fix scss class
carlossa dismissed alexm’s review 2024-03-04 12:50:47 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlossa added 1 commit 2024-03-05 13:44:50 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ed44d96589 refs #6892 fix checkbox
carlossa added 1 commit 2024-03-05 13:47:17 +00:00
carlossa requested review from alexm 2024-03-05 13:47:28 +00:00
alexm approved these changes 2024-03-06 08:38:55 +00:00
Dismissed
carlossa added 1 commit 2024-03-06 08:40:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
207b95c0e9 Merge branch 'dev' into 6892-summaryCardRefact
carlossa dismissed alexm’s review 2024-03-06 08:40:47 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2024-03-06 08:42:32 +00:00
carlossa merged commit 8a964c7382 into dev 2024-03-06 08:43:10 +00:00
carlossa deleted branch 6892-summaryCardRefact 2024-03-06 08:43:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#221
No description provided.
Delete Branch "6892-summaryCardRefact"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?