verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

6336-refactor-claimSummary #227

Merged
jsegarra merged 5 commits from 6336-refactor-claimSummary into dev 2024-03-06 10:44:31 +00:00
Conversation 0 Commits 5 Files Changed 23 +171 -106
alexm commented 2024-03-05 13:47:15 +00:00
Member
Copy Link
No description provided.
alexm added 2 commits 2024-03-05 13:47:15 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5f77115716 refs #6336 feat: polish claims
alexm requested review from jsegarra 2024-03-05 13:47:20 +00:00
jsegarra reviewed 2024-03-06 05:32:37 +00:00
src/components/ui/VnNotes.vue
@ -55,0 +42,4 @@
<QCard
class="q-pa-xs q-mb-sm full-width"
v-for="(note, index) in rows"
:key="index"
jsegarra commented 2024-03-06 05:32:37 +00:00
Member
Copy Link

Sugenrencia, veo que el texzto está pegado al borde o que el contenido de la card no respira.
Podemos añadirle a este div padding:7px como lo está haciendo Basic Data

Sugenrencia, veo que el texzto está pegado al borde o que el contenido de la card no respira. Podemos añadirle a este div padding:7px como lo está haciendo Basic Data
alexm commented 2024-03-06 08:14:03 +00:00
Author
Member
Copy Link

Tiene exactamente el mismo padding total que Salix (8px)

Tiene exactamente el mismo padding total que Salix (8px)
alexm marked this conversation as resolved
jsegarra requested changes 2024-03-06 05:57:38 +00:00
src/pages/Claim/Card/ClaimCard.vue Outdated
@ -29,3 +29,3 @@
<QPage>
<VnSubToolbar />
<div class="q-pa-md"><RouterView></RouterView></div>
<div :class="$q.screen.gt.xs ? 'q-pa-md' : 'q-pa-xs'">
jsegarra commented 2024-03-06 05:57:11 +00:00
Member
Copy Link

Demasiados remplazos, lo vemos con un composable.
Que ya tengo hecho

Demasiados remplazos, lo vemos con un composable. Que ya tengo hecho
alexm commented 2024-03-06 08:14:17 +00:00
Author
Member
Copy Link

Subelo

Subelo
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2024-03-06 08:35:45 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4637053ab2 refs #6336 feat: useCardSize
jsegarra added 1 commit 2024-03-06 08:49:16 +00:00
jsegarra approved these changes 2024-03-06 08:49:30 +00:00
alexm added 1 commit 2024-03-06 09:14:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5510594b74 Merge branch 'dev' into 6336-refactor-claimSummary
jsegarra merged commit 7bfbf26606 into dev 2024-03-06 10:44:31 +00:00
jsegarra deleted branch 6336-refactor-claimSummary 2024-03-06 10:44:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#227
No description provided.
Delete Branch "6336-refactor-claimSummary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?