verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

feature/InvoicesOutCorrections #232

Merged
jsegarra merged 25 commits from :feature/InvoicesOutCorrections into dev 2024-03-20 13:34:35 +00:00
Conversation 0 Commits 25 Files Changed 18 +910 -271
hyervoni commented 2024-03-07 12:57:34 +00:00
Contributor
Copy Link
No description provided.
hyervoni added 16 commits 2024-03-07 12:57:35 +00:00
hyervoni requested review from alexm 2024-03-07 12:57:48 +00:00
hyervoni requested review from jgallego 2024-03-07 12:57:58 +00:00
hyervoni requested review from jsegarra 2024-03-07 12:57:58 +00:00
jsegarra requested changes 2024-03-08 07:44:07 +00:00
Dismissed
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -251,3 +219,4 @@
fileDenied: El navegador denegó la descarga de archivos...
fileAllowed: Descarga exitosa de archivo CSV
youCanSearchByInvoiceReference: Puedes buscar por referencia de la factura
downloadPdf: Download PDF
jsegarra commented 2024-03-08 07:44:05 +00:00
Member
Copy Link

👀...dos veces el mismo texto?

👀...dos veces el mismo texto?
wbuezas commented 2024-03-08 18:10:15 +00:00
Contributor
Copy Link

Buena observación, se me pasó, agregué la traducción correcta

Commit: 049e3c722a

Buena observación, se me pasó, agregué la traducción correcta Commit: https://gitea.verdnatura.es/verdnatura/salix-front/commit/049e3c722a897e48bb8dbc118b14eaaf3e0962f7
jsegarra marked this conversation as resolved
wbuezas added 2 commits 2024-03-08 18:05:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ed99aea4a3 Finish create manual invoice popup form
wbuezas added 1 commit 2024-03-08 18:09:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
049e3c722a Fix translation
jsegarra requested changes 2024-03-12 06:11:59 +00:00
Dismissed
src/pages/InvoiceOut/Card/SendInvoiceForm.vue Outdated
@ -0,0 +1,41 @@
<script setup>
jsegarra commented 2024-03-12 06:00:34 +00:00
Member
Copy Link

Si busco este archivo me salen 2 resultados, pero ninguno de ellos es de implementación o o donde se está usando. Es correcto?

Si busco este archivo me salen 2 resultados, pero ninguno de ellos es de implementación o o donde se está usando. Es correcto?
wbuezas commented 2024-03-12 13:00:01 +00:00
Contributor
Copy Link

Como bien mencionas parece que no se usa, al parecer lo habia creado para la funcionalidad de Send invoice pero encontre un componente reutilizable que se adecuaba a esto y luego se me olvido de borrar el otro.

Commit: fff5e1849e

Como bien mencionas parece que no se usa, al parecer lo habia creado para la funcionalidad de `Send invoice` pero encontre un componente reutilizable que se adecuaba a esto y luego se me olvido de borrar el otro. Commit: https://gitea.verdnatura.es/verdnatura/salix-front/commit/fff5e1849eaea53bc72a174b3eb6f4c618f7a7c3
❤️ 1
jsegarra commented 2024-03-12 13:02:45 +00:00
Member
Copy Link

genial, cosas del dia a dia! jejej

genial, cosas del dia a dia! jejej
jsegarra marked this conversation as resolved
src/pages/InvoiceOut/InvoiceOutList.vue Outdated
@ -130,4 +137,4 @@
class="q-mr-xl"
color="primary"
:disable="selectedCards.size === 0"
:label="t('globals.download')"
jsegarra commented 2024-03-12 05:58:30 +00:00
Member
Copy Link

jejeje pero en Salix está el icono, creo que quedaría mejor

jejeje pero en Salix está el icono, creo que quedaría mejor
wbuezas commented 2024-03-12 14:41:31 +00:00
Contributor
Copy Link

Perfecto, removi el label y agregue el icono tal como esta en salix

Commit: 06fa4aebc5

Perfecto, removi el label y agregue el icono tal como esta en salix Commit: https://gitea.verdnatura.es/verdnatura/salix-front/commit/06fa4aebc5b095e3b7f78736bf9b73350a5dc567
jsegarra marked this conversation as resolved
wbuezas added 1 commit 2024-03-12 12:59:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fff5e1849e Delete unused form
wbuezas added 1 commit 2024-03-12 14:40:12 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
06fa4aebc5 add invoice out list download icon
jsegarra approved these changes 2024-03-12 14:45:17 +00:00
Dismissed
alexm approved these changes 2024-03-13 08:41:00 +00:00
Dismissed
wbuezas added 1 commit 2024-03-14 12:50:37 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
22c49d9cf7 resolve conflicts
wbuezas dismissed jsegarra’s review 2024-03-14 12:50:37 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

wbuezas dismissed alexm’s review 2024-03-14 12:50:37 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

wbuezas added 1 commit 2024-03-15 13:21:43 +00:00
wbuezas added 1 commit 2024-03-19 16:50:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2ea6fd2ea6 Change vnconfirm export name
jgallego approved these changes 2024-03-20 13:26:53 +00:00
wbuezas added 1 commit 2024-03-20 13:33:59 +00:00
jsegarra merged commit 166e40833d into dev 2024-03-20 13:34:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#232
No description provided.
Delete Branch ":feature/InvoicesOutCorrections"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?