verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

refactor: #6993 set default QTable pagination #239

Merged
jon merged 16 commits from 6993-HideAllPagination into dev 2024-03-27 07:27:23 +00:00
Conversation 0 Commits 16 Files Changed 35 +28 -58
jon commented 2024-03-14 07:52:42 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-03-14 07:52:42 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
37a2c33f9f refactor: #6993 set default QTable pagination
jon requested review from alexm 2024-03-14 07:52:49 +00:00
jon requested review from jgallego 2024-03-14 07:53:47 +00:00
alexm refused to review 2024-03-14 07:55:46 +00:00
alexm requested review from alexm 2024-03-14 07:58:32 +00:00
jgallego refused to review 2024-03-14 08:07:07 +00:00
jon added 1 commit 2024-03-14 12:06:16 +00:00
jon added 1 commit 2024-03-14 12:09:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
667359ed92 Merge branch 'dev' into 6993-HideAllPagination
alexm requested changes 2024-03-15 06:23:41 +00:00
Dismissed
alexm left a comment
Member
Copy Link

También habrá que ver:
Si ahora no se muestra la paginación, al llegar a 25 registro, el 26, quasar lo sabe cargar automáticamente por el scroll?

También habrá que ver: Si ahora no se muestra la paginación, al llegar a 25 registro, el 26, quasar lo sabe cargar automáticamente por el scroll?
quasar.patch:Zone.Identifier Outdated
@ -0,0 +1,4 @@
[ZoneTransfer]
alexm commented 2024-03-15 06:18:44 +00:00
Member
Copy Link

Estos dos archivos supongo que te los pasaron, no deberian subirse al repo

Estos dos archivos supongo que te los pasaron, no deberian subirse al repo
jon marked this conversation as resolved
src/boot/defaults/setDefault.js
@ -0,0 +1,18 @@
export default function (component, key, value) {
alexm commented 2024-03-15 06:20:40 +00:00
Member
Copy Link

Esta parte es necesaria?

Esta parte es necesaria?
jsegarra commented 2024-03-15 06:42:17 +00:00
Member
Copy Link

Esta función es la que añade el valor a la clave del componente

Esta función es la que añade el **valor** a la **clave** del **componente**
jon marked this conversation as resolved
src/components/FilterItemForm.vue Outdated
@ -202,7 +202,6 @@ const selectItem = ({ id }) => {
<QTable
:columns="tableColumns"
:rows="tableRows"
:pagination="{ rowsPerPage: 0 }"
alexm commented 2024-03-15 06:22:23 +00:00
Member
Copy Link

En quasar al pagina por 0 les estamos diciendo que queremos todo el listado sin que pagine.
Creo que en estos caso dejaria de funcionar igual.

En quasar al pagina por 0 les estamos diciendo que queremos todo el listado **sin** que pagine. Creo que en estos caso dejaria de funcionar igual.
jon marked this conversation as resolved
jon added 1 commit 2024-03-15 11:45:22 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ff5e09d315 refs #6993 fixed QTable behaviour
jon requested review from alexm 2024-03-15 11:45:49 +00:00
carlossa added 1 commit 2024-03-15 11:50:11 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
07cd07427e refs #6993 remove depen
carlossa added 2 commits 2024-03-15 11:54:40 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4c63e2f5c1 merge
carlossa added 1 commit 2024-03-15 11:57:30 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
6ff8b7be34 refs #6993 fix conflicts
jon added 1 commit 2024-03-15 12:06:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a5441fb4a9 refs #6993 fix test front
jon added the
CR / Tests passed
 label 2024-03-15 12:07:31 +00:00
jon added 1 commit 2024-03-15 13:09:14 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8ebf4be807 refs: #6993 deleted useless files
alexm added 1 commit 2024-03-18 11:01:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e99b727b77 Merge branch 'dev' into 6993-HideAllPagination
alexm requested changes 2024-03-18 11:24:37 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Creo que se hay fallos al solucionar conflictos

Creo que se hay fallos al solucionar conflictos
src/pages/Route/RouteList.vue Outdated
@ -115,6 +113,24 @@ const updateRoute = async (route) => {
}
};
const updateVehicle = (row, vehicle) => {
alexm commented 2024-03-18 11:24:21 +00:00
Member
Copy Link

Aqui pq se hacen cambios?

Aqui pq se hacen cambios?
jon added 2 commits 2024-03-26 08:10:01 +00:00
jon added 2 commits 2024-03-26 08:45:00 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
9f24f1f97c refactor: refs #6993 merged conflicts
jon added 1 commit 2024-03-26 08:56:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7072dc783b refactor: refs #6993 fix test error
jon requested review from alexm 2024-03-26 08:57:16 +00:00
alexm approved these changes 2024-03-27 07:22:30 +00:00
jon merged commit 7cfffbd2de into dev 2024-03-27 07:27:23 +00:00
jon deleted branch 6993-HideAllPagination 2024-03-27 07:27:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#239
No description provided.
Delete Branch "6993-HideAllPagination"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?