verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 90 Releases Wiki Activity

refs #6551 feature/WorkerTimeControl #254

Merged
alexm merged 40 commits from :feature/WorkerTimeControl into dev 2024-04-23 13:12:51 +00:00
Conversation 19 Commits 40 Files Changed 17 +7 -4
1 changed files with 7 additions and 4 deletions
Showing only changes of commit 772959ff81 - Show all commits

11
src/stores/useWeekdayStore.js
View File

@ -43,12 +43,15 @@ export const useWeekdayStore = defineStore('weekdayStore', () => {
const getLocales = computed(() => {
// El día de mañana esto permitirá ordenar los weekdays en base a el locale si se lo desea reemplazando localeOrder.es por localeOrder[locale]
const locales = [];
for (let code of localeOrder.es) {
jsegarra marked this conversation as resolved Outdated
jsegarra commented 2024-04-02 06:49:15 +00:00
Outdated
Review

Que te parece este código? así evitamos repetir el texto de la traducción y acceder a code
for (let code of localeOrder.es) {
const weekDay = weekdaysMap[code];
const locale = t(weekdays.${weekdaysMap[code].code});
const obj = {
...weekDay,
locale,
localeChar: locale.substr(0, 1),
localeAbr: locale.substr(0, 3),
};
locales.push(obj);
}

Que te parece este código? así evitamos repetir el texto de la traducción y acceder a code for (let code of localeOrder.es) { const weekDay = weekdaysMap[code]; const locale = t(`weekdays.${weekdaysMap[code].code}`); const obj = { ...weekDay, locale, localeChar: locale.substr(0, 1), localeAbr: locale.substr(0, 3), }; locales.push(obj); }
wbuezas commented 2024-04-02 12:47:21 +00:00
Outdated
Review

Estoy de acuerdo, cambios aplicados

Commit: 772959ff81

Estoy de acuerdo, cambios aplicados Commit: https://gitea.verdnatura.es/hyervoni/salix-front-mindshore/commit/772959ff81f9a1b89e6dfb85f6f75e1709341e18
const weekDay = weekdaysMap[code];
const locale = t(`weekdays.${weekdaysMap[code].code}`);
const obj = {
...weekdaysMap[code],
locale: t(`weekdays.${weekdaysMap[code].code}`),
localeChar: t(`weekdays.${weekdaysMap[code].code}`).substr(0, 1),
localeAbr: t(`weekdays.${weekdaysMap[code].code}`).substr(0, 3),
...weekDay,
locale,
localeChar: locale.substr(0, 1),
localeAbr: locale.substr(0, 3),
};
locales.push(obj);
}