#6480 improve Card #271

Merged
jorgep merged 36 commits from 6480-improveCard into dev 2024-04-24 06:57:38 +00:00
Member
No description provided.
jorgep added 1 commit 2024-04-08 08:17:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4fa311120d
feat: refs #6480 hide if no content
jorgep added 1 commit 2024-04-08 08:33:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
dfac40adb3
feat: refs #6480 vnCard
jorgep added 1 commit 2024-04-10 11:08:57 +00:00
jsegarra added 1 commit 2024-04-10 18:53:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5f502c2aad
#6480: POC Claims
jorgep added 2 commits 2024-04-11 06:48:13 +00:00
jorgep added 1 commit 2024-04-11 07:08:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
96d3073f67
Revert "Merge branch '6480-improveCard' of https://gitea.verdnatura.es/verdnatura/salix-front into 6480-improveCard"
This reverts commit 984539b70f, reversing
changes made to d7ab6e8a02.
jorgep added 1 commit 2024-04-11 07:28:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
edf75c8cdd
feat: refs #6480 check if hasContent or slots
jorgep added 1 commit 2024-04-11 10:28:58 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
bfa9dc9634
feat: refs #6480 include drawer
jorgep added 1 commit 2024-04-11 10:33:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
170747371a
fix: refs #6480 css
jorgep reviewed 2024-04-11 10:38:33 +00:00
@ -141,3 +112,1 @@
</VnInput>
</QItemSection>
</QItem>
<QItemSection>
Author
Member

Tabulaciones del prettier

Tabulaciones del prettier
jorgep reviewed 2024-04-11 10:39:02 +00:00
@ -7,7 +7,6 @@ import VnFilterPanel from 'src/components/ui/VnFilterPanel.vue';
import FetchData from 'components/FetchData.vue';
import VnInput from 'src/components/common/VnInput.vue';
import VnInputDate from 'components/common/VnInputDate.vue';
import { useCapitalize } from 'src/composables/useCapitalize';
Author
Member

No se usa

No se usa
jorgep reviewed 2024-04-11 10:40:58 +00:00
@ -0,0 +11,4 @@
const stateStore = useStateStore();
</script>
<template>
<QDrawer v-model="stateStore.leftDrawer" show-if-above :width="256">
Author
Member

Esta parte también se repite mucho

Esta parte también se repite mucho
jorgep added 1 commit 2024-04-17 12:26:14 +00:00
jorgep added 1 commit 2024-04-18 06:50:28 +00:00
jorgep added 3 commits 2024-04-18 11:39:26 +00:00
jorgep added 1 commit 2024-04-18 12:16:48 +00:00
jorgep added 1 commit 2024-04-18 13:31:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
dfdfb6ec93
feat: refs #6480 locale
jorgep added 9 commits 2024-04-19 11:39:37 +00:00
jorgep added 1 commit 2024-04-19 11:40:00 +00:00
jorgep added 1 commit 2024-04-19 11:58:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7a4f975cc9
fix: refs #6480 fix warning
jorgep requested review from alexm 2024-04-19 14:55:26 +00:00
jorgep added the
CR / Tests passed
label 2024-04-19 14:55:53 +00:00
jorgep changed title from WIP: #6480 improve Card to #6480 improve Card 2024-04-19 14:56:14 +00:00
Author
Member

No veo que haga falta ningún test unitario.

No veo que haga falta ningún test unitario.
jorgep reviewed 2024-04-19 14:57:47 +00:00
@ -102,3 +102,3 @@
onBeforeRouteLeave((to, from, next) => {
if (hasChanges.value)
if (hasChanges.value && $props.observeFormChanges)
Author
Member

Solo muestra el popup si está prop es true y hay cambios

Solo muestra el popup si está prop es true y hay cambios
jorgep reviewed 2024-04-19 14:58:21 +00:00
@ -1,5 +1,5 @@
<script setup>
import { onBeforeMount, useSlots, watch, computed, ref } from 'vue';
Author
Member

Si solo se usa en el template se puede usar $slots

Si solo se usa en el template se puede usar $slots
jorgep reviewed 2024-04-19 14:59:31 +00:00
@ -63,3 +59,4 @@
async function getData() {
store.url = $props.url;
store.filter = $props.filter ?? {};
Author
Member

En la sección workerDescriptor fallaba porque se le estaba pasando en el filtro route.params.id y este no se actualizaba por lo que se hacía la llamada con el id anterior

En la sección workerDescriptor fallaba porque se le estaba pasando en el filtro route.params.id y este no se actualizaba por lo que se hacía la llamada con el id anterior
jorgep reviewed 2024-04-19 14:59:50 +00:00
@ -48,9 +48,10 @@ onBeforeMount(async () => {
async function fetch() {
store.url = props.url;
store.filter = props.filter ?? {};
Author
Member

mismo caso que con el descriptor

mismo caso que con el descriptor
jorgep reviewed 2024-04-19 15:00:53 +00:00
@ -131,13 +131,6 @@ async function search() {
/>
</template>
<template #append>
<QIcon
Author
Member

Ya hay un icono de close predeterminado

Ya hay un icono de close predeterminado
jorgep reviewed 2024-04-19 15:01:50 +00:00
@ -9,0 +15,4 @@
if (!actions.value && !data.value) return;
// Check if there's content to display
const observer = new MutationObserver(
Author
Member

comprueba que haya contenido dentro de ambos divs. Sería como un "watch" pero del DOM.

comprueba que haya contenido dentro de ambos divs. Sería como un "watch" pero del DOM.
jorgep reviewed 2024-04-19 15:02:29 +00:00
@ -16,2 +32,3 @@
<template>
<QToolbar class="bg-vn-section-color justify-end sticky">
<QToolbar
class="justify-end sticky"
Author
Member

es necesario poner v-show , porque si el div no existe no se puede hacer un teleport.

es necesario poner v-show , porque si el div no existe no se puede hacer un teleport.
jorgep reviewed 2024-04-19 15:02:54 +00:00
src/css/app.scss Outdated
@ -173,2 +173,4 @@
color: white !important;
}
.q-scrollarea__content {
Author
Member

Estaba dentro de 1 style sin scoped y se repetía varias veces

Estaba dentro de 1 style sin scoped y se repetía varias veces
jorgep reviewed 2024-04-19 15:05:43 +00:00
@ -12,3 +12,3 @@
},
});
const { params } = useRoute();
const router = useRoute();
Author
Member

solo es reactivo el router, no los params.

solo es reactivo el router, no los params.
jorgep reviewed 2024-04-19 15:06:31 +00:00
@ -32,3 +32,3 @@
const worker = ref();
const filter = { where: { id: route.params.id}};
const filter = computed(() => {
Author
Member

Es necesario para que se actualice al cambiar de ruta.

Es necesario para que se actualice al cambiar de ruta.
jorgep reviewed 2024-04-19 15:06:39 +00:00
@ -28,3 +28,3 @@
});
const filter = { where: { id: entityId.value } };
const filter = computed(() => {
Author
Member

Es necesario para que se actualice al cambiar de ruta.

Es necesario para que se actualice al cambiar de ruta.
alexm approved these changes 2024-04-22 06:38:54 +00:00
Dismissed
alexm left a comment
Member

Asegúrate de lanzar los e2e
El código 10/10

Asegúrate de lanzar los e2e El código 10/10
jorgep added 1 commit 2024-04-23 07:23:52 +00:00
jorgep dismissed alexm’s review 2024-04-23 07:23:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep added 1 commit 2024-04-23 07:59:49 +00:00
jorgep added 1 commit 2024-04-23 09:15:44 +00:00
jorgep added 2 commits 2024-04-23 10:06:42 +00:00
jorgep added 2 commits 2024-04-23 10:40:52 +00:00
jorgep requested review from alexm 2024-04-23 10:49:33 +00:00
jorgep reviewed 2024-04-23 10:51:15 +00:00
@ -0,0 +12,4 @@
const props = defineProps({
dataKey: { type: String, required: true },
baseUrl: { type: String, default: undefined },
customUrl: { type: String, default: undefined },
Author
Member

Habilita la opción de usasr una url diferente, en el caso de worker se usa un scope: "summary"

Habilita la opción de usasr una url diferente, en el caso de worker se usa un scope: "summary"
alexm approved these changes 2024-04-24 05:51:34 +00:00
jorgep added 1 commit 2024-04-24 06:55:02 +00:00
jorgep merged commit 77798cbae4 into dev 2024-04-24 06:57:38 +00:00
jorgep deleted branch 6480-improveCard 2024-04-24 06:57:39 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#271
No description provided.