verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 58 Releases Wiki Activity

#6992 add URL params #273

Merged
jorgep merged 6 commits from 6992-addQueryParamsUrl into dev 2024-04-10 06:45:15 +00:00
Conversation 0 Commits 6 Files Changed 6 +58 -20
jorgep commented 2024-04-08 09:35:04 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-04-08 13:21:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8de3ea16a6 fix: refs #6992 add queryParams
jorgep added 1 commit 2024-04-08 14:44:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
16548dadef feat: refs #6992 add test
jorgep reviewed 2024-04-08 14:45:44 +00:00
test/vitest/__tests__/composables/useArrayData.spec.js Outdated
@ -0,0 +11,4 @@
writable: true,
value: 'localhost:9000/invoice-in/list',
});
window.history.pushState = (data, title, url) => (window.location.href = url);
jorgep commented 2024-04-08 14:45:44 +00:00
Author
Member
Copy Link

No sé porque vitest no reconoce esta función, tampoco reconoce la clase URL, he tenido que simular el comportamiento.

No sé porque vitest no reconoce esta función, tampoco reconoce la clase URL, he tenido que simular el comportamiento.
jsegarra commented 2024-04-09 05:06:28 +00:00
Member
Copy Link

hablas de la función de pushState?

hablas de la función de pushState?
jorgep commented 2024-04-09 08:02:25 +00:00
Author
Member
Copy Link

sí

sí
jsegarra commented 2024-04-09 10:14:23 +00:00
Member
Copy Link

Poner comentario indicando que se está mockeando el método para usar dentro de useArrayData e igual para class URL

Poner comentario indicando que se está mockeando el método para usar dentro de useArrayData e igual para class URL
jorgep marked this conversation as resolved
jorgep reviewed 2024-04-08 14:47:17 +00:00
src/composables/useArrayData.js Outdated
@ -188,11 +188,15 @@ export function useArrayData(key, userOptions) {
if (store.userParams && Object.keys(store.userParams).length !== 0)
query.params = JSON.stringify(store.userParams);
if (router)
jorgep commented 2024-04-08 14:47:17 +00:00
Author
Member
Copy Link

Esto redirige, por lo que no es lo más correcto. Alex y Juan me dan el ok.

Esto redirige, por lo que no es lo más correcto. Alex y Juan me dan el ok.
jorgep added the
CR / Tests passed
 label 2024-04-08 14:47:39 +00:00
jorgep requested review from jsegarra 2024-04-08 14:47:46 +00:00
jsegarra requested changes 2024-04-09 05:04:08 +00:00
Dismissed
src/composables/useArrayData.js Outdated
@ -196,0 +195,4 @@
const params = new URLSearchParams();
for (const param in query) params.append(param, query[param]);
url.hash = currentRoute + '?' + params.toString();
jsegarra commented 2024-04-09 05:04:04 +00:00
Member
Copy Link

porque no usas currentHash?
Idem para la siguiente linea

porque no usas currentHash? Idem para la siguiente linea
jorgep commented 2024-04-09 08:09:02 +00:00
Author
Member
Copy Link

Porque currentRoute es solo la ruta . Ej. currentRoute = #/claim/list y currentHash = #/claim/list?order=priority+ASC%2Ccreated+DESC&limit=10&params=%7B%22clientName%22%3A%22br%22%7D . CurrentHash es la ruta con los parámetros actuales.

Porque currentRoute es solo la ruta . Ej. currentRoute = #/claim/list y currentHash = #/claim/list?order=priority+ASC%2Ccreated+DESC&limit=10&params=%7B%22clientName%22%3A%22br%22%7D . CurrentHash es la ruta con los parámetros actuales.
jsegarra marked this conversation as resolved
jsegarra requested changes 2024-04-09 05:52:39 +00:00
Dismissed
src/composables/useArrayData.js Outdated
@ -106,3 +106,3 @@
} else {
store.data = response.data;
if (!document.querySelectorAll('[role="dialog"]'))
if (!document.querySelectorAll('[role="dialog"]').length)
jsegarra commented 2024-04-09 05:51:31 +00:00
Member
Copy Link

Mmm, esa linea lleva ahi desde el 8/2/24...a ti te ha funcionado?Porque quizás habría que darle una vuelta, queryselectorAll siempre devolverá un array.
a lo mejor hacer length > 0
Así como curiosidad, GPT me ha dicho que use esta sentencia:
window.Quasar?.dialog?.manager?.__showing?.length > 0 pero no lo tengo claro

Mmm, esa linea lleva ahi desde el 8/2/24...a ti te ha funcionado?Porque quizás habría que darle una vuelta, queryselectorAll siempre devolverá un array. a lo mejor hacer length > 0 Así como curiosidad, GPT me ha dicho que use esta sentencia: ` window.Quasar?.dialog?.manager?.__showing?.length > 0` pero no lo tengo claro
jorgep commented 2024-04-09 08:15:11 +00:00
Author
Member
Copy Link

Sí, la línea funciona. Hacer !array.length es lo mismo que !array.length>0 . he probado eso y no parece existir en el navegador

Sí, la línea funciona. Hacer !array.length es lo mismo que !array.length>0 . he probado eso y no parece existir en el navegador
❤️ 1
jsegarra marked this conversation as resolved
jsegarra added spent time 2024-04-09 06:02:01 +00:00
1 day 6 hours
jorgep added 1 commit 2024-04-09 08:01:36 +00:00
jorgep added 1 commit 2024-04-09 08:15:37 +00:00
jorgep requested review from jsegarra 2024-04-09 08:18:35 +00:00
jsegarra reviewed 2024-04-09 09:58:13 +00:00
src/composables/useArrayData.js Outdated
@ -105,7 +105,7 @@ export function useArrayData(key, userOptions) {
for (const row of response.data) store.data.push(row);
jsegarra commented 2024-04-09 09:58:13 +00:00
Member
Copy Link

Se que no lo has modificado, pero puedes eliminar el warning de la línea 18?

Se que no lo has modificado, pero puedes eliminar el warning de la línea 18?
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-04-09 13:14:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6349a3e790 feat: refs #6992 comments
jsegarra approved these changes 2024-04-09 13:15:36 +00:00
Dismissed
jorgep added 1 commit 2024-04-09 13:18:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
83bf8183f0 fix: refs #6992 warning console & formModel hook
jorgep dismissed jsegarra’s review 2024-04-09 13:18:49 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep reviewed 2024-04-09 13:19:15 +00:00
src/components/common/VnCurrency.vue
@ -6,3 +6,3 @@
const props = defineProps({
modelValue: { type: String, default: '' },
modelValue: { type: [String, Number], default: '' },
jorgep commented 2024-04-09 13:19:15 +00:00
Author
Member
Copy Link

Soluciona warning de consola

Soluciona warning de consola
👍 1
jorgep reviewed 2024-04-09 13:19:40 +00:00
src/components/FormModel.vue
@ -111,3 +104,1 @@
promise: () => next(),
},
});
if (hasChanges.value)
jorgep commented 2024-04-09 13:19:40 +00:00
Author
Member
Copy Link

Arregla el funcionamiento.

Arregla el funcionamiento.
👍 1
jorgep requested review from jsegarra 2024-04-09 13:22:00 +00:00
jsegarra approved these changes 2024-04-10 05:42:57 +00:00
jorgep merged commit a153146f82 into dev 2024-04-10 06:45:15 +00:00
jorgep deleted branch 6992-addQueryParamsUrl 2024-04-10 06:45:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Total Time Spent: 1 day 6 hours
jsegarra
1 day 6 hours
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#273
No description provided.
Delete Branch "6992-addQueryParamsUrl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?