verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 78 Releases Wiki Activity

#6992 add URL params #273

Merged
jorgep merged 6 commits from 6992-addQueryParamsUrl into dev 2024-04-10 06:45:15 +00:00
Conversation 0 Commits 6 Files Changed 6 +28 -1
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 16548dadef - Show all commits

2
src/composables/useArrayData.js
View File

@ -196,7 +196,7 @@ export function useArrayData(key, userOptions) {
for (const param in query) params.append(param, query[param]);
url.hash = currentRoute + '?' + params.toString();
jsegarra marked this conversation as resolved Outdated
jsegarra commented 2024-04-09 05:04:04 +00:00
Outdated
Review
Copy Link

porque no usas currentHash?
Idem para la siguiente linea

porque no usas currentHash? Idem para la siguiente linea
jorgep commented 2024-04-09 08:09:02 +00:00
Outdated
Review
Copy Link

Porque currentRoute es solo la ruta . Ej. currentRoute = #/claim/list y currentHash = #/claim/list?order=priority+ASC%2Ccreated+DESC&limit=10&params=%7B%22clientName%22%3A%22br%22%7D . CurrentHash es la ruta con los parámetros actuales.

Porque currentRoute es solo la ruta . Ej. currentRoute = #/claim/list y currentHash = #/claim/list?order=priority+ASC%2Ccreated+DESC&limit=10&params=%7B%22clientName%22%3A%22br%22%7D . CurrentHash es la ruta con los parámetros actuales.
window.history.pushState({}, '', url);
window.history.pushState({}, '', url.hash);
}
const totalRows = computed(() => (store.data && store.data.length) || 0);

27
test/vitest/__tests__/composables/useArrayData.spec.js Normal file
View File

@ -0,0 +1,27 @@
import { describe, expect, it, beforeAll } from 'vitest';
import { axios } from 'app/test/vitest/helper';
import { useArrayData } from 'composables/useArrayData';
describe('useArrayData', () => {
let arrayData;
beforeAll(() => {
axios.get.mockResolvedValue({ data: [] });
arrayData = useArrayData('InvoiceIn', { url: 'invoice-in/list' });
Object.defineProperty(window.location, 'href', {
writable: true,
value: 'localhost:9000/invoice-in/list',
});
window.history.pushState = (data, title, url) => (window.location.href = url);
jorgep marked this conversation as resolved Outdated
jorgep commented 2024-04-08 14:45:44 +00:00
Outdated
Review
Copy Link

No sé porque vitest no reconoce esta función, tampoco reconoce la clase URL, he tenido que simular el comportamiento.

No sé porque vitest no reconoce esta función, tampoco reconoce la clase URL, he tenido que simular el comportamiento.
jsegarra commented 2024-04-09 05:06:28 +00:00
Outdated
Review
Copy Link

hablas de la función de pushState?

hablas de la función de pushState?
jorgep commented 2024-04-09 08:02:25 +00:00
Outdated
Review
Copy Link

sí

sí
jsegarra commented 2024-04-09 10:14:23 +00:00
Outdated
Review
Copy Link

Poner comentario indicando que se está mockeando el método para usar dentro de useArrayData e igual para class URL

Poner comentario indicando que se está mockeando el método para usar dentro de useArrayData e igual para class URL
global.URL = class URL {
constructor(url) {
this.hash = url.split('localhost:9000/')[1];
}
};
});
it('should add the params to the url', async () => {
arrayData.store.userParams = { supplierFk: 2 };
arrayData.updateStateParams();
expect(window.location.href).contain('params=%7B%22supplierFk%22%3A2%7D');
});
});