verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

refactor: refs #6973 updated label and updated cypress test #275

Merged
jon merged 3 commits from 6973-UpdateVnLocationLabel into dev 2024-04-09 06:48:49 +00:00
Conversation 0 Commits 3 Files Changed 4 +42 -20
jon commented 2024-04-09 05:49:26 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-04-09 05:49:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3bededcd94 refactor: refs #6973 updated label and updated cypress test
jon requested review from alexm 2024-04-09 05:50:22 +00:00
alexm requested changes 2024-04-09 06:36:34 +00:00
Dismissed
src/components/CreateNewPostcodeForm.vue Outdated
@ -33,0 +35,4 @@
const townObject = townsLocationOptions.value.find(
({id}) => id === formData.townFk
);
newPostcode.town = townObject ? townObject.name : undefined;
alexm commented 2024-04-09 06:36:11 +00:00
Member
Copy Link

Simplificar a:
newPostcode.town = townObject?.name

Y los otros ternarios que hay

Simplificar a: `newPostcode.town = townObject?.name` Y los otros ternarios que hay
jon marked this conversation as resolved
jon added 1 commit 2024-04-09 06:41:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b7788512bc refactor: refs #6973 fix requested changes
jon requested review from alexm 2024-04-09 06:42:17 +00:00
alexm approved these changes 2024-04-09 06:43:31 +00:00
jon added 1 commit 2024-04-09 06:48:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f988923b4b Merge branch 'dev' into 6973-UpdateVnLocationLabel
jon merged commit f1c67a9775 into dev 2024-04-09 06:48:49 +00:00
jon deleted branch 6973-UpdateVnLocationLabel 2024-04-09 06:48:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#275
No description provided.
Delete Branch "6973-UpdateVnLocationLabel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?