verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

refs #6336 feat(claim): improvements #288

Merged
alexm merged 5 commits from 6336-claim_changes_v3 into dev 2024-04-19 09:20:56 +00:00
Conversation 1 Commits 5 Files Changed 11 +288 -338
alexm commented 2024-04-15 06:40:40 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2024-04-15 06:40:40 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4efe09722f refs #6336 feat(claim): improvements
alexm added 1 commit 2024-04-15 10:28:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f176312163 feat(VnNotes): refs #6336 better design
alexm added 1 commit 2024-04-17 08:52:33 +00:00
alexm added 1 commit 2024-04-17 08:57:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
52a0be449d feat: refs #6336 redesign
alexm reviewed 2024-04-17 08:58:47 +00:00
src/pages/Worker/Card/WorkerNotes.vue Outdated
@ -29,4 +29,2 @@
<template>
<VnNotes
style="overflow-y: auto"
alexm commented 2024-04-17 08:58:47 +00:00
Author
Member
Copy Link

No hace falta

No hace falta
alexm reviewed 2024-04-17 08:59:01 +00:00
src/pages/Claim/Card/ClaimSummary.vue
@ -224,3 +224,2 @@
<VnLv
:label="t('claim.summary.pickup')"
:value="t(`claim.summary.${claim.pickup}`)"
:label="t('claim.basicData.pickup')"
alexm commented 2024-04-17 08:59:01 +00:00
Author
Member
Copy Link

estaban mal

estaban mal
alexm reviewed 2024-04-17 08:59:06 +00:00
src/pages/Claim/Card/ClaimSummary.vue
@ -280,6 +280,48 @@ function openDialog(dmsId) {
</template>
</QTable>
</QCard>
<QCard class="vn-two" v-if="claimDms.length > 0">
alexm commented 2024-04-17 08:59:06 +00:00
Author
Member
Copy Link

Movido

Movido
alexm reviewed 2024-04-17 08:59:14 +00:00
src/pages/Claim/Card/ClaimLinesImport.vue Outdated
@ -148,33 +155,6 @@ function cancel() {
}
</style>
<style lang="scss">
alexm commented 2024-04-17 08:59:14 +00:00
Author
Member
Copy Link

No hacian falta

No hacian falta
alexm requested review from jsegarra 2024-04-17 09:00:57 +00:00
alexm changed title from WIP: refs #6336 feat(claim): improvements to refs #6336 feat(claim): improvements 2024-04-17 09:01:00 +00:00
alexm commented 2024-04-17 09:02:03 +00:00
Author
Member
Copy Link

He puesto comentarios pq parece que he borrado y añadido mucho código pero realmente hay archivos que solo he movido líneas

He puesto comentarios pq parece que he borrado y añadido mucho código pero realmente hay archivos que solo he movido líneas
jsegarra reviewed 2024-04-18 12:52:22 +00:00
src/pages/Claim/Card/ClaimLines.vue
@ -339,3 +311,4 @@
</CrudModel>
</div>
<QPageSticky position="bottom-right" :offset="[25, 25]">
jsegarra commented 2024-04-18 12:52:22 +00:00
Member
Copy Link

Propuesta: Añadir tooltip al boton

Propuesta: Añadir tooltip al boton
alexm marked this conversation as resolved
jsegarra reviewed 2024-04-18 12:53:16 +00:00
src/pages/Claim/Card/ClaimLinesImport.vue
@ -130,3 +136,4 @@
</QTable>
<QSeparator />
<QCardActions align="right">
<QBtn :label="t('globals.cancel')" color="primary" flat @click="cancel" />
jsegarra commented 2024-04-18 12:53:16 +00:00
Member
Copy Link

Propuesta: Desactivar el botón si no hay registros seleccionados

Propuesta: Desactivar el botón si no hay registros seleccionados
alexm marked this conversation as resolved
jsegarra requested changes 2024-04-18 13:23:55 +00:00
Dismissed
src/components/CrudModel.vue
@ -26,1 +26,4 @@
},
limit: {
type: Number,
default: 20,
jsegarra commented 2024-04-18 13:23:53 +00:00
Member
Copy Link

20 por algun motivo?
Quiero decir, tenemos 2 ocurrencias de prop a 10 y otras 2 a 20
No es significativo, no?

20 por algun motivo? Quiero decir, tenemos 2 ocurrencias de prop a 10 y otras 2 a 20 No es significativo, no?
alexm marked this conversation as resolved
src/pages/Claim/Card/ClaimLines.vue
@ -272,0 +260,4 @@
</QItemLabel>
</QItemSection>
<QItemSection side>
<template v-if="column.name === 'claimed'">
jsegarra commented 2024-04-18 12:55:35 +00:00
Member
Copy Link

Aqui estamos usando un estilo diferente que es habilitar el input en la tabla en vez del popup.

Entiendo que maná sea diferente porque tiene complejidad

Aqui estamos usando un estilo diferente que es habilitar el input en la tabla en vez del popup. Entiendo que maná sea diferente porque tiene complejidad
alexm commented 2024-04-19 07:32:37 +00:00
Author
Member
Copy Link

Eso ya estaba asi, que es como esta en salix

Eso ya estaba asi, que es como esta en salix
alexm marked this conversation as resolved
src/pages/Claim/Card/ClaimLinesImport.vue
@ -127,3 +127,3 @@
square
flat
/>
>
jsegarra commented 2024-04-18 12:56:21 +00:00
Member
Copy Link

Se que no aplica pero al darle a confirmar, el texto del alert está en inglés

Se que no aplica pero al darle a confirmar, el texto del alert está en inglés
alexm commented 2024-04-19 07:34:15 +00:00
Author
Member
Copy Link

Esta ya con la traduccion:
:label="t('globals.confirm')"

Esta ya con la traduccion: `:label="t('globals.confirm')"`
alexm marked this conversation as resolved
alexm added 1 commit 2024-04-19 07:36:16 +00:00
alexm requested review from jsegarra 2024-04-19 07:36:36 +00:00
jsegarra approved these changes 2024-04-19 07:40:06 +00:00
alexm merged commit dc4de8de7f into dev 2024-04-19 09:20:56 +00:00
alexm deleted branch 6336-claim_changes_v3 2024-04-19 09:20:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#288
No description provided.
Delete Branch "6336-claim_changes_v3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?