Item Fixed prices #307
No reviewers
Labels
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: verdnatura/salix-front#307
Loading…
Reference in New Issue
No description provided.
Delete Branch ":feature/FixedPrices"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
https://redmine.verdnatura.es/issues/6534
WIP: feature/FixedPricesto Item Fixed prices@ -0,0 +94,4 @@
const columns = computed(() => [
{
label: t('item.fixedPrice.itemId'),
Propuesta, podemos definir un objeto configuración default y así reducir líneas?
Estructuras en común entre columnas definidas y reutilizadas
Commit:
e11625e05f
@ -0,0 +317,4 @@
const daysInWeek = 7;
const nextWeek = new Date(today.getTime() + daysInWeek * millisecsInDay);
fixedPricesOriginalData.value.push({
Mismo objeto
Cambiado
Commit:
dce48b536d
@ -0,0 +333,4 @@
const lastItemCopy = JSON.parse(
JSON.stringify(fixedPrices.value[fixedPrices.value.length - 1])
);
const { id, ...restOfData } = lastItemCopy;
RestOfData la propongo cambiar por rest o restOfitem
Cambiado
Commit:
1398a146ff
@ -0,0 +386,4 @@
date.setHours(0, 0, 0, 0);
const timeDifference = today - date;
if (timeDifference > 0) return 'warning';
Is bigger e is lower es lo mismo menos la comparación
Código duplicado
Si, lo había copiado exactamente igual que como estaba en salix, pero bueno le hice un refactor.
Commit:
2105d7870b
Faltaban estos cambios: https://redmine.verdnatura.es/issues/7260 aprobamos PR para no frenar la migración
Solucionamos nosotros.
Solo faltaria arreglar conflictos
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings