warmFix_hasMoreData #308

Merged
jorgep merged 10 commits from warmFix_hasMoreData into dev 2024-04-23 07:12:55 +00:00
Member
No description provided.
alexm added 2 commits 2024-04-19 12:48:34 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ae2737673d
fix: hasMoreData
alexm requested review from jorgep 2024-04-19 12:50:39 +00:00
jorgep approved these changes 2024-04-19 12:52:30 +00:00
Dismissed
jorgep added 1 commit 2024-04-19 14:21:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4f5c8ef0f6
fix: tests
jorgep dismissed jorgep’s review 2024-04-19 14:21:21 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep requested review from jsegarra 2024-04-19 14:21:44 +00:00
jsegarra approved these changes 2024-04-19 15:32:57 +00:00
Dismissed
Member

Y el porque de esta por?
Por el código que he visto deshace lo que hice del error de listado de proveedores
En que parte falla? @alexm @jorgep

Y el porque de esta por? Por el código que he visto deshace lo que hice del error de listado de proveedores En que parte falla? @alexm @jorgep
Member

Sin el .value en VnPagiante el scroll del listado de proveedores falla

Sin el .value en VnPagiante el scroll del listado de proveedores falla
jorgep added 1 commit 2024-04-22 07:04:18 +00:00
jorgep added 1 commit 2024-04-22 10:59:22 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
80844e7869
fix: hasMoreData
jorgep dismissed jsegarra’s review 2024-04-22 10:59:22 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep reviewed 2024-04-22 10:59:39 +00:00
@ -79,3 +79,3 @@
});
const hasMoreData = ref();
const store = arrayData.store;
const hasMoreData = arrayData.hasMoreData;
Member

copia de la propiedad computed

copia de la propiedad computed
jorgep reviewed 2024-04-22 11:01:27 +00:00
@ -189,3 +186,3 @@
:offset="offset"
:disable="disableInfiniteScroll || !arrayData.hasMoreData"
class="full-width"
:disable="disableInfiniteScroll || !hasMoreData"
Member

Al hacer una copia de la propiedad computed dentro del componente, se puede usar con normalidad la propiedad. Si se quiere hacer arrayData.hasMoreData , hay que añadir .value Si no, no funciona y es muy lioso porque de normal no se hace .value dentro del template.

Al hacer una copia de la propiedad computed dentro del componente, se puede usar con normalidad la propiedad. Si se quiere hacer arrayData.hasMoreData , hay que añadir *.value* Si no, no funciona y es muy lioso porque de normal no se hace .value dentro del template.
jorgep reviewed 2024-04-22 11:01:40 +00:00
jorgep reviewed 2024-04-22 11:01:59 +00:00
@ -98,3 +98,2 @@
const { limit } = filter;
hasMoreData.value = limit && response.data.length >= limit;
store.hasMoreData = hasMoreData.value;
arrayDataStore.hasMoreData = limit && response.data.length >= limit;
Member

Actualiza la prop.

Actualiza la prop.
jorgep added 1 commit 2024-04-22 11:23:15 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
1f391dc49b
fix: skip
jorgep reviewed 2024-04-22 11:24:26 +00:00
@ -22,6 +20,7 @@ export function useArrayData(key, userOptions) {
onMounted(() => {
setOptions();
store.skip = 0;
Member

Al cambiar de página se seguía manteniendo el filtro aplicado. Con esto se setea a cero y cuando lo vuelves a montar se cargan los registros desde el principio.

Al cambiar de página se seguía manteniendo el filtro aplicado. Con esto se setea a cero y cuando lo vuelves a montar se cargan los registros desde el principio.
alexm added 1 commit 2024-04-22 13:01:30 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
72deeab2ef
Merge branch 'dev' into warmFix_hasMoreData
jsegarra approved these changes 2024-04-22 13:15:04 +00:00
Dismissed
jsegarra added 1 commit 2024-04-22 13:19:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
13a46be85b
fix: tests
jsegarra dismissed jsegarra’s review 2024-04-22 13:19:09 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from jsegarra 2024-04-22 13:20:10 +00:00
jsegarra approved these changes 2024-04-22 13:20:47 +00:00
Dismissed
jsegarra added the
bug
CR / Tests passed
labels 2024-04-22 13:20:58 +00:00
jorgep added 1 commit 2024-04-22 14:41:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3abc504158
fix: unit test
jorgep dismissed jsegarra’s review 2024-04-22 14:41:45 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep reviewed 2024-04-22 14:43:57 +00:00
@ -98,3 +94,2 @@
const { limit } = filter;
hasMoreData.value = limit && response.data.length >= limit;
store.hasMoreData = hasMoreData.value;
store.hasMoreData = limit && response.data.length >= limit;
Member

Lo he puesto así porque esta propiedad la queremos a nivel de store (ej. workerList), además estaba resultando muy difícil mockear una propiedad computed .

Lo he puesto así porque esta propiedad la queremos a nivel de store (ej. workerList), además estaba resultando muy difícil mockear una propiedad computed .
jorgep requested review from jsegarra 2024-04-22 15:16:48 +00:00
jorgep added 1 commit 2024-04-23 06:45:47 +00:00
jsegarra approved these changes 2024-04-23 06:49:36 +00:00
jorgep merged commit 5f05ab93df into dev 2024-04-23 07:12:55 +00:00
jorgep deleted branch warmFix_hasMoreData 2024-04-23 07:12:55 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#308
No description provided.