verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 62 Releases Wiki Activity

fixes #4801 Summary del módulo tickets #31

Merged
joan merged 4 commits from 4801-ticket-summary into dev 2022-12-13 11:54:17 +00:00
Conversation 0 Commits 4 Files Changed 11 +761 -38
alexandre commented 2022-11-28 08:15:20 +00:00
Contributor
Copy Link
No description provided.
alexandre added 2 commits 2022-11-28 08:15:21 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
04693529d7 refs #4801 working on fetched tags
gitea/salix-front/pipeline/head This commit looks good Details
7ee8dbf2d6 refs #4801 fetched tags added
alexandre requested review from joan 2022-11-28 08:16:47 +00:00
joan requested changes 2022-11-30 10:59:42 +00:00
src/filters/zeroFill.js Outdated
@ -0,0 +1,4 @@
export default function (value, pad) {
joan commented 2022-11-29 13:47:50 +00:00
Contributor
Copy Link

Esta funcionalidad la depracaría. Es un formato antiguo y puede dar lugar a problemas en el futuro.

Esta funcionalidad la depracaría. Es un formato antiguo y puede dar lugar a problemas en el futuro.
alexandre marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue
@ -0,0 +1,535 @@
<script setup>
joan commented 2022-11-30 10:51:52 +00:00
Contributor
Copy Link

La vista previa es accesible desde el listado de tickets (TicketList)

La vista previa es accesible desde el listado de tickets (TicketList)
alexandre marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue
@ -0,0 +33,4 @@
const { data } = await axios.get(`Tickets/${entityId.value}/summary`);
if (data) {
ticket.value = data;
console.log(ticket.value);
joan commented 2022-11-29 13:55:39 +00:00
Contributor
Copy Link

Quitar Console.log()

Quitar Console.log()
alexandre marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue
@ -0,0 +89,4 @@
Ticket #{{ ticket.id }} - {{ ticket.client.name }} ({{ ticket.client.id }}) -
{{ ticket.nickname }}
</span>
<q-btn-dropdown
joan commented 2022-11-30 10:55:01 +00:00
Contributor
Copy Link

En vez de ponerlo de color negro, quizás probaría con otro color de la gama "orange", de la paleta de colores, quizás un color más claro y apagado que el encabezado:
https://quasar.dev/style/color-palette

En vez de ponerlo de color negro, quizás probaría con otro color de la gama "orange", de la paleta de colores, quizás un color más claro y apagado que el encabezado: https://quasar.dev/style/color-palette
alexandre marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -0,0 +380,4 @@
</q-table>
</div>
<div class="col" v-if="ticket.services.length > 0">
<q-item-label header class="text-h6">
joan commented 2022-11-30 10:59:39 +00:00
Contributor
Copy Link

Seguir la misma estructura de encabezado de apartados, similar al de CustomerSummary, con el icono en el lado derecho.

Seguir la misma estructura de encabezado de apartados, similar al de CustomerSummary, con el icono en el lado derecho.
alexandre marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -0,0 +384,4 @@
{{ t('ticket.summary.services') }}
<q-tooltip>{{ t('ticket.summary.goTo') }}</q-tooltip>
</q-item-label>
<q-table :rows="ticket.services">
joan commented 2022-11-30 10:58:30 +00:00
Contributor
Copy Link

Quitar fondo de la tabla

Quitar fondo de la tabla
alexandre marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -0,0 +412,4 @@
{{ t('ticket.summary.request') }}
<q-tooltip>{{ t('ticket.summary.goTo') }}</q-tooltip>
</q-item-label>
<q-table :rows="ticket.requests">
joan commented 2022-11-30 10:56:04 +00:00
Contributor
Copy Link

Quitar el fondo de la tabla, ahora mismo es un card dentro de otro card.

Quitar el fondo de la tabla, ahora mismo es un card dentro de otro card.
alexandre marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -0,0 +447,4 @@
</q-card>
</div>
</template>
<style lang="scss" scoped>
joan commented 2022-11-30 10:52:48 +00:00
Contributor
Copy Link

Reducir el tamaño máximo de la vista previa y comprobar que se vea correctamente desde el listado de tickets. Ejemplo ClientSummary, tiene max-width de 1200px

Reducir el tamaño máximo de la vista previa y comprobar que se vea correctamente desde el listado de tickets. Ejemplo ClientSummary, tiene max-width de 1200px
alexandre marked this conversation as resolved
alexandre added 1 commit 2022-11-30 13:35:45 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
e35c11d714 corrections
alexandre requested review from joan 2022-11-30 13:36:51 +00:00
joan added 1 commit 2022-12-13 11:45:45 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
c949adfd83 Use dialog plugin
joan approved these changes 2022-12-13 11:52:03 +00:00
joan approved these changes 2022-12-13 11:53:44 +00:00
joan merged commit eb8782311a into dev 2022-12-13 11:54:17 +00:00
joan deleted branch 4801-ticket-summary 2022-12-13 11:54:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#31
No description provided.
Delete Branch "4801-ticket-summary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?