verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

Item diary #339

Merged
jsegarra merged 6 commits from :feature/ItemDiary into dev 2024-05-02 08:29:18 +00:00
Conversation 0 Commits 6 Files Changed 4 +306 -4
hyervoni commented 2024-04-29 20:40:30 +00:00
Contributor
Copy Link
No description provided.
hyervoni added 3 commits 2024-04-29 20:40:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ccac3a54f9 move translations
jsegarra requested review from alexm 2024-04-30 05:58:53 +00:00
jsegarra requested review from jsegarra 2024-04-30 05:58:53 +00:00
jsegarra requested changes 2024-04-30 06:26:18 +00:00
Dismissed
src/pages/Item/Card/ItemDiary.vue
@ -2,0 +137,4 @@
/>
<FetchData
url="Warehouses"
:filter="{ fields: ['id', 'name'], order: 'name ASC' }"
jsegarra commented 2024-04-30 06:26:15 +00:00
Member
Copy Link

La petición solicita solo los campos id y name, cosa que no ocurre en Salix.

Entiendo la propuesta, ya que solo se va a usar en el vnselect y nos hace falta para option-label y option-value

Porque no se usa en otro sitio, no @wbuezas?

Lo ves correcto, @alexm ?

La petición solicita solo los campos id y name, cosa que no ocurre en Salix. Entiendo la propuesta, ya que solo se va a usar en el vnselect y nos hace falta para option-label y option-value Porque no se usa en otro sitio, no @wbuezas? Lo ves correcto, @alexm ?
alexm commented 2024-05-02 08:02:42 +00:00
Member
Copy Link

Lo veo bien

Lo veo bien
jsegarra marked this conversation as resolved
jsegarra requested changes 2024-05-01 11:32:43 +00:00
Dismissed
src/router/modules/item.js Outdated
@ -145,3 +145,3 @@
meta: {
title: 'log',
icon: 'history',
icon: 'vn:History',
jsegarra commented 2024-05-01 11:32:41 +00:00
Member
Copy Link

He corregido también el orden

He corregido también el orden
jsegarra approved these changes 2024-05-02 08:03:49 +00:00
Dismissed
jsegarra added 1 commit 2024-05-02 08:05:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
94fc856bea Merge branch 'dev' into feature/ItemDiary
jsegarra dismissed jsegarra’s review 2024-05-02 08:05:18 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2024-05-02 08:13:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
494f0be44a Merge branch 'dev' into feature/ItemDiary
alexm approved these changes 2024-05-02 08:15:31 +00:00
jsegarra added 1 commit 2024-05-02 08:28:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e4f787f2fa Merge branch 'dev' into feature/ItemDiary
jsegarra merged commit c81e20e22e into dev 2024-05-02 08:29:18 +00:00
jsegarra deleted branch feature/ItemDiary 2024-05-02 08:29:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#339
No description provided.
Delete Branch ":feature/ItemDiary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?