verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

Item Basic data #346

Merged
jsegarra merged 7 commits from :feature/ItemBasicData into dev 2024-05-07 10:47:01 +00:00
Conversation 3 Commits 7 Files Changed 7 +356 -5
hyervoni commented 2024-05-03 11:59:28 +00:00
Contributor
Copy Link
No description provided.
hyervoni added 3 commits 2024-05-03 11:59:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d15a92ce7d Resolve conflicts
hyervoni requested review from alexm 2024-05-03 11:59:39 +00:00
hyervoni requested review from jsegarra 2024-05-03 11:59:40 +00:00
jsegarra requested changes 2024-05-03 13:16:11 +00:00
Dismissed
src/pages/Item/Card/ItemBasicData.vue
@ -2,0 +93,4 @@
</template>
</VnSelect>
<VnInput :label="t('basicData.reference')" v-model="data.comment" />
<VnInput :label="t('basicData.relevancy')" v-model="data.relevancy" />
jsegarra commented 2024-05-03 13:14:03 +00:00
Member
Copy Link

min 0

min 0
src/pages/Item/Card/ItemBasicData.vue
@ -2,0 +96,4 @@
<VnInput :label="t('basicData.relevancy')" v-model="data.relevancy" />
</VnRow>
<VnRow class="row q-gutter-md q-mb-md">
<VnInput :label="t('basicData.stems')" v-model="data.stems" />
jsegarra commented 2024-05-03 13:13:22 +00:00
Member
Copy Link

Añadir min=0

Añadir min=0
src/pages/Item/Card/ItemBasicData.vue
@ -2,0 +99,4 @@
<VnInput :label="t('basicData.stems')" v-model="data.stems" />
<VnInput
:label="t('basicData.multiplier')"
v-model="data.stemMultiplier"
jsegarra commented 2024-05-03 13:13:36 +00:00
Member
Copy Link

Añadir min="0"

Añadir min="0"
src/pages/Item/Card/ItemBasicData.vue
@ -2,0 +167,4 @@
</div>
</VnRow>
<VnRow class="row q-gutter-md q-mb-md">
<VnInput
jsegarra commented 2024-05-03 13:14:46 +00:00
Member
Copy Link

Está puesto min="0", pero no salta la valdiación

Está puesto min="0", pero no salta la valdiación
jsegarra added 1 commit 2024-05-06 05:25:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0f5d06614d feat: VnInput numberValidation
jsegarra commented 2024-05-06 05:28:08 +00:00
Member
Copy Link

He modificado VnInput para que muestre el mensaje cuando haya definido un min

He modificado VnInput para que muestre el mensaje cuando haya definido un min
jsegarra approved these changes 2024-05-06 05:28:14 +00:00
Dismissed
alexm requested changes 2024-05-06 06:33:00 +00:00
Dismissed
alexm left a comment
Member
Copy Link

La validacion de los campos no funciona correctamente (pero si deja guardar)
image

La columna "color" no se muestra:
image

La validacion de los campos no funciona correctamente (pero si deja guardar) ![image](/attachments/199bff36-0b95-4c5d-9094-b215353d6f84) La columna "color" no se muestra: ![image](/attachments/abd8fa28-1051-4d33-bb52-a4cde58678bc)
image.png
11 KiB
image.png
112 KiB
jsegarra added 1 commit 2024-05-06 06:46:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6a81076874 fix: replace inputMin rule
jsegarra dismissed jsegarra’s review 2024-05-06 06:46:26 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2024-05-06 06:54:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
49b6c57ad4 fix: show Color
jsegarra commented 2024-05-06 06:54:27 +00:00
Member
Copy Link

El problema de las validaciones esta corregido
image

El problema de las validaciones esta corregido ![image](/attachments/ee0e8511-a656-49b6-8fc4-877c5811f877)
image.png
19 KiB
jsegarra commented 2024-05-06 06:55:14 +00:00
Member
Copy Link

El problema del FilterItemForm tambien image

@alexm Sin embargo, hay un problema y es que la tabla no tiene scroll . Lo anotamos para mas tarde?

El problema del FilterItemForm tambien ![image](/attachments/19114df3-d033-4d0a-b55b-60ba9f7b88f9) @alexm Sin embargo, hay un problema y es que la tabla no tiene scroll . Lo anotamos para mas tarde?
image.png
54 KiB
jsegarra requested review from alexm 2024-05-06 07:53:57 +00:00
alexm approved these changes 2024-05-07 10:40:49 +00:00
jsegarra added 1 commit 2024-05-07 10:44:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
753b5bf939 Merge branch 'dev' into feature/ItemBasicData
jsegarra merged commit 175746a4a4 into dev 2024-05-07 10:47:01 +00:00
jsegarra deleted branch feature/ItemBasicData 2024-05-07 10:47:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#346
No description provided.
Delete Branch ":feature/ItemBasicData"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?