#6273 create freelance form option #347

Merged
jorgep merged 21 commits from 6273-createFreelanceFormOpt into dev 2024-06-10 13:35:00 +00:00
Member
No description provided.
jorgep added 1 commit 2024-05-03 14:46:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4b4c02c01a
feat: refs #6273 create worker form toggle
jorgep added 1 commit 2024-06-04 07:01:00 +00:00
jorgep added 1 commit 2024-06-04 07:33:55 +00:00
jorgep added 1 commit 2024-06-04 13:19:15 +00:00
jorgep added 1 commit 2024-06-04 15:38:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7e0ceca623
feat: refs #6273 freelance form & vnRadio
jorgep added 1 commit 2024-06-05 15:13:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
382591fb11
fix: refs #6273 set paymethodFk to 0 if it is external
jorgep added 1 commit 2024-06-05 15:29:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
56af348fdd
feat: refs #6273 update changelog
jorgep added 1 commit 2024-06-07 10:15:10 +00:00
jorgep added 1 commit 2024-06-07 10:24:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
213ba4ba52
chore: refs #6273 Add default pay method for internal
jorgep added 1 commit 2024-06-07 12:08:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8d89fc2d90
feat: refs #6273 set payMethod to 0
jorgep added 1 commit 2024-06-07 12:19:14 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
59b85f24ea
fix: refs #6273 console error
jorgep added 1 commit 2024-06-07 12:27:19 +00:00
jorgep added 1 commit 2024-06-07 13:43:33 +00:00
jorgep changed title from WIP: #6273 create freelance form option to #6273 create freelance form option 2024-06-07 14:31:49 +00:00
jorgep added the
CR / Tests passed
label 2024-06-07 14:31:55 +00:00
jorgep requested review from jgallego 2024-06-07 14:32:00 +00:00
jorgep reviewed 2024-06-07 14:32:47 +00:00
@ -19,3 +19,3 @@
() =>
(hasContent.value =
actions.value.childNodes.length + data.value.childNodes.length)
actions.value?.childNodes?.length + data.value?.childNodes?.length)
Author
Member

Arregla un error de consola

Arregla un error de consola
jgallego requested changes 2024-06-10 05:36:52 +00:00
Dismissed
jgallego left a comment
Owner

Prueba la usabilidad con Andres .

Prueba la usabilidad con Andres .
@ -212,2 +194,4 @@
hide-selected
:rules="validate('Worker.payMethodFk')"
:disable="formData.isFreelance"
@update:model-value="(val) => (formData.payMethodFk = val ?? 0)"
Owner

se le pone valor cero?

se le pone valor cero?
Author
Member

Lo he puesto para que no envíe null. Si no el back da error, solo admite 1 tipo de dato.

Lo he puesto para que no envíe null. Si no el back da error, solo admite 1 tipo de dato.
jorgep requested review from jgallego 2024-06-10 06:55:48 +00:00
jorgep added 1 commit 2024-06-10 06:58:15 +00:00
jgallego requested changes 2024-06-10 08:13:19 +00:00
Dismissed
@ -108,0 +78,4 @@
v-model="formData.isFreelance"
:val="true"
:label="`${t('External')}`"
@update:model-value="formData.payMethodFk = 0"
Owner

eliminar valor 0, no se envia esa propiedad si no tiene valor

eliminar valor 0, no se envia esa propiedad si no tiene valor
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-06-10 11:54:05 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d81ce9fe95
feat: refs #6273 add test & improve form
jorgep added 1 commit 2024-06-10 12:04:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5e96ed3bd3
fix: refs #6273 fix arrayData changed
jorgep added 1 commit 2024-06-10 12:17:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5869ad220c
feat: refs #6273 wip: add locale
jorgep added 1 commit 2024-06-10 12:24:34 +00:00
jorgep added 1 commit 2024-06-10 12:42:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
9c72597c2c
fix: refs #6273 tests
jorgep added 1 commit 2024-06-10 13:21:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a64cd6fa73
refactor: refs #6273 update locale
jorgep reviewed 2024-06-10 13:24:54 +00:00
@ -20,3 +20,3 @@
const route = useRoute();
const editDownloadDisabled = ref(false);
const invoiceIn = computed(() => useArrayData().store.data);
const arrayData = useArrayData();
Author
Member

Lanzaba un error debido a un cambio en arrayData. Así se corrige.

Lanzaba un error debido a un cambio en arrayData. Así se corrige.
jorgep reviewed 2024-06-10 13:24:59 +00:00
@ -13,3 +13,3 @@
const invoiceId = +currentRoute.value.params.id;
const arrayData = useArrayData(currentRoute.value.meta.moduleName);
const arrayData = useArrayData();
Author
Member

Lanzaba un error debido a un cambio en arrayData. Así se corrige.

Lanzaba un error debido a un cambio en arrayData. Así se corrige.
jorgep reviewed 2024-06-10 13:25:03 +00:00
@ -28,3 +28,3 @@
const { t } = useI18n();
const { openReport, sendEmail } = usePrintService();
const { store } = useArrayData(currentRoute.value.meta.moduleName);
const arrayData = useArrayData();
Author
Member

Lanzaba un error debido a un cambio en arrayData. Así se corrige.

Lanzaba un error debido a un cambio en arrayData. Así se corrige.
jorgep reviewed 2024-06-10 13:25:07 +00:00
@ -12,3 +12,3 @@
const route = useRoute();
const currency = computed(() => useArrayData().store.data?.currency?.code);
const arrayData = useArrayData();
Author
Member

Lanzaba un error debido a un cambio en arrayData. Así se corrige.

Lanzaba un error debido a un cambio en arrayData. Así se corrige.
jorgep reviewed 2024-06-10 13:25:15 +00:00
@ -17,3 +18,3 @@
const entityId = computed(() => props.id || +route.params.id);
const invoiceIn = computed(() => useArrayData().store.data);
const invoiceIn = computed(() => arrayData.store.data);
Author
Member

Lanzaba un error debido a un cambio en arrayData. Así se corrige.

Lanzaba un error debido a un cambio en arrayData. Así se corrige.
jorgep reviewed 2024-06-10 13:26:02 +00:00
@ -11,3 +11,1 @@
cy.get(workerFieldNames).eq(0).should('have.text', 'jessicajones');
cy.get(workerFieldNames).eq(1).should('have.text', 'brucebanner');
cy.get(workerFieldNames).eq(2).should('have.text', 'charlesxavier');
cy.get(workerFieldNames).eq(2).should('have.text', 'jessicajones');
Author
Member

Al crear 2 trabajadores más en el test anterior, la posición de estos cambia.

Al crear 2 trabajadores más en el test anterior, la posición de estos cambia.
jorgep reviewed 2024-06-10 13:26:22 +00:00
@ -86,6 +86,36 @@ Cypress.Commands.add('selectOption', (selector, option) => {
cy.get('.q-menu .q-item').contains(option).click();
});
Cypress.Commands.add('fillInForm', (obj, form = '.q-form > .q-card') => {
Author
Member

Rellena los campos de un formulario.

Rellena los campos de un formulario.
jorgep requested review from jgallego 2024-06-10 13:26:48 +00:00
jorgep added 1 commit 2024-06-10 13:32:42 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a5b71ecebc
feat: refs #6273 delete prop
jgallego approved these changes 2024-06-10 13:33:23 +00:00
jorgep merged commit 9bcfd5c58a into dev 2024-06-10 13:35:00 +00:00
jorgep deleted branch 6273-createFreelanceFormOpt 2024-06-10 13:35:00 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#347
No description provided.