feat: refs #6739 transferInvoice new checkbox and functionality #352

Merged
jon merged 28 commits from 6739-invoiceOut into dev 2024-06-25 12:46:21 +00:00
Member
No description provided.
jon added 1 commit 2024-05-06 12:50:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5ed2a82194
feat: refs #6739 transferInvoice new checkbox and functionality
jon added 1 commit 2024-05-07 08:35:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7befca94bd
refactor: refs #6739 new confirmation window
jon added 1 commit 2024-05-07 09:27:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
bc1a79ac68
refactor: refs #6739 updated transferInvoice function
jon added 1 commit 2024-05-07 09:36:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
93bd4e0281
Merge branch 'dev' into 6739-invoiceOut
jon requested review from jgallego 2024-05-07 09:37:24 +00:00
jon added 1 commit 2024-05-08 12:54:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
57e1a2cfdb
Merge branch 'dev' into 6739-invoiceOut
jgallego requested review from alexm 2024-05-09 05:54:27 +00:00
jgallego refused to review 2024-05-09 05:54:29 +00:00
alexm requested changes 2024-05-09 05:59:57 +00:00
Dismissed
@ -44,0 +51,4 @@
order: 'id DESC',
limit: 10,
};
const { data } = await axios.get('http://localhost:9000/api/Clients/filter', {
Member

No se debe poner en el código nada referente al entorno (en este caso local). Como esta hecho abajo:
const { data } = await axios.post('InvoiceOuts/transferInvoice', params);
Se debe poner directamente el modulo al que se hace la petición porque axios ya tiene puesto que dependiendo del entorno apunte a (local/dev/test/master)

De todas maneras, para tablas grandes, como es este caso de Client, es mejor usar la propiedad url del componente VnSelect así el propio componente ya se encarga de la paginación

No se debe poner en el código nada referente al entorno (en este caso local). Como esta hecho abajo: ` const { data } = await axios.post('InvoiceOuts/transferInvoice', params);` Se debe poner directamente el modulo al que se hace la petición porque axios ya tiene puesto que dependiendo del entorno apunte a (local/dev/test/master) De todas maneras, para tablas grandes, como es este caso de Client, es mejor usar la propiedad `url` del componente `VnSelect` así el propio componente ya se encarga de la paginación
jon marked this conversation as resolved
@ -44,0 +63,4 @@
}
};
const serializeFilter = (filter) => {
Member

Al usar la propiedad url de VnSelect se evita este código

Al usar la propiedad `url` de `VnSelect` se evita este código
jon marked this conversation as resolved
@ -44,0 +73,4 @@
return serializedFilter;
};
const handleScroll = async () => {
Member

Al usar la propiedad url de VnSelect se evita este código

Al usar la propiedad `url` de `VnSelect` se evita este código
jon marked this conversation as resolved
@ -44,0 +91,4 @@
};
try {
const clientDetails = await axios.get(
Member

Al componente VnSelect si le pides el campo hasToInvoiceByAddress en el fields ya te lo devuelve y no hace falta volver a pedir los datos del cliente

Al componente VnSelect si le pides el campo `hasToInvoiceByAddress` en el fields ya te lo devuelve y no hace falta volver a pedir los datos del cliente
jon marked this conversation as resolved
@ -65,0 +127,4 @@
@on-fetch="
(data) => (
(rectificativeTypeOptions = data),
(transferInvoiceParams.cplusRectificationTypeFk = data[1].id)
Member

Esta parte hacerla como se ha hecho en salix, filtrando por code si se puede y sino por description

Esta parte hacerla como se ha hecho en salix, filtrando por code si se puede y sino por description
jon marked this conversation as resolved
@ -71,0 +138,4 @@
@on-fetch="
(data) => (
(siiTypeInvoiceOutsOptions = data),
(transferInvoiceParams.siiTypeInvoiceOutFk = data[3].id)
Member

Esta parte hacerla como se ha hecho en salix, filtrando por code si se puede y sino por description

Esta parte hacerla como se ha hecho en salix, filtrando por code si se puede y sino por description
jon marked this conversation as resolved
jon added 2 commits 2024-05-10 05:04:10 +00:00
jon added 1 commit 2024-05-10 05:05:34 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
803c74908b
Merge branch 'dev' into 6739-invoiceOut
jon requested review from alexm 2024-05-10 05:06:25 +00:00
jon added 2 commits 2024-05-13 05:14:18 +00:00
jon added 1 commit 2024-05-16 05:21:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
059ec702c9
Merge branch 'dev' into 6739-invoiceOut
jon added 1 commit 2024-05-20 05:13:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a411e1db09
Merge branch 'dev' into 6739-invoiceOut
jon added 2 commits 2024-05-23 13:07:04 +00:00
jon added 1 commit 2024-05-23 13:08:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f0b1919157
refactor: refs #6739 deleted useless const
jon added 1 commit 2024-05-23 13:08:58 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b7fe50ba1d
Merge branch 'dev' into 6739-invoiceOut
alexm approved these changes 2024-05-24 06:13:25 +00:00
Dismissed
alexm requested changes 2024-05-31 07:45:24 +00:00
Dismissed
@ -40,0 +48,4 @@
newClientFk: transferInvoiceParams.newClientFk,
refFk: transferInvoiceParams.refFk,
siiTypeInvoiceOutFk: transferInvoiceParams.siiTypeInvoiceOutFk,
checked: checked.value,
Member

cambiar a makeInvoice

cambiar a makeInvoice
jon marked this conversation as resolved
jon added 3 commits 2024-06-03 08:53:24 +00:00
jon dismissed alexm’s review 2024-06-03 08:53:24 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jon requested review from alexm 2024-06-03 08:54:28 +00:00
alexm added 1 commit 2024-06-10 05:06:45 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
04f92071fb
Merge branch 'dev' into 6739-invoiceOut
jon added 1 commit 2024-06-11 05:19:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
83a4e9c75f
Merge branch 'dev' into 6739-invoiceOut
jon added 2 commits 2024-06-14 09:44:10 +00:00
jon added 1 commit 2024-06-14 09:45:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
21506da779
Merge branch 'dev' into 6739-invoiceOut
jon added 1 commit 2024-06-20 10:14:12 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5be23286d7
Merge branch 'dev' into 6739-invoiceOut
alexm requested changes 2024-06-25 11:36:45 +00:00
Dismissed
@ -45,2 +76,3 @@
const { data } = await axios.post('InvoiceOuts/transferInvoice', params);
notify(t('Transferred invoice'), 'positive');
closeForm();
Member

Y closeForm si lo querias? o no hace falta?

Y closeForm si lo querias? o no hace falta?
@ -45,3 +78,2 @@
notify(t('Transferred invoice'), 'positive');
closeForm();
router.push('InvoiceOutSummary', { id: data.id });
if (data.id) router.push({ name: 'InvoiceOutSummary', params: { id: data.id } });
Member

data.?id
Data puede que sea null

data.?id Data puede que sea null
jon added 3 commits 2024-06-25 12:41:18 +00:00
jon requested review from alexm 2024-06-25 12:42:03 +00:00
alexm approved these changes 2024-06-25 12:45:36 +00:00
jon merged commit 1538e7dc7e into dev 2024-06-25 12:46:21 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#352
No description provided.