#6891 showRightSideFilterPanel #353

Merged
jorgep merged 48 commits from 6891-showRightSideFilterPanel into dev 2024-05-15 13:39:23 +00:00
Member
No description provided.
jorgep added 7 commits 2024-05-06 15:34:23 +00:00
jorgep reviewed 2024-05-07 07:01:34 +00:00
@ -0,0 +1,55 @@
<script setup>
Author
Member

Evitamos el uso repetitivo de esta código. Hay secciones como claimAction que tiene un menú lateral derecho personalizado. Con este componente evitamos duplicar el código.

Evitamos el uso repetitivo de esta código. Hay secciones como claimAction que tiene un menú lateral derecho personalizado. Con este componente evitamos duplicar el código.
jorgep reviewed 2024-05-07 07:02:14 +00:00
@ -67,3 +54,1 @@
<LeftMenu source="card" />
</QScrollArea>
</QDrawer>
<template v-if="stateStore.isHeaderMounted()">
Author
Member

Añadimos botón "hamburguer" para el menú lateral derecho

Añadimos botón "hamburguer" para el menú lateral derecho
jorgep reviewed 2024-05-07 07:03:04 +00:00
@ -5,3 +5,3 @@
import { useRoute } from 'vue-router';
import toDate from 'filters/toDate';
import useRedirect from 'src/composables/useRedirect';
Author
Member

Habilitamos la redirección desde el panel lateral en cualquier sección

Habilitamos la redirección desde el panel lateral en cualquier sección
jorgep reviewed 2024-05-07 07:03:48 +00:00
@ -112,3 +92,1 @@
else if (path.includes(':id')) targetUrl = path.replace(':id', targetId);
await router.push({ path: targetUrl });
navigate(store.data, {
Author
Member

Se usa en VnFilterPanel la misma lógica , por tanto he decidido usar un composable.

Se usa en VnFilterPanel la misma lógica , por tanto he decidido usar un composable.
jorgep reviewed 2024-05-07 07:05:00 +00:00
@ -1,26 +1,6 @@
<script setup>
import { onMounted, watch } from 'vue';
Author
Member

Se estaba haciendo un uso de la lógica antigua . Ahora solo se usa VnCard

Se estaba haciendo un uso de la lógica antigua . Ahora solo se usa VnCard
jorgep reviewed 2024-05-07 07:05:26 +00:00
@ -18,2 +18,2 @@
const { params } = useRoute();
const entityId = computed(() => props.id || params.id);
const route = useRoute();
const entityId = computed(() => props.id || route.params.id);
Author
Member

Params no es reactivo, solo useRoute(), por lo que no actualizaba correctamente el id.

Params no es reactivo, solo useRoute(), por lo que no actualizaba correctamente el id.
jorgep reviewed 2024-05-07 07:05:41 +00:00
@ -15,9 +13,9 @@ const $props = defineProps({
default: 0,
},
});
const { params } = useRoute();
Author
Member

Lo mismo que en AgencyDescriptor.

Lo mismo que en AgencyDescriptor.
jorgep reviewed 2024-05-07 07:07:51 +00:00
@ -0,0 +21,4 @@
if (/\/list|-list/.test(path))
router.push({ path: `/${moduleName}/${targetId}/summary` });
else router.push({ path: path.replace(/:id/, targetId) });
Author
Member

Así redirigimos a la misma sección! 😄 ej. claim/1/basic-data -> claim/2/basic-data

Así redirigimos a la misma sección! 😄 ej. claim/1/basic-data -> claim/2/basic-data
jorgep reviewed 2024-05-07 07:08:35 +00:00
@ -225,3 +204,1 @@
show-if-above
v-if="claim"
>
<Teleport to="#right-panel" v-if="stateStore.isHeaderMounted() && claim">
Author
Member

Añadimos el contenido personalizado al panel lateral.

Añadimos el contenido personalizado al panel lateral.
jorgep added 1 commit 2024-05-07 07:17:30 +00:00
jorgep added 1 commit 2024-05-07 07:37:34 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
48bba65baf
fix: refs #6891 use vnCard searchbar
jorgep added 1 commit 2024-05-07 07:53:28 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
111333a6cf
fix: refs #6891 reactivity & show filter panel
jorgep reviewed 2024-05-07 07:53:46 +00:00
jorgep reviewed 2024-05-07 07:55:22 +00:00
@ -34,1 +32,4 @@
:title="parking?.code"
:subtitle="parking?.id"
:filter="filter"
@on-fetch="(data) => (parking = data)"
Author
Member

Cuando se abre un descriptor hay que obetner los datos así. Estaba fallando la reactividad(no se actualizaba el id correctamente), esto lo corrige.

Cuando se abre un descriptor hay que obetner los datos así. Estaba fallando la reactividad(no se actualizaba el id correctamente), esto lo corrige.
jorgep reviewed 2024-05-07 07:55:28 +00:00
@ -26,3 +29,1 @@
<CardSummary :url="`Parkings/${entityId}`" :filter="filter">
<template #header="{ entity: parking }">{{ parking.code }}</template>
<template #body="{ entity: parking }">
<CardSummary
Author
Member

Cuando se abre un descriptor hay que obetner los datos así. Estaba fallando la reactividad(no se actualizaba el id correctamente), esto lo corrige.

Cuando se abre un descriptor hay que obetner los datos así. Estaba fallando la reactividad(no se actualizaba el id correctamente), esto lo corrige.
jorgep added 2 commits 2024-05-07 08:22:20 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
777ee0895e
feat: refs #6891 route & drop searchbar
jorgep added 1 commit 2024-05-07 09:29:07 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
097e25a0b8
feat: refs #6891 shelving
jorgep added 1 commit 2024-05-07 11:11:01 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
0703de350c
fix: refs #6891 rollback order & route searchbar
jorgep added 1 commit 2024-05-07 11:59:18 +00:00
jorgep added 1 commit 2024-05-07 12:21:38 +00:00
jorgep added 1 commit 2024-05-07 13:17:09 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
014ec60e47
feat: refs #6891 worker & supplier
jorgep added 1 commit 2024-05-07 14:43:12 +00:00
jorgep added 2 commits 2024-05-07 15:18:25 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ff0e290963
feat: refs #6891 ticket
jorgep added 3 commits 2024-05-08 07:15:38 +00:00
jorgep added 1 commit 2024-05-08 09:10:22 +00:00
jorgep added 9 commits 2024-05-08 11:30:16 +00:00
jorgep added 1 commit 2024-05-08 11:32:57 +00:00
jorgep added 1 commit 2024-05-09 06:53:18 +00:00
jorgep added 1 commit 2024-05-13 13:23:59 +00:00
jorgep added 1 commit 2024-05-13 13:41:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
07b91febb6
feat: refs #6891 unit test
jorgep added 1 commit 2024-05-13 13:46:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fdd3c41c96
feat: refs #6891 update changelog
jorgep added 1 commit 2024-05-13 14:01:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a878ad23b9
fix: refs #6891 fix invoiceInform design
jorgep reviewed 2024-05-13 14:03:29 +00:00
@ -182,3 +181,3 @@
>
<template #form="{ data }">
<div class="row q-gutter-md q-mb-md">
<VnRow>
Author
Member

En alguna subida a dev, se ha desajustado el diseño de invoiceInBasicData, lo arreglo rapidamente en esta rama. apunto el tiempo en esta rama: #6942 . Cambiaré los qinput por vninput en la rama correspondiente.

En alguna subida a dev, se ha desajustado el diseño de invoiceInBasicData, lo arreglo rapidamente en esta rama. apunto el tiempo en esta rama: #6942 . Cambiaré los qinput por vninput en la rama correspondiente.
jorgep added 2 commits 2024-05-13 14:46:38 +00:00
jorgep added 1 commit 2024-05-13 15:08:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5b3ee220d4
fix: refs #6891 fix ticketDescriptor test
jorgep added 1 commit 2024-05-13 15:21:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b062474f91
fix: refs #6891 fix invoiceInDueDay test
jorgep added 1 commit 2024-05-14 10:42:24 +00:00
jorgep added 1 commit 2024-05-14 11:00:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
189c3e0218
fix: refs #6891 fix invoiceInVat test
jorgep reviewed 2024-05-14 11:01:11 +00:00
@ -1,7 +1,8 @@
/// <reference types="cypress" />
Author
Member

Arreglar test de e2e

Arreglar test de e2e
jorgep reviewed 2024-05-14 11:01:22 +00:00
@ -1,6 +1,6 @@
/// <reference types="cypress" />
Author
Member

Arreglar test de e2e.

Arreglar test de e2e.
jorgep reviewed 2024-05-14 11:01:34 +00:00
@ -29,7 +29,7 @@ describe('InvoiceInVat', () => {
});
Author
Member

Arreglar test de e2e.

Arreglar test de e2e.
jorgep reviewed 2024-05-14 11:01:41 +00:00
@ -1,6 +1,6 @@
/// <reference types="cypress" />
describe('Ticket descriptor', () => {
const toCloneOpt = '.q-list > :nth-child(5)';
const toCloneOpt = '[role="menu"] .q-list > :nth-child(5)';
Author
Member

Arreglar test de e2e.

Arreglar test de e2e.
jorgep reviewed 2024-05-14 11:01:49 +00:00
@ -2,2 +2,2 @@
const workerId = 1110;
const lockerCode = '200A';
const workerId = 1109;
const lockerCode = '201A';
Author
Member

Arreglar test de e2e.

Arreglar test de e2e.
jorgep reviewed 2024-05-14 11:02:23 +00:00
@ -1,62 +0,0 @@
import { vi, describe, expect, it, beforeAll, afterEach, beforeEach } from 'vitest';
Author
Member

Ahora se hace la redirección en el composable useRedirect

Ahora se hace la redirección en el composable useRedirect
jorgep added 1 commit 2024-05-14 11:07:38 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
90a9a7dcc7
fix: refs #6891 fix invoiceIntrastat test
jorgep changed title from WIP: #6891 showRightSideFilterPanel to #6891 showRightSideFilterPanel 2024-05-14 11:10:52 +00:00
jorgep requested review from alexm 2024-05-14 11:11:12 +00:00
jorgep added the
CR / Tests passed
label 2024-05-14 11:11:16 +00:00
alexm requested changes 2024-05-15 07:03:39 +00:00
Dismissed
alexm left a comment
Member

Revisar skeleton que salen mal

Revisar skeleton que salen mal
jorgep added 1 commit 2024-05-15 10:34:37 +00:00
Author
Member

Revisar skeleton que salen mal

En la rama de dev (desde local) esto también ocurre.

> Revisar skeleton que salen mal En la rama de dev (desde local) esto también ocurre.
alexm approved these changes 2024-05-15 12:51:18 +00:00
jorgep added 1 commit 2024-05-15 13:38:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
185b9daa25
Merge branch 'dev' into 6891-showRightSideFilterPanel
jorgep merged commit 662dfb15a4 into dev 2024-05-15 13:39:23 +00:00
jorgep deleted branch 6891-showRightSideFilterPanel 2024-05-15 13:39:23 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#353
No description provided.