#7281 solve terminal warnings #376

Merged
jorgep merged 6 commits from 7281-solveTerminalWarnings into dev 2024-05-16 07:19:16 +00:00
Member
No description provided.
jorgep added 1 commit 2024-05-15 12:31:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
628fc888ba
fix: refs #7281 fix warnings
jorgep added 1 commit 2024-05-15 12:32:49 +00:00
jorgep added the
CR / Tests passed
label 2024-05-15 12:42:33 +00:00
jorgep requested review from jgallego 2024-05-15 12:44:50 +00:00
jorgep added 1 commit 2024-05-15 13:42:22 +00:00
jorgep reviewed 2024-05-15 13:45:34 +00:00
@ -6,7 +6,7 @@ import FormModel from 'components/FormModel.vue';
const emit = defineEmits(['onDataSaved']);
const $props = defineProps({
Author
Member

no se usa. Sale warning.

no se usa. Sale warning.
jorgep reviewed 2024-05-15 13:45:41 +00:00
@ -29,10 +29,12 @@ async function confirm() {
const response = { address: address.value };
if (props.promise) {
isLoading.value = true;
const { address: _address, ...restData } = props.data;
Author
Member

no se usa _address. Sale warning.

no se usa _address. Sale warning.
jorgep reviewed 2024-05-15 13:46:27 +00:00
@ -33,3 +32,3 @@
try {
Object.assign(response, restData);
const dataCopy = JSON.parse(JSON.stringify({ ...props.data }));
Author
Member

Para copiar un objeto se hace así, si no , estás creando una referencia del mismo.

Para copiar un objeto se hace así, si no , estás creando una referencia del mismo.
Member

deepclone se llama

deepclone se llama
jorgep reviewed 2024-05-15 13:46:44 +00:00
@ -1,21 +1,16 @@
<script setup>
import { useI18n } from 'vue-i18n';
const props = defineProps({
Author
Member

no se usa. Sale warning.

no se usa. Sale warning.
jorgep reviewed 2024-05-15 13:46:56 +00:00
@ -17,4 +11,1 @@
const { t } = useI18n();
const entityId = computed(() => $props.id || route.params.id);
const filter = {
Author
Member

no se usa. Sale warning.

no se usa. Sale warning.
jorgep reviewed 2024-05-15 13:47:19 +00:00
@ -202,9 +202,9 @@ const toCustomerAddressEdit = (addressId) => {
<div v-if="item.observations.length">
<div
:key="index"
Author
Member

Se ha usado esta variable antes.sale warning.

Se ha usado esta variable antes.sale warning.
jorgep reviewed 2024-05-15 13:47:35 +00:00
@ -309,9 +309,9 @@ const addRow = () => {
const lastItemCopy = JSON.parse(
JSON.stringify(fixedPrices.value[fixedPrices.value.length - 1])
);
const { id, ...restOfItem } = lastItemCopy;
Author
Member

No se usa id, sale warning

No se usa id, sale warning
jgallego refused to review 2024-05-15 15:11:45 +00:00
jgallego requested review from jsegarra 2024-05-15 15:11:54 +00:00
jsegarra requested changes 2024-05-15 18:20:51 +00:00
Dismissed
jsegarra left a comment
Member

OrderSummary da warning

OrderSummary da warning
Member

image

![image](/attachments/3887df89-e506-45c9-9e47-25268c100221)
jsegarra reviewed 2024-05-15 18:28:27 +00:00
@ -203,3 +203,3 @@
<div v-if="item.observations.length">
<div
:key="index"
:key="obsIndex"
Member

se puede cambiar a ob?

se puede cambiar a ob?
Member

Propuesta, dejar la key como obIndex

Propuesta, dejar la key como obIndex
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-05-16 06:58:11 +00:00
Author
Member

image

Gestionado.

> ![image](/attachments/3887df89-e506-45c9-9e47-25268c100221) > Gestionado.
jorgep added 1 commit 2024-05-16 07:06:23 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1654fb93d4
fix: refs #6598 build
jorgep added 1 commit 2024-05-16 07:07:02 +00:00
jorgep requested review from jsegarra 2024-05-16 07:07:29 +00:00
jsegarra approved these changes 2024-05-16 07:17:42 +00:00
jorgep merged commit 0854fa67a8 into dev 2024-05-16 07:19:16 +00:00
jorgep deleted branch 7281-solveTerminalWarnings 2024-05-16 07:19:17 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#376
No description provided.