verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 67 Releases Wiki Activity

#6957: FetchedTags refactor template #382

Merged
jsegarra merged 11 commits from 6957_refactorFetechedTags into dev 2024-05-24 06:18:24 +00:00
Conversation 3 Commits 11 Files Changed 10 +39 -54
jsegarra commented 2024-05-16 20:59:56 +00:00
Member
Copy Link
No description provided.
jsegarra added 1 commit 2024-05-16 20:59:56 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
77a454b590 feat: refactor template
jsegarra added 2 commits 2024-05-16 21:02:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
dba42a6001 feat: #6957: Rename FetchedTags instance tag
jsegarra requested review from alexm 2024-05-16 21:03:13 +00:00
jsegarra requested review from carlossa 2024-05-16 21:03:13 +00:00
jsegarra changed title from feat: refactor template to #6957: FetchedTags refactor template 2024-05-16 21:10:03 +00:00
alexm requested changes 2024-05-17 11:28:17 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Ahora solo salen 4 de 6. No me deja hacer captura pero en TicketSummary se ve

Ahora solo salen 4 de 6. No me deja hacer captura pero en TicketSummary se ve
jsegarra added 2 commits 2024-05-17 11:57:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
08e6703853 style updates
jsegarra requested review from alexm 2024-05-17 11:57:16 +00:00
jsegarra commented 2024-05-17 11:58:36 +00:00
Author
Member
Copy Link

Resulta que vienen null
De echo, el title tambien es null. Lo he cambiado a que si el valor es null aparezca 'tagX:'

Resulta que vienen null De echo, el title tambien es null. Lo he cambiado a que si el valor es null aparezca 'tagX:'
jsegarra added 1 commit 2024-05-17 11:58:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
41e2462b49 Merge branch 'dev' into 6957_refactorFetechedTags
jsegarra added 1 commit 2024-05-18 06:53:14 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
632acc13ac style: reset poc style
jsegarra added 1 commit 2024-05-18 06:53:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7197881cdd style: reset poc style
alexm requested changes 2024-05-20 06:38:51 +00:00
Dismissed
alexm left a comment
Member
Copy Link

En salix los vacios tienen un color diferente:
image

En salix los vacios tienen un color diferente: ![image](/attachments/8cf9c11c-28bf-47b9-9f94-b9cee919947b)
image.png
14 KiB
jsegarra commented 2024-05-20 09:05:20 +00:00
Author
Member
Copy Link

Okey, gracias por el aporte.
Sin embargo, en Lilium no se está aplicando este estilo #382 (comment)

Aprovecho el refactor para corregir el fallo

Okey, gracias por el aporte. Sin embargo, en Lilium no se está aplicando este estilo https://gitea.verdnatura.es/verdnatura/salix-front/pulls/382#issuecomment-51860 Aprovecho el refactor para corregir el fallo
jsegarra added 1 commit 2024-05-20 09:16:10 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
febc88203d style: fix color when is empty
jsegarra commented 2024-05-20 09:16:31 +00:00
Author
Member
Copy Link

En salix los vacios tienen un color diferente:
image

FIXED!
image

> En salix los vacios tienen un color diferente: > ![image](/attachments/8cf9c11c-28bf-47b9-9f94-b9cee919947b) FIXED! ![image](/attachments/85bff7eb-bf9f-4b1c-a5f6-ae7c81f6bb19)
image.png
11 KiB
jsegarra requested review from alexm 2024-05-20 09:16:34 +00:00
jsegarra added 1 commit 2024-05-21 22:01:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ad328d9c51 Merge branch 'dev' into 6957_refactorFetechedTags
alexm approved these changes 2024-05-24 06:07:39 +00:00
jsegarra added 1 commit 2024-05-24 06:15:38 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d015a2e217 Merge branch 'dev' into 6957_refactorFetechedTags
carlossa approved these changes 2024-05-24 06:18:07 +00:00
jsegarra merged commit 515561b75d into dev 2024-05-24 06:18:24 +00:00
jsegarra deleted branch 6957_refactorFetechedTags 2024-05-24 06:18:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
carlossa
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#382
No description provided.
Delete Branch "6957_refactorFetechedTags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?