verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 93 Releases Wiki Activity

7366-travelMigration #430

Merged
carlossa merged 13 commits from 7366-travelMigration into dev 2024-06-18 06:03:42 +00:00
Conversation 0 Commits 13 Files Changed 7 +78 -52
carlossa commented 2024-06-07 12:02:54 +00:00
Member
Copy Link
No description provided.
carlossa added the
CR / Tests passed
 label 2024-06-07 12:02:54 +00:00
carlossa added 4 commits 2024-06-07 12:02:54 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
06ddcc5030 refs #7366 fix travel
carlossa requested review from alexm 2024-06-07 12:03:05 +00:00
alexm requested changes 2024-06-11 05:54:09 +00:00
Dismissed
src/components/FormModel.vue Outdated
@ -117,8 +117,8 @@ onMounted(async () => {
state.set($props.model, $props.formInitialData);
if ($props.autoLoad && !$props.formInitialData && $props.url) await fetch();
alexm commented 2024-06-11 05:52:59 +00:00
Member
Copy Link

Simplificar if

Simplificar if
carlossa marked this conversation as resolved
src/pages/Travel/Card/TravelDescriptorMenuItems.vue Outdated
@ -36,2 +35,3 @@
const cloneTravelWithEntries = async () => {
try {
axios.post(`Travels/${$props.travel.id}/cloneWithEntries`);
const { id } = await axios.post(`Travels/${$props.travel.id}/cloneWithEntries`);
alexm commented 2024-06-11 05:53:57 +00:00
Member
Copy Link

Revisar, normalmente se hace: const { data } = ... y de ahi ya el id

Revisar, normalmente se hace: `const { data } = ... ` y de ahi ya el id
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-06-11 06:35:47 +00:00
carlossa added 1 commit 2024-06-11 07:06:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
313395ef7c refs #7366 fix travelMigration
carlossa added 1 commit 2024-06-11 07:10:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8e9656f96a refs #7366 remove warning
carlossa requested review from alexm 2024-06-11 07:12:12 +00:00
alexm approved these changes 2024-06-11 08:06:45 +00:00
Dismissed
src/pages/Travel/Card/TravelDescriptorMenuItems.vue Outdated
@ -37,2 +37,3 @@
axios.post(`Travels/${$props.travel.id}/cloneWithEntries`);
const { data } = await axios.post(`Travels/${$props.travel.id}/cloneWithEntries`);
notify('globals.dataSaved', 'positive');
router.push({ name: 'TravelBasicData', params: { data } });
alexm commented 2024-06-11 08:06:41 +00:00
Member
Copy Link

data.id

data.id
carlossa marked this conversation as resolved
carlossa added 1 commit 2024-06-12 12:31:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
34e92d130a refs #7366 fix basic-data
carlossa dismissed alexm’s review 2024-06-12 12:31:33 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlossa added 1 commit 2024-06-13 06:50:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3958d5ab08 Merge branch 'dev' into 7366-travelMigration
carlossa added 2 commits 2024-06-14 08:47:11 +00:00
carlossa added 1 commit 2024-06-14 11:06:13 +00:00
carlossa added 1 commit 2024-06-17 06:39:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f4b7d34a7f refs #7366 fix redirect
alexm approved these changes 2024-06-18 06:01:42 +00:00
carlossa merged commit af59da33aa into dev 2024-06-18 06:03:42 +00:00
carlossa deleted branch 7366-travelMigration 2024-06-18 06:03:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#430
No description provided.
Delete Branch "7366-travelMigration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?