verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 80 Releases Wiki Activity

7366-travelMigration #430

Merged
carlossa merged 13 commits from 7366-travelMigration into dev 2024-06-18 06:03:42 +00:00
Conversation 0 Commits 13 Files Changed 7 +6 -5
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 313395ef7c - Show all commits

7
src/components/FormModel.vue
View File

@ -116,9 +116,10 @@ onMounted(async () => {
// Podemos enviarle al form la estructura de data inicial sin necesidad de fetchearla
state.set($props.model, $props.formInitialData);
if ($props.autoLoad && !$props.formInitialData && $props.url) await fetch();
else if (arrayData.store.data && !$props.formInitialData)
updateAndEmit(arrayData.store.data, 'onFetch');
if (!$props.formInitialData) {
carlossa marked this conversation as resolved Outdated
alexm commented 2024-06-11 05:52:59 +00:00
Outdated
Review
Copy Link

Simplificar if

Simplificar if
if ($props.autoLoad && $props.url) await fetch();
else if (arrayData.store.data) updateAndEmit(arrayData.store.data, 'onFetch');
}
if ($props.observeFormChanges) {
watch(
() => formData.value,

4
src/pages/Travel/Card/TravelDescriptorMenuItems.vue
View File

@ -34,9 +34,9 @@ const cloneTravel = () => {
const cloneTravelWithEntries = async () => {
try {
const { id } = await axios.post(`Travels/${$props.travel.id}/cloneWithEntries`);
const { data } = await axios.post(`Travels/${$props.travel.id}/cloneWithEntries`);
carlossa marked this conversation as resolved Outdated
alexm commented 2024-06-11 05:53:57 +00:00
Outdated
Review
Copy Link

Revisar, normalmente se hace: const { data } = ... y de ahi ya el id

Revisar, normalmente se hace: `const { data } = ... ` y de ahi ya el id
notify('globals.dataSaved', 'positive');
router.push({ name: 'TravelBasicData', params: { id } });
router.push({ name: 'TravelBasicData', params: { data } });
carlossa marked this conversation as resolved Outdated
alexm commented 2024-06-11 08:06:41 +00:00
Outdated
Review
Copy Link

data.id

data.id
} catch (err) {
console.err('Error cloning travel with entries');
}