verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

#6238 addPercentageColumn #443

Merged
jorgep merged 13 commits from 6238-addPercentageColumn into dev 2024-06-18 08:41:43 +00:00
Conversation 1 Commits 13 Files Changed 4 +76 -17
jorgep commented 2024-06-12 14:00:08 +00:00
Member
Copy Link
No description provided.
jorgep added 5 commits 2024-06-12 14:00:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
19aa1bf01d fix; refs #6238 fix test
jorgep added the
CR / Tests passed
 label 2024-06-12 14:00:20 +00:00
jorgep reviewed 2024-06-12 14:00:50 +00:00
src/components/FormModel.vue Outdated
@ -90,3 +90,3 @@
);
const componentIsRendered = ref(false);
const arrayData = useArrayData(modelValue);
const arrayData = useArrayData(modelValue.value);
jorgep commented 2024-06-12 14:00:50 +00:00
Author
Member
Copy Link

Faltaba ponerlo.

Faltaba ponerlo.
alexm commented 2024-06-18 08:06:06 +00:00
Member
Copy Link

Revisar

Revisar
jorgep reviewed 2024-06-12 14:01:25 +00:00
src/components/ui/CardDescriptor.vue
@ -115,13 +115,13 @@ const emit = defineEmits(['onFetch']);
</QBtn>
</RouterLink>
<QBtn
v-if="$slots.menu"
jorgep commented 2024-06-12 14:01:25 +00:00
Author
Member
Copy Link

Así lo oculta. y permite que haya una disposición de 3 btn en todo el ancho.

Así lo oculta. y permite que haya una disposición de 3 btn en todo el ancho.
jorgep requested review from jgallego 2024-06-12 14:13:40 +00:00
jorgep commented 2024-06-12 14:13:56 +00:00
Author
Member
Copy Link

@jgallego hay que revisar la interfaz

@jgallego hay que revisar la interfaz
jgallego requested changes 2024-06-12 14:20:52 +00:00
Dismissed
src/pages/Travel/ExtraCommunity.vue Outdated
@ -509,0 +517,4 @@
:class="{
'bg-red-10': getKgPercentage(props.row) >= 100,
'bg-deep-orange-10':
getKgPercentage(props.row) >= 80 &&
jgallego commented 2024-06-12 14:20:37 +00:00
Owner
Copy Link

numero en el codigo no tabla

numero en el codigo no tabla
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-06-12 14:46:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7393b82008 refactor: refs #6238 update getRate function and color logic
jorgep requested review from jgallego 2024-06-12 14:46:36 +00:00
jgallego requested changes 2024-06-13 13:23:18 +00:00
Dismissed
src/pages/Travel/ExtraCommunity.vue Outdated
@ -422,0 +438,4 @@
const getColor = (percentage) => {
if (percentage >= 100) return 'red-10';
else if (percentage >= 80 && percentage < 100) return 'deep-orange-10';
jgallego commented 2024-06-13 13:23:16 +00:00
Owner
Copy Link

mover esto a la tabla que hemos hablado

mover esto a la tabla que hemos hablado
jorgep marked this conversation as resolved
jorgep added 2 commits 2024-06-14 12:52:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
bd6e45d260 refactor: refs #6238 get percentage from back
jorgep requested review from jgallego 2024-06-14 12:53:09 +00:00
jgallego requested changes 2024-06-15 13:12:20 +00:00
Dismissed
src/pages/Travel/ExtraCommunity.vue Outdated
@ -581,0 +623,4 @@
.bg-travel {
background-color: var(--vn-page-color);
border-bottom: 1.6px solid orange;
jgallego commented 2024-06-15 13:12:00 +00:00
Owner
Copy Link

Usa una variable

Usa una variable
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-06-17 08:39:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
94f4e154b0 refactor: refs #6238 use variable & link class
jorgep requested review from jgallego 2024-06-17 08:40:50 +00:00
jorgep reviewed 2024-06-17 10:30:57 +00:00
test/cypress/integration/VnLocation.spec.js
@ -2,8 +2,7 @@ const locationOptions = '[role="listbox"] > div.q-virtual-scroll__content > .q-i
describe('VnLocation', () => {
jorgep commented 2024-06-17 10:30:57 +00:00
Author
Member
Copy Link

Corrige el test

Corrige el test
alexm commented 2024-06-18 08:07:00 +00:00
Member
Copy Link

Separar a rama nueva

Separar a rama nueva
jorgep added 1 commit 2024-06-18 07:54:43 +00:00
jorgep added 2 commits 2024-06-18 08:13:48 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3f2779600a fix: refs #6238 drop old fix
jorgep added 1 commit 2024-06-18 08:14:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
14ef5ccefd fix: refs #6238 rollback
jgallego approved these changes 2024-06-18 08:40:07 +00:00
jorgep merged commit 4c40244d41 into dev 2024-06-18 08:41:43 +00:00
jorgep deleted branch 6238-addPercentageColumn 2024-06-18 08:41:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#443
No description provided.
Delete Branch "6238-addPercentageColumn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?